Use direct vector declarations in AI tests

src/test/cpp/net/eagle0/shardok/ai/AIAttackGroups_test.cpp

@@ -23,7 +23,7 @@ class AIAttackGroupsTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(0, 0)),
                 AddGenericUnit(0, 1, Coords(0, 1)),
                 AddGenericUnit(0, 2, Coords(5, 0)),
@@ -287,4 +287,4 @@ TEST_F(AIAttackGroupsTest, targetPriorities_assignHighestPowerFirst) {
                             .target = Coords(0, 5),
                             .attackLocations = upperRightAttackLocations}}),
             tpls[2].priorityOrder);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIAttackerStrategySelector_test.cpp

@@ -20,7 +20,7 @@ class AIAttackerStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIDefenderStrategySelector_test.cpp

@@ -21,7 +21,7 @@ class AIStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),
@@ -291,4 +291,4 @@ TEST_F(AIStrategySelectorTest,
                         return GetGameSettings()->GetGetter().GetBattalionType(typeId);
                     })
                     .strategyType);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIScoreUtilities_test.cpp

@@ -17,7 +17,7 @@ class AIScoreUtilitiesTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIWaterCrossingCalculator_test.cpp

@@ -26,7 +26,7 @@ class AIWaterCrossingCalculatorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0))};
 

src/test/cpp/net/eagle0/shardok/library/GameStart_test_data.cpp

@@ -49,7 +49,7 @@ auto AddPlayerInfo(
         -> flatbuffers::Offset<net::eagle0::shardok::storage::fb::PlayerInfo> {
     const auto victoryConditionsOffset = fbb.CreateVector(victoryConditions);
 
-    std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer> alliesVec;
+    auto alliesVec = std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer>();
     for (int pid : allyPids) { alliesVec.emplace_back(pid); }
     const auto alliesOffset = fbb.CreateVectorOfStructs(alliesVec);
 

src/test/cpp/net/eagle0/shardok/library/ShardokEngineBasedTestData.cpp

@@ -87,7 +87,7 @@ static auto GameWithUnitTs(
     endGameCondition.mutate_victory_details(
             net::eagle0::shardok::storage::fb::VictoryCondition_UNKNOWN_VICTORY_CONDITION);
 
-    std::vector<PlayerId> winningIdsVec{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
+    auto winningIdsVec = std::vector<PlayerId>{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
     auto winningIdsOff = fbb.CreateVector(winningIdsVec);
     auto statusB = net::eagle0::shardok::storage::fb::GameStatusBuilder(fbb);
     statusB.add_state(

src/test/cpp/net/eagle0/shardok/library/util/HexMapUtils_test.cpp

@@ -32,7 +32,7 @@ class HexMapUtilsTest : public ::testing::Test {
         auto enemyUnitOffset = AddGenericUnit(enemyPlayerId, 2, Coords(1, 1));
         auto hiddenEnemyOffset = AddGenericUnit(enemyPlayerId, 3, Coords(1, 2));
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 ownUnitOffset,
                 alliedUnitOffset,
                 enemyUnitOffset,