Use direct vector declarations in AI tests

src/test/cpp/net/eagle0/shardok/ai/AIAttackGroups_test.cpp

@@ -23,7 +23,7 @@ class AIAttackGroupsTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(0, 0)),
                 AddGenericUnit(0, 1, Coords(0, 1)),
                 AddGenericUnit(0, 2, Coords(5, 0)),
@@ -287,4 +287,4 @@ TEST_F(AIAttackGroupsTest, targetPriorities_assignHighestPowerFirst) {
                             .target = Coords(0, 5),
                             .attackLocations = upperRightAttackLocations}}),
             tpls[2].priorityOrder);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIAttackerStrategySelector_test.cpp

@@ -20,7 +20,7 @@ class AIAttackerStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIDefenderStrategySelector_test.cpp

@@ -21,7 +21,7 @@ class AIStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),
@@ -291,4 +291,4 @@ TEST_F(AIStrategySelectorTest,
                         return GetGameSettings()->GetGetter().GetBattalionType(typeId);
                     })
                     .strategyType);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIScoreUtilities_test.cpp

@@ -17,7 +17,7 @@ class AIScoreUtilitiesTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIWaterCrossingCalculator_test.cpp

@@ -26,7 +26,7 @@ class AIWaterCrossingCalculatorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0))};
 

src/test/cpp/net/eagle0/shardok/library/command_factories/BlowBridgeCommandFactory_test.cpp

@@ -29,7 +29,7 @@ class BlowBridgeCommandFactoryTests : public ::testing::Test {
 
         auto engOff = AddGenericUnit(1, 0, bridgePosition);
         auto otherOff = AddGenericUnit(2, 1, adjacentOccupied);
-        vector<Unit> units_vec{engOff, otherOff};
+        auto units_vec = vector<Unit>{engOff, otherOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&units_vec);
 
         auto mapOff = AddBasicMap(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/BuildBridgeCommandFactory_test.cpp

@@ -20,7 +20,7 @@ class BuildBridgeCommandFactoryTests : public ::testing::Test {
         fbb.ForceDefaults(true);
         const auto engOff = AddGenericUnit(1, 0, position);
 
-        vector<Unit> unitsVec{engOff};
+        auto unitsVec = vector<Unit>{engOff};
         const auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         fbb.Finish(unitsOff);

src/test/cpp/net/eagle0/shardok/library/command_factories/FearCommandFactory_test.cpp

@@ -23,7 +23,7 @@ class FearCommandFactoryTests : public ::testing::Test {
         auto necroOff = AddGenericUnit(1, 0, position);
         auto targetOff = AddGenericUnit(5, 1, adjacentPosition);
 
-        vector<Unit> unitsVec{necroOff, targetOff};
+        auto unitsVec = vector<Unit>{necroOff, targetOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/HolyWaveCommandFactory_test.cpp

@@ -43,7 +43,7 @@ class HolyWaveCommandFactoryTests : public ::testing::Test {
         auto actorOff = AddGenericUnit(1, 0, position);
         auto otherOff = AddGenericUnit(5, 1, Coords(5, 5));
 
-        vector<Unit> unitsVec{actorOff, otherOff};
+        auto unitsVec = vector<Unit>{actorOff, otherOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);