Use direct vector declarations in AI tests

src/test/cpp/net/eagle0/shardok/ai/AIAttackGroups_test.cpp

@@ -23,7 +23,7 @@ class AIAttackGroupsTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(0, 0)),
                 AddGenericUnit(0, 1, Coords(0, 1)),
                 AddGenericUnit(0, 2, Coords(5, 0)),
@@ -287,4 +287,4 @@ TEST_F(AIAttackGroupsTest, targetPriorities_assignHighestPowerFirst) {
                             .target = Coords(0, 5),
                             .attackLocations = upperRightAttackLocations}}),
             tpls[2].priorityOrder);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIAttackerStrategySelector_test.cpp

@@ -20,7 +20,7 @@ class AIAttackerStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIDefenderStrategySelector_test.cpp

@@ -21,7 +21,7 @@ class AIStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),
@@ -291,4 +291,4 @@ TEST_F(AIStrategySelectorTest,
                         return GetGameSettings()->GetGetter().GetBattalionType(typeId);
                     })
                     .strategyType);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIScoreUtilities_test.cpp

@@ -17,7 +17,7 @@ class AIScoreUtilitiesTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIWaterCrossingCalculator_test.cpp

@@ -26,7 +26,7 @@ class AIWaterCrossingCalculatorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0))};
 

src/test/cpp/net/eagle0/shardok/library/commands/DismissUnitCommand_test.cpp

@@ -23,7 +23,7 @@ class DismissUnitCommandTest : public ::testing::Test {
         auto actorOff = AddGenericUnit(5, 0, Coords(1, 1));
         auto undeadOff = AddGenericUndead(5, 1, Coords(3, 3));
 
-        vector<Unit> unitsVec{actorOff, undeadOff};
+        auto unitsVec = vector<Unit>{actorOff, undeadOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         GameStateBuilder gsb(fbb);

src/test/cpp/net/eagle0/shardok/library/commands/EndTurnCommand_test.cpp

@@ -29,7 +29,7 @@ class EndTurnCommandTest : public ::testing::Test {
 
         auto otherOffset = AddGenericUnit(1, 1, Coords(1, 1));
 
-        std::vector<Unit> unitsVec{casterOffset, otherOffset};
+        auto unitsVec = std::vector<Unit>{casterOffset, otherOffset};
         auto unitsOffset = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto hexMap = AddHexMap(fbb, BASIC_MAP_FB);
@@ -44,10 +44,10 @@ class EndTurnCommandTest : public ::testing::Test {
         statusB.add_state(net::eagle0::shardok::storage::fb::GameStatus_::State_GAME_RUNNING);
         auto statusOffset = statusB.Finish();
 
-        std::vector<UnitId> chargeesVec(6, -1);
+        auto chargeesVec = std::vector<UnitId>(6, -1);
         auto chargeesOffset = fbb.CreateVector(chargeesVec);
 
-        vector<flatbuffers::Offset<PlayerInfo>> pisVec{
+        auto pisVec = vector<flatbuffers::Offset<PlayerInfo>>{
                 AddPlayerInfo(fbb, 0, false, 1000),
                 AddPlayerInfo(fbb, 1, true, 1000)};
         auto pisOffset = fbb.CreateVector(pisVec);

src/test/cpp/net/eagle0/shardok/library/commands/EvacuatePrisonersCommand_test.cpp

@@ -21,7 +21,7 @@ class EvacuatePrisonersCommandTest : public ::testing::Test {
         fbb.ForceDefaults(true);
         auto actorOff = AddGenericUnit(0, 0, Coords(3, 3));
         auto captiveOff = AddGenericUnit(1, 1, Coords(4, 4));
-        std::vector<Unit> unitsVec{actorOff, captiveOff};
+        auto unitsVec = std::vector<Unit>{actorOff, captiveOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         GameStateBuilder gsb(fbb);

src/test/cpp/net/eagle0/shardok/library/commands/challenge_duel_command/ChallengeDuelCommand_test.cpp

@@ -37,7 +37,7 @@ class ChallengeDuelCommandTests : public ::testing::Test {
         auto defenderOff = AddGenericUnit(1, 0, Coords(0, 1));
         auto challengerOff = AddGenericUnit(0, 1, Coords(0, 0));
 
-        std::vector<Unit> units{defenderOff, challengerOff};
+        auto units = std::vector<Unit>{defenderOff, challengerOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&units);
 
         auto mapOffset = AddBasicMap(fbb);