Use direct combat factory vector declarations

src/test/cpp/net/eagle0/shardok/library/GameStart_test_data.cpp

@@ -49,7 +49,7 @@ auto AddPlayerInfo(
         -> flatbuffers::Offset<net::eagle0::shardok::storage::fb::PlayerInfo> {
     const auto victoryConditionsOffset = fbb.CreateVector(victoryConditions);
 
-    std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer> alliesVec;
+    auto alliesVec = std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer>();
     for (int pid : allyPids) { alliesVec.emplace_back(pid); }
     const auto alliesOffset = fbb.CreateVectorOfStructs(alliesVec);
 

src/test/cpp/net/eagle0/shardok/library/ShardokEngineBasedTestData.cpp

@@ -87,7 +87,7 @@ static auto GameWithUnitTs(
     endGameCondition.mutate_victory_details(
             net::eagle0::shardok::storage::fb::VictoryCondition_UNKNOWN_VICTORY_CONDITION);
 
-    std::vector<PlayerId> winningIdsVec{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
+    auto winningIdsVec = std::vector<PlayerId>{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
     auto winningIdsOff = fbb.CreateVector(winningIdsVec);
     auto statusB = net::eagle0::shardok::storage::fb::GameStatusBuilder(fbb);
     statusB.add_state(

src/test/cpp/net/eagle0/shardok/library/command_factories/archery_command_factory/ArcheryCommandFactory_test.cpp

@@ -49,7 +49,7 @@ class ArcheryCommandFactoryTest : public ::testing::Test {
         auto def1Offset = AddGenericUnit(1, 1, def1pos);
         auto def2Offset = AddGenericUnit(1, 2, def2pos);
 
-        auto vec = vector<Unit>{attackerUnit, def1Offset, def2Offset};
+        vector<Unit> vec{attackerUnit, def1Offset, def2Offset};
         auto u = fbb.CreateVectorOfSortedStructs(&vec);
 
         fbb.Finish(u);

src/test/cpp/net/eagle0/shardok/library/command_factories/melee_command_factory/MeleeCommandFactory_test.cpp

@@ -22,7 +22,7 @@ class MeleeCommandFactoryTests : public ::testing::Test {
         auto actorOff = AddGenericUnit(5, 0, position);
         auto defenderOff = AddGenericUnit(3, 1, defenderPosition);
 
-        auto unitsVec = std::vector<Unit>{actorOff, defenderOff};
+        std::vector<Unit> unitsVec{actorOff, defenderOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);

src/test/cpp/net/eagle0/shardok/library/util/HexMapUtils_test.cpp

@@ -32,7 +32,7 @@ class HexMapUtilsTest : public ::testing::Test {
         auto enemyUnitOffset = AddGenericUnit(enemyPlayerId, 2, Coords(1, 1));
         auto hiddenEnemyOffset = AddGenericUnit(enemyPlayerId, 3, Coords(1, 2));
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 ownUnitOffset,
                 alliedUnitOffset,
                 enemyUnitOffset,