Use direct combat factory vector declarations

src/test/cpp/net/eagle0/shardok/library/action_point_distances/ActionPointDistances_test.cpp

@@ -28,11 +28,11 @@ class ActionPointDistancesTest : public ::testing::Test {
         //  P P P M P P
 
         // const_cast is safe because we own the mutable buffer (map)
-        for (int i = 6; i < 12; ++i) {
+        for (int i = 6; i < 12; i++) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_FOREST);
         }
-        for (int i = 18; i < 24; ++i) {
+        for (int i = 18; i < 24; i++) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_RIVER);
         }

src/test/cpp/net/eagle0/shardok/library/command_factories/archery_command_factory/ArcheryCommandFactory_test.cpp

@@ -49,7 +49,7 @@ class ArcheryCommandFactoryTest : public ::testing::Test {
         auto def1Offset = AddGenericUnit(1, 1, def1pos);
         auto def2Offset = AddGenericUnit(1, 2, def2pos);
 
-        auto vec = vector<Unit>{attackerUnit, def1Offset, def2Offset};
+        vector<Unit> vec{attackerUnit, def1Offset, def2Offset};
         auto u = fbb.CreateVectorOfSortedStructs(&vec);
 
         fbb.Finish(u);

src/test/cpp/net/eagle0/shardok/library/command_factories/melee_command_factory/MeleeCommandFactory_test.cpp

@@ -22,7 +22,7 @@ class MeleeCommandFactoryTests : public ::testing::Test {
         auto actorOff = AddGenericUnit(5, 0, position);
         auto defenderOff = AddGenericUnit(3, 1, defenderPosition);
 
-        auto unitsVec = std::vector<Unit>{actorOff, defenderOff};
+        std::vector<Unit> unitsVec{actorOff, defenderOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);