Use direct vector declarations in test helpers

src/test/cpp/net/eagle0/shardok/library/GameStart_test_data.cpp

@@ -49,7 +49,7 @@ auto AddPlayerInfo(
         -> flatbuffers::Offset<net::eagle0::shardok::storage::fb::PlayerInfo> {
     const auto victoryConditionsOffset = fbb.CreateVector(victoryConditions);
 
-    auto alliesVec = std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer>();
+    std::vector<net::eagle0::shardok::storage::fb::AlliedPlayer> alliesVec;
     for (int pid : allyPids) { alliesVec.emplace_back(pid); }
     const auto alliesOffset = fbb.CreateVectorOfStructs(alliesVec);
 

src/test/cpp/net/eagle0/shardok/library/GtestExtensions.hpp

@@ -67,7 +67,7 @@ void EXPECT_CONTAINS(const VecT& vec, const T& obj) {
 
 template<class VecT, class F>
 auto CHECK_NOCONTAINS_WHERE(const VecT& vec, F where) -> bool {
-    for (size_t i = 0; i < vec.size(); ++i) {
+    for (size_t i = 0; i < vec.size(); i++) {
         if (where(vec[i])) {
             std::cout << "Found at index " << i << '\n';
             return false;

src/test/cpp/net/eagle0/shardok/library/PercentileRollDifficulty_test.cpp

@@ -18,7 +18,7 @@ TEST(PercentileRollOddsTests, singleStat_returnsExpected) {
     const std::vector<double> expectedBonuses =
             {-25.0, -12.8, -3.125, -0.2, 0.0, 0.2, 3.125, 12.8, 25.0, 28.1216};
 
-    for (size_t i = 0; i < stats.size(); ++i) {
+    for (size_t i = 0; i < stats.size(); i++) {
         EXPECT_DOUBLE_EQ(expectedBonuses[i], BonusFromStat(stats[i]));
     }
 }

src/test/cpp/net/eagle0/shardok/library/ShardokEngineBasedTestData.cpp

@@ -87,7 +87,7 @@ static auto GameWithUnitTs(
     endGameCondition.mutate_victory_details(
             net::eagle0::shardok::storage::fb::VictoryCondition_UNKNOWN_VICTORY_CONDITION);
 
-    auto winningIdsVec = std::vector<PlayerId>{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
+    std::vector<PlayerId> winningIdsVec{-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
     auto winningIdsOff = fbb.CreateVector(winningIdsVec);
     auto statusB = net::eagle0::shardok::storage::fb::GameStatusBuilder(fbb);
     statusB.add_state(

src/test/cpp/net/eagle0/shardok/library/ShardokUnit_test.cpp

@@ -85,7 +85,7 @@ TEST_F(UnitTests, giveCasualties_raisesMorale) {
 }
 
 TEST_F(UnitTests, Vigor_changesActionPoints) {
-    for (int i = 1; i < 100; ++i) {
+    for (int i = 1; i < 100; i++) {
         Unit ui1 = GetUnitT1();
         ui1.mutable_attached_hero().mutate_vigor(i);
         ui1.mutable_battalion().mutate_morale(50);
@@ -115,7 +115,7 @@ TEST_F(UnitTests, MaxVigor_elevenActionPoints) {
 }
 
 TEST_F(UnitTests, Morale_changesActionPoints) {
-    for (int i = 1; i < 100; ++i) {
+    for (int i = 1; i < 100; i++) {
         Unit ui1 = GetUnitT1();
         ui1.mutable_attached_hero().mutate_vigor(50);
         ui1.mutable_battalion().mutate_morale(i);

src/test/cpp/net/eagle0/shardok/library/util/HexMapUtils_test.cpp

@@ -32,7 +32,7 @@ class HexMapUtilsTest : public ::testing::Test {
         auto enemyUnitOffset = AddGenericUnit(enemyPlayerId, 2, Coords(1, 1));
         auto hiddenEnemyOffset = AddGenericUnit(enemyPlayerId, 3, Coords(1, 2));
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 ownUnitOffset,
                 alliedUnitOffset,
                 enemyUnitOffset,