Use direct vector declarations in command factory tests

src/test/cpp/net/eagle0/shardok/library/command_factories/EvacuatePrisonersCommandFactory_test.cpp

@@ -23,7 +23,7 @@ class EvacuatePrisonersCommandFactoryTest : public ::testing::Test {
         auto actorOff = AddGenericUnit(0, 0, position);
         auto enemyCaptiveOff = AddGenericUnit(1, 1, Coords(4, 4));
         auto alliedCaptiveOff = AddGenericUnit(2, 2, Coords(5, 5));
-        auto unitsVec = std::vector<Unit>{actorOff, enemyCaptiveOff, alliedCaptiveOff};
+        std::vector<Unit> unitsVec{actorOff, enemyCaptiveOff, alliedCaptiveOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         GameStateBuilder gsb(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/MoveCommandFactory_test.cpp

@@ -16,7 +16,7 @@ class MoveCommandFactoryTest : public ::testing::Test {
         auto actorOff = AddGenericUnit(1, 3, position);
         auto enemyOff = AddGenericUnit(0, 2, Coords(3, 2));
 
-        auto vec = vector<Unit>{actorOff, enemyOff};
+        vector<Unit> vec{actorOff, enemyOff};
         auto u = fbb.CreateVectorOfSortedStructs(&vec);
 
         fbb.Finish(u);

src/test/cpp/net/eagle0/shardok/library/command_factories/ReinforceCommandFactory_test.cpp

@@ -44,7 +44,7 @@ class ReinforceCommandFactoryTest : public ::testing::Test {
         auto defenderOffset = AddGenericUnit(1, 2, Coords(2, 5));
         auto anotherReserveOffset = AddGenericUnit(2, 3, Coords(-1, -1));
 
-        auto unitsVec = std::vector<Unit>{
+        std::vector<Unit> unitsVec{
                 attacker1Offset,
                 reserveAttackerOffset,
                 defenderOffset,

src/test/cpp/net/eagle0/shardok/library/command_factories/ScoutCommandFactory_test.cpp

@@ -29,7 +29,7 @@ class ScoutCommandFactoryTests : public ::testing::Test {
         fbb.ForceDefaults(true);
 
         auto rangerOff = AddGenericUnit(5, 0, position);
-        auto unitsVec = std::vector<Unit>{rangerOff};
+        std::vector<Unit> unitsVec{rangerOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/StartFireCommandFactory_test.cpp

@@ -34,7 +34,7 @@ class StartFireCommandFactoryTest : public ::testing::Test {
         auto friendlyOffset = AddGenericUnit(0, 1, Coords(5, 5));
         auto defenderOffset = AddGenericUnit(1, 2, Coords(2, 0));
 
-        auto unitsVec = vector<Unit>{attackerOffset, friendlyOffset, defenderOffset};
+        vector<Unit> unitsVec{attackerOffset, friendlyOffset, defenderOffset};
         auto unitsOffset = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         weather = WeatherFb();

src/test/cpp/net/eagle0/shardok/library/commands/ExtinguishFireCommand_test.cpp

@@ -64,7 +64,7 @@ TEST_F(ExtinguishFireCommandTests, Execute_givesAgilityXp) {
     actor->mutable_attached_hero().mutate_agility_xp(11);
     actor->mutable_attached_hero().mutate_wisdom_xp(33);
 
-    std::vector<double> rolls{0.50};
+    auto rolls = std::vector<double>{0.50};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = ExtinguishFireCommand(
@@ -83,7 +83,7 @@ TEST_F(ExtinguishFireCommandTests, Execute_givesAgilityXp) {
 }
 
 TEST_F(ExtinguishFireCommandTests, ExecuteLowRoll_extinguishesFire) {
-    std::vector<double> rolls{0.25};
+    auto rolls = std::vector<double>{0.25};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);
@@ -107,7 +107,7 @@ TEST_F(ExtinguishFireCommandTests, ExecuteLowRoll_extinguishesFire) {
 }
 
 TEST_F(ExtinguishFireCommandTests, ExecuteHighRoll_doesNotExtinguish) {
-    std::vector<double> rolls{0.75};
+    auto rolls = std::vector<double>{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);
@@ -129,7 +129,7 @@ TEST_F(ExtinguishFireCommandTests, ExecuteHighRoll_doesNotExtinguish) {
 TEST_F(ExtinguishFireCommandTests, ExecuteHiddenActor_unhides) {
     actor->mutate_hidden(true);
 
-    std::vector<double> rolls{0.75};
+    auto rolls = std::vector<double>{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);

src/test/cpp/net/eagle0/shardok/library/commands/StartFireCommand_test.cpp

@@ -58,7 +58,7 @@ public:
 };
 
 TEST_F(StartFireCommandTests, ExecuteLowRoll_startsFire) {
-    std::vector<double> rolls{0.25};
+    auto rolls = std::vector<double>{0.25};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = StartFireCommand(
@@ -81,7 +81,7 @@ TEST_F(StartFireCommandTests, ExecuteLowRoll_startsFire) {
 }
 
 TEST_F(StartFireCommandTests, ExecuteHighRoll_doesNotStartFire) {
-    std::vector<double> rolls{0.75};
+    auto rolls = std::vector<double>{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = StartFireCommand(