Use pre-increment in action point tests

src/test/cpp/net/eagle0/shardok/ai/AIAttackGroups_test.cpp

@@ -23,7 +23,7 @@ class AIAttackGroupsTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(0, 0)),
                 AddGenericUnit(0, 1, Coords(0, 1)),
                 AddGenericUnit(0, 2, Coords(5, 0)),
@@ -287,4 +287,4 @@ TEST_F(AIAttackGroupsTest, targetPriorities_assignHighestPowerFirst) {
                             .target = Coords(0, 5),
                             .attackLocations = upperRightAttackLocations}}),
             tpls[2].priorityOrder);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIAttackerStrategySelector_test.cpp

@@ -20,7 +20,7 @@ class AIAttackerStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIDefenderStrategySelector_test.cpp

@@ -21,7 +21,7 @@ class AIStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),
@@ -291,4 +291,4 @@ TEST_F(AIStrategySelectorTest,
                         return GetGameSettings()->GetGetter().GetBattalionType(typeId);
                     })
                     .strategyType);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIScoreUtilities_test.cpp

@@ -17,7 +17,7 @@ class AIScoreUtilitiesTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIWaterCrossingCalculator_test.cpp

@@ -26,7 +26,7 @@ class AIWaterCrossingCalculatorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0))};
 

src/test/cpp/net/eagle0/shardok/library/action_point_distances/ActionPointDistances_test.cpp

@@ -28,11 +28,11 @@ class ActionPointDistancesTest : public ::testing::Test {
         //  P P P M P P
 
         // const_cast is safe because we own the mutable buffer (map)
-        for (int i = 6; i < 12; i++) {
+        for (int i = 6; i < 12; ++i) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_FOREST);
         }
-        for (int i = 18; i < 24; i++) {
+        for (int i = 18; i < 24; ++i) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_RIVER);
         }