Use direct fire roll vector declarations

src/test/cpp/net/eagle0/shardok/ai/AIAttackGroups_test.cpp

@@ -23,7 +23,7 @@ class AIAttackGroupsTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(0, 0)),
                 AddGenericUnit(0, 1, Coords(0, 1)),
                 AddGenericUnit(0, 2, Coords(5, 0)),
@@ -287,4 +287,4 @@ TEST_F(AIAttackGroupsTest, targetPriorities_assignHighestPowerFirst) {
                             .target = Coords(0, 5),
                             .attackLocations = upperRightAttackLocations}}),
             tpls[2].priorityOrder);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIAttackerStrategySelector_test.cpp

@@ -20,7 +20,7 @@ class AIAttackerStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIDefenderStrategySelector_test.cpp

@@ -21,7 +21,7 @@ class AIStrategySelectorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),
@@ -291,4 +291,4 @@ TEST_F(AIStrategySelectorTest,
                         return GetGameSettings()->GetGetter().GetBattalionType(typeId);
                     })
                     .strategyType);
-}
+}

src/test/cpp/net/eagle0/shardok/ai/AIScoreUtilities_test.cpp

@@ -17,7 +17,7 @@ class AIScoreUtilitiesTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0)),
                 AddGenericUnit(0, 2, Coords(5, 5)),

src/test/cpp/net/eagle0/shardok/ai/AIWaterCrossingCalculator_test.cpp

@@ -26,7 +26,7 @@ class AIWaterCrossingCalculatorTest : public ::testing::Test {
         flatbuffers::FlatBufferBuilder fbb;
         fbb.ForceDefaults(true);
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 AddGenericUnit(0, 0, Coords(5, 0)),
                 AddGenericUnit(0, 1, Coords(4, 0))};
 

src/test/cpp/net/eagle0/shardok/library/commands/ExtinguishFireCommand_test.cpp

@@ -64,7 +64,7 @@ TEST_F(ExtinguishFireCommandTests, Execute_givesAgilityXp) {
     actor->mutable_attached_hero().mutate_agility_xp(11);
     actor->mutable_attached_hero().mutate_wisdom_xp(33);
 
-    auto rolls = std::vector<double>{0.50};
+    std::vector<double> rolls{0.50};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = ExtinguishFireCommand(
@@ -83,7 +83,7 @@ TEST_F(ExtinguishFireCommandTests, Execute_givesAgilityXp) {
 }
 
 TEST_F(ExtinguishFireCommandTests, ExecuteLowRoll_extinguishesFire) {
-    auto rolls = std::vector<double>{0.25};
+    std::vector<double> rolls{0.25};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);
@@ -107,7 +107,7 @@ TEST_F(ExtinguishFireCommandTests, ExecuteLowRoll_extinguishesFire) {
 }
 
 TEST_F(ExtinguishFireCommandTests, ExecuteHighRoll_doesNotExtinguish) {
-    auto rolls = std::vector<double>{0.75};
+    std::vector<double> rolls{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);
@@ -129,7 +129,7 @@ TEST_F(ExtinguishFireCommandTests, ExecuteHighRoll_doesNotExtinguish) {
 TEST_F(ExtinguishFireCommandTests, ExecuteHiddenActor_unhides) {
     actor->mutate_hidden(true);
 
-    auto rolls = std::vector<double>{0.75};
+    std::vector<double> rolls{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     GetMutableTerrain(hexMap, Coords(3, 3))->mutable_modifier().mutable_fire().mutate_present(true);

src/test/cpp/net/eagle0/shardok/library/commands/StartFireCommand_test.cpp

@@ -58,7 +58,7 @@ public:
 };
 
 TEST_F(StartFireCommandTests, ExecuteLowRoll_startsFire) {
-    auto rolls = std::vector<double>{0.25};
+    std::vector<double> rolls{0.25};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = StartFireCommand(
@@ -81,7 +81,7 @@ TEST_F(StartFireCommandTests, ExecuteLowRoll_startsFire) {
 }
 
 TEST_F(StartFireCommandTests, ExecuteHighRoll_doesNotStartFire) {
-    auto rolls = std::vector<double>{0.75};
+    std::vector<double> rolls{0.75};
     const auto generator = std::make_shared<SequenceRandomGenerator>(rolls);
 
     const auto results = StartFireCommand(