Use pre-increment in action point tests

src/test/cpp/net/eagle0/shardok/library/action_point_distances/ActionPointDistances_test.cpp

@@ -28,11 +28,11 @@ class ActionPointDistancesTest : public ::testing::Test {
         //  P P P M P P
 
         // const_cast is safe because we own the mutable buffer (map)
-        for (int i = 6; i < 12; i++) {
+        for (int i = 6; i < 12; ++i) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_FOREST);
         }
-        for (int i = 18; i < 24; i++) {
+        for (int i = 18; i < 24; ++i) {
             const_cast<Terrain*>(map->mutable_terrain()->GetMutableObject(i))
                     ->mutate_type(net::eagle0::shardok::storage::fb::Terrain_::Type_RIVER);
         }

src/test/cpp/net/eagle0/shardok/library/command_factories/EvacuatePrisonersCommandFactory_test.cpp

@@ -23,7 +23,7 @@ class EvacuatePrisonersCommandFactoryTest : public ::testing::Test {
         auto actorOff = AddGenericUnit(0, 0, position);
         auto enemyCaptiveOff = AddGenericUnit(1, 1, Coords(4, 4));
         auto alliedCaptiveOff = AddGenericUnit(2, 2, Coords(5, 5));
-        std::vector<Unit> unitsVec{actorOff, enemyCaptiveOff, alliedCaptiveOff};
+        auto unitsVec = std::vector<Unit>{actorOff, enemyCaptiveOff, alliedCaptiveOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         GameStateBuilder gsb(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/MoveCommandFactory_test.cpp

@@ -16,7 +16,7 @@ class MoveCommandFactoryTest : public ::testing::Test {
         auto actorOff = AddGenericUnit(1, 3, position);
         auto enemyOff = AddGenericUnit(0, 2, Coords(3, 2));
 
-        vector<Unit> vec{actorOff, enemyOff};
+        auto vec = vector<Unit>{actorOff, enemyOff};
         auto u = fbb.CreateVectorOfSortedStructs(&vec);
 
         fbb.Finish(u);

src/test/cpp/net/eagle0/shardok/library/command_factories/ReinforceCommandFactory_test.cpp

@@ -44,7 +44,7 @@ class ReinforceCommandFactoryTest : public ::testing::Test {
         auto defenderOffset = AddGenericUnit(1, 2, Coords(2, 5));
         auto anotherReserveOffset = AddGenericUnit(2, 3, Coords(-1, -1));
 
-        std::vector<Unit> unitsVec{
+        auto unitsVec = std::vector<Unit>{
                 attacker1Offset,
                 reserveAttackerOffset,
                 defenderOffset,

src/test/cpp/net/eagle0/shardok/library/command_factories/ScoutCommandFactory_test.cpp

@@ -29,7 +29,7 @@ class ScoutCommandFactoryTests : public ::testing::Test {
         fbb.ForceDefaults(true);
 
         auto rangerOff = AddGenericUnit(5, 0, position);
-        std::vector<Unit> unitsVec{rangerOff};
+        auto unitsVec = std::vector<Unit>{rangerOff};
         auto unitsOff = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         auto mapOff = AddBasicMap(fbb);

src/test/cpp/net/eagle0/shardok/library/command_factories/StartFireCommandFactory_test.cpp

@@ -34,7 +34,7 @@ class StartFireCommandFactoryTest : public ::testing::Test {
         auto friendlyOffset = AddGenericUnit(0, 1, Coords(5, 5));
         auto defenderOffset = AddGenericUnit(1, 2, Coords(2, 0));
 
-        vector<Unit> unitsVec{attackerOffset, friendlyOffset, defenderOffset};
+        auto unitsVec = vector<Unit>{attackerOffset, friendlyOffset, defenderOffset};
         auto unitsOffset = fbb.CreateVectorOfSortedStructs(&unitsVec);
 
         weather = WeatherFb();