mirror of
https://github.com/nolen777/eagle0.git
synced 2026-07-28 21:35:42 +00:00
6e7611d547
* Remove stale proto_converter deps from library/ BUILD files Library code should not depend on proto_converters - those belong at the service layer boundary. Removed 9 stale proto_converter deps that were no longer used by any Scala code. The only remaining proto_converter dep is shardok_battle_converter, which is actually used by ResolveBattleAction.scala (to be fixed in a follow-up PR). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Move ShardokBattle boundary conversion to ShardokInterfaceGrpcClient Previously, BattleResolution contained a proto ShardokBattle, requiring ResolveBattleAction in library/ to depend on ShardokBattleConverter. This violated the boundary principle where proto conversions should happen at the service layer, not in library code. This change: - Updates BattleResolution.battle to use Scala ShardokBattle - Moves the proto-to-Scala conversion into ShardokInterfaceGrpcClient - Removes ShardokBattleConverter dependency from library/ code - Updates tests to use the scalaBattle() helper for conversion This completely removes proto_converters dependencies from library/ (the last one was shardok_battle_converter). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add linter check for library/ proto_converters boundary Adds Rule 3 to check_build_deps.sh that verifies library/ code does not depend on proto_converters. Proto conversions should happen at service boundaries (ShardokInterfaceGrpcClient, EagleServiceImpl, etc.), not in library code. Also updates baseline from 167 to 75 proto deps reflecting recent cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>