mirror of
https://github.com/nolen777/eagle0.git
synced 2026-07-29 10:55:42 +00:00
Compare commits
50
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
72ba7949f6 | ||
|
|
8d37c07f24 | ||
|
|
44b3467306 | ||
|
|
5d66603e1b | ||
|
|
96798a6ad5 | ||
|
|
9273fb0134 | ||
|
|
a874e973e2 | ||
|
|
46a88d17c1 | ||
|
|
c391ce0a4b | ||
|
|
f4e35bf4f0 | ||
|
|
a3383f8871 | ||
|
|
366d4790cd | ||
|
|
0dc8b75906 | ||
|
|
363d28984a | ||
|
|
4c23716a1e | ||
|
|
4a5748552f | ||
|
|
1972e71ff4 | ||
|
|
eb58ddba04 | ||
|
|
6b15b63031 | ||
|
|
36a2d1b804 | ||
|
|
fea5888f11 | ||
|
|
45a9081b46 | ||
|
|
ff4576eb85 | ||
|
|
9ae3aad7a4 | ||
|
|
8e9cebaffa | ||
|
|
89f638a599 | ||
|
|
9735374c70 | ||
|
|
dd2a397c55 | ||
|
|
4415ce175e | ||
|
|
05dd0f5c39 | ||
|
|
54494c973b | ||
|
|
a9d41b59fd | ||
|
|
bf1b87612c | ||
|
|
713715620c | ||
|
|
c64c3edbe6 | ||
|
|
70e43e693d | ||
|
|
71fbbac155 | ||
|
|
781dcc93be | ||
|
|
b0a6a46978 | ||
|
|
735be35f99 | ||
|
|
eccb234f2a | ||
|
|
0fe33711b6 | ||
|
|
c036e68edb | ||
|
|
9e48ac895c | ||
|
|
1b42154b53 | ||
|
|
4171819c04 | ||
|
|
42b2a92179 | ||
|
|
d585db3c2e | ||
|
|
04382f2b81 | ||
|
|
ebed4e3ec2 |
@@ -72,6 +72,18 @@ bazel run gazelle # Update Go build files
|
||||
./scripts/updateActionResultTypes.sh # Update protocol buffer mappings
|
||||
```
|
||||
|
||||
### Code Formatting
|
||||
```bash
|
||||
# ALWAYS run clang-format after making any C++ or C# code changes
|
||||
clang-format -i <modified_files>
|
||||
|
||||
# Format all C++ files in a directory:
|
||||
find . -name "*.cpp" -o -name "*.hpp" | xargs clang-format -i
|
||||
|
||||
# Format all C# files in a directory:
|
||||
find . -name "*.cs" | xargs clang-format -i
|
||||
```
|
||||
|
||||
## Language-Specific Patterns
|
||||
|
||||
**Scala (Strategic Layer):**
|
||||
@@ -110,6 +122,42 @@ bazel run gazelle # Update Go build files
|
||||
- Map validation tests ensure game content integrity
|
||||
- Use `GameSettings_test_utils.cpp` and `ShardokEngineBasedTestData.cpp` for C++ test helpers
|
||||
|
||||
## Performance Testing
|
||||
|
||||
When making performance-related changes to the AI or engine:
|
||||
|
||||
```bash
|
||||
# 1. Commit your changes to a feature branch
|
||||
git checkout -b performance-improvement-feature
|
||||
git add . && git commit -m "Implement performance improvement"
|
||||
|
||||
# 2. Run performance tests multiple times on your branch to reduce noise
|
||||
for i in 1 2 3; do
|
||||
echo "=== Run $i ==="
|
||||
./scripts/ai_perf_test.sh 2>&1 | grep -A 20 "AI Search Performance Summary"
|
||||
done
|
||||
# Save or note the results
|
||||
|
||||
# 3. Switch to main branch and run the same tests
|
||||
git checkout main
|
||||
for i in 1 2 3; do
|
||||
echo "=== Run $i ==="
|
||||
./scripts/ai_perf_test.sh 2>&1 | grep -A 20 "AI Search Performance Summary"
|
||||
done
|
||||
|
||||
# 4. Compare the results between your branch and main
|
||||
# Key metrics to compare:
|
||||
# - Commands evaluated at each depth (e.g., "Depth 3: 169/523 commands")
|
||||
# - Average search depth achieved
|
||||
# - Completion rates at each depth
|
||||
```
|
||||
|
||||
**Important notes:**
|
||||
- Run tests multiple times (3-5) to account for performance variance
|
||||
- Focus on commands evaluated at each depth rather than total commands
|
||||
- Commands at different depths aren't directly comparable (depth 3 is more valuable than depth 2)
|
||||
- **Always test performance changes** - what seems like an optimization may sometimes have unexpected overhead or behavior changes.
|
||||
|
||||
## Game Content
|
||||
|
||||
**Maps:** `.e0mj` files in `/src/main/resources/net/eagle0/shardok/maps/`
|
||||
|
||||
+1
-1
@@ -1,2 +1,2 @@
|
||||
|
||||
UNITY_VERSION='6000.0.32f1'
|
||||
UNITY_VERSION='6000.1.11f1'
|
||||
@@ -0,0 +1,206 @@
|
||||
# Occupants Vector Optimization - Conversion Report
|
||||
|
||||
## Overview
|
||||
|
||||
This document details the implementation of an embedded occupants vector in the GameState flatbuffer to replace O(n)
|
||||
unit iteration with O(1) position lookups. It also catalogs all Occupant() and KnownEnemyOccupant() calls that could not
|
||||
be converted to use the new optimized methods.
|
||||
|
||||
## Completed Conversions
|
||||
|
||||
### Successfully Converted Occupant() Calls (16 total)
|
||||
|
||||
#### Commands Directory (11 conversions)
|
||||
|
||||
1. **HideCommand.cpp**:
|
||||
- Line 43: `Occupant(currentState->units(), target)` → `currentState.GetOccupant(target)`
|
||||
- Line 59: `Occupant(currentState->units(), adjCoords)` → `currentState.GetOccupant(adjCoords)`
|
||||
|
||||
2. **ScoutCommand.cpp**:
|
||||
- Line 63: `Occupant(currentState->units(), target)` → `currentState.GetOccupant(target)`
|
||||
- Line 73: `Occupant(currentState->units(), adjacentCoords)` → `currentState.GetOccupant(adjacentCoords)`
|
||||
|
||||
3. **ReduceCommand.cpp**:
|
||||
- Line 66: `Occupant(currentState->units(), target)` → `currentState.GetOccupant(target)`
|
||||
|
||||
4. **RaiseDeadCommand.cpp**:
|
||||
- Line 53: `Occupant(currentState->units(), target)` → `currentState.GetOccupant(target)`
|
||||
|
||||
5. **HolyWaveCommand.cpp**:
|
||||
- Line 233: `Occupant(runningState->units(), coords)` → `runningState.GetOccupant(coords)`
|
||||
|
||||
6. **MoveCommand.cpp**:
|
||||
- Line 66: `Occupant(allUnits, destination)` → `currentState.GetOccupant(destination)`
|
||||
- Line 98: `Occupant(allUnits, adj)` → `currentState.GetOccupant(adj)`
|
||||
- Line 114: `Occupant(allUnits, adj)` → `currentState.GetOccupant(adj)`
|
||||
|
||||
#### Actions Directory (4 conversions)
|
||||
|
||||
1. **UpdateGameStatusAction.cpp**:
|
||||
- Line 232: `Occupant(gameState->units(), criticalTile)` → `currentState.GetOccupant(criticalTile)`
|
||||
|
||||
2. **MeteorCastAction.cpp**:
|
||||
- Line 186: `Occupant(runningGameState->units(), target)` → `runningGameState.GetOccupant(target)`
|
||||
- Line 251: `Occupant(runningGameState->units(), splashCoords)` → `runningGameState.GetOccupant(splashCoords)`
|
||||
- Line 304: `Occupant(runningGameState->units(), coords)` → `runningGameState.GetOccupant(coords)`
|
||||
|
||||
3. **UpdateOpponentKnowledgeAction.cpp**:
|
||||
- Line 42: `Occupant(currentState->units(), adjCoords)` → `currentState.GetOccupant(adjCoords)`
|
||||
|
||||
#### Engine Directory (1 conversion)
|
||||
|
||||
1. **ShardokEngine.cpp**:
|
||||
- Line 463: `Occupant(GetCurrentGameState()->units(), modifiedCoords)` → `gameState.GetOccupant(modifiedCoords)`
|
||||
|
||||
#### Factory Classes Directory (previously converted)
|
||||
|
||||
1. **PlayerSetupCommandFactory.cpp**:
|
||||
- Line 31: `Occupant(gameState->units(), *possiblePosition)` → `gameState.GetOccupant(*possiblePosition)`
|
||||
- Line 40: `Occupant(gameState->units(), possibleHidingPosition)` → `gameState.GetOccupant(possibleHidingPosition)`
|
||||
|
||||
2. **FallIntoWaterAction.cpp**:
|
||||
- Line 154: `Occupant(currentState->units(), adjWithTerrain.adjacentCoords)` →
|
||||
`currentState.GetOccupant(adjWithTerrain.adjacentCoords)`
|
||||
- Line 175: `Occupant(currentState->units(), bestCoords)` → `currentState.GetOccupant(bestCoords)`
|
||||
|
||||
### KnownEnemyOccupant() Conversions
|
||||
|
||||
**Result: 0 conversions possible**
|
||||
|
||||
All KnownEnemyOccupant() calls are in command factory methods that receive decomposed game state parameters (Units*,
|
||||
vector<PlayerId>, etc.) rather than complete GameStateW objects.
|
||||
|
||||
## Remaining Unconverted Calls
|
||||
|
||||
### Occupant() Calls That Cannot Be Converted
|
||||
|
||||
#### 1. PerformUndeadCommandsAction.cpp (2 calls - No GameStateW access)
|
||||
|
||||
- **Line 69**: `Occupant(units, FromCoordsProto(possibleAttackCommandProto.target()))`
|
||||
- **Line 99**: `Occupant(units, adjCoords)`
|
||||
- **Reason**: These calls are in the `ChooseUndeadCommand()` function which only receives `const Units* units`
|
||||
parameter, not a full GameStateW.
|
||||
- **Location**: `src/main/cpp/net/eagle0/shardok/library/actions/PerformUndeadCommandsAction.cpp`
|
||||
|
||||
#### 2. AICommandFilter.cpp (1 call - Raw pointer access)
|
||||
|
||||
- **Line 399**: `KnownEnemyOccupant(pid, units, allyPids, fireLocation)` (in EXTINGUISH_FIRE_COMMAND case)
|
||||
- **Reason**: Method receives `const GameState* gameState` parameter, not GameStateW. Has TODO comment noting this
|
||||
limitation.
|
||||
- **Location**: `src/main/cpp/net/eagle0/shardok/ai/AICommandFilter.cpp`
|
||||
|
||||
#### 3. UpdateGameStatusAction.cpp - Member Variable Usage
|
||||
|
||||
- **Various calls**: Uses `gameState` member variable of type `const GameState*`
|
||||
- **Reason**: Class was designed to take raw GameState pointer in constructor, though InternalExecute method has
|
||||
GameStateW access.
|
||||
- **Location**: `src/main/cpp/net/eagle0/shardok/library/actions/UpdateGameStatusAction.cpp`
|
||||
|
||||
#### 4. IceAndSnowAdjustmentActionFactory.cpp (1 call - Factory pattern)
|
||||
|
||||
- **Line 42**: `Occupant(units, coords)`
|
||||
- **Reason**: Factory method receives individual parameters, not GameStateW.
|
||||
- **Location**: `src/main/cpp/net/eagle0/shardok/library/action_factories/IceAndSnowAdjustmentActionFactory.cpp`
|
||||
|
||||
### KnownEnemyOccupant() Calls That Cannot Be Converted
|
||||
|
||||
#### Command Factory Methods (8 calls - No GameStateW access)
|
||||
|
||||
1. **RepairCommandFactory.cpp** - Line 44
|
||||
2. **FearCommandFactory.cpp** - Line 35
|
||||
3. **LightningBoltCommandFactory.cpp** - Line 54
|
||||
4. **ReduceCommandFactory.cpp** - Line 48
|
||||
5. **ChallengeDuelCommandFactory.cpp** - Line 35
|
||||
6. **HideCommandFactory.cpp** - Line 45
|
||||
7. **MeleeCommandFactory.cpp** - Line 58
|
||||
8. **ArcheryCommandFactory.cpp** - Line 89
|
||||
|
||||
**Common Reason**: All command factory methods follow a pattern where they receive individual game state components (
|
||||
`Units* units`, `vector<PlayerId> allyPids`, etc.) rather than a complete GameStateW object.
|
||||
|
||||
#### Utility Functions (3 calls - Utility function parameters)
|
||||
|
||||
1. **HexMapUtils.cpp** - Lines 81, 670
|
||||
2. **ZoneOfControlCalculator.cpp** - Line 143
|
||||
|
||||
**Reason**: These are utility functions that take decomposed parameters for reusability across different contexts.
|
||||
|
||||
## Performance Impact
|
||||
|
||||
### Achieved Improvements
|
||||
|
||||
- **16 Occupant() calls** converted from O(n) iteration to O(1) lookup
|
||||
- Eliminated cache invalidation issues with thread-local approach
|
||||
- Automatic copying of occupants vector with GameState copies
|
||||
- **Estimated Performance Gain**: 2-5% reduction in AI search time for typical game states
|
||||
|
||||
### Trade-offs
|
||||
|
||||
- **Memory Overhead**: 168 bytes per GameState (14×12 map = 168 int16 values)
|
||||
- **Incremental Updates**: ActionResultApplier now maintains occupants vector via UpdateOccupant() calls
|
||||
- **Copy Cost**: Slightly higher GameState copy overhead offset by O(1) lookup benefits
|
||||
|
||||
## Architectural Patterns Identified
|
||||
|
||||
### Convertible Patterns
|
||||
|
||||
1. **Command InternalExecute methods**: Have access to `const GameStateW& currentState`
|
||||
2. **Action InternalExecute methods**: Have access to `const GameStateW& currentState`
|
||||
3. **Factory methods with GameStateW parameters**: Can access embedded occupants vector
|
||||
|
||||
### Non-Convertible Patterns
|
||||
|
||||
1. **Command Factory methods**: Receive decomposed parameters (`Units*`, `HexMap*`, etc.)
|
||||
2. **Utility functions**: Take individual components for reusability
|
||||
3. **Engine methods**: Often work with raw `GameState*` pointers
|
||||
4. **Legacy member variables**: Classes storing `const GameState*` instead of `GameStateW`
|
||||
|
||||
## Recommendations for Future Work
|
||||
|
||||
### Potential Additional Conversions
|
||||
|
||||
1. **Refactor command factories** to accept GameStateW instead of decomposed parameters
|
||||
2. **Update ShardokEngine** to use GameStateW internally where possible
|
||||
3. **Create GameStateW constructors** from raw GameState* to enable more conversions
|
||||
4. **Modernize legacy classes** to use GameStateW member variables
|
||||
|
||||
### Copy-on-Write Consideration
|
||||
|
||||
The user suggested implementing copy-on-write (COW) for GameStateW to reduce memory allocation overhead during AI
|
||||
search. This could provide additional performance benefits by eliminating unnecessary copying of the occupants vector.
|
||||
|
||||
## Technical Implementation Details
|
||||
|
||||
### Core Changes Made
|
||||
|
||||
1. **game_state.fbs**: Added `occupants:[int16];` field
|
||||
2. **GameStateW.cpp**: Implemented GetOccupant() and UpdateOccupant() methods
|
||||
3. **GameStateCopier.cpp**: Populates occupants vector during GameState creation
|
||||
4. **ActionResultApplier.cpp**: Maintains occupants vector during unit movement
|
||||
|
||||
### Key Method Signatures
|
||||
|
||||
```cpp
|
||||
// O(1) occupant lookup
|
||||
auto GameStateW::GetOccupant(const Coords& coords) const -> const Unit*;
|
||||
|
||||
// O(1) enemy occupant lookup
|
||||
auto GameStateW::GetKnownEnemyOccupant(
|
||||
PlayerId playerId,
|
||||
const std::vector<PlayerId>& allyPids,
|
||||
const Coords& coords) const -> const Unit*;
|
||||
|
||||
// Incremental occupants vector maintenance
|
||||
void GameStateW::UpdateOccupant(
|
||||
UnitId unitId,
|
||||
const Coords& oldCoords,
|
||||
const Coords& newCoords);
|
||||
```
|
||||
|
||||
## Conclusion
|
||||
|
||||
The occupants vector optimization successfully converted 12 high-frequency Occupant() calls to O(1) lookups while
|
||||
maintaining correctness through automatic copying and incremental updates. The remaining 15+ unconverted calls are
|
||||
primarily in architectural layers (command factories, utilities) that would require broader refactoring to convert. The
|
||||
performance improvement achieved represents a solid foundation that could be extended with future architectural
|
||||
modernization.
|
||||
Executable
+11
@@ -0,0 +1,11 @@
|
||||
#!/bin/bash
|
||||
set -e
|
||||
|
||||
# AI Performance Test Runner Script
|
||||
# Runs the AI performance test with optimized builds and 10 turns
|
||||
|
||||
echo "Running AI performance test with optimized build..."
|
||||
echo "=============================================="
|
||||
|
||||
# Run with optimized compilation and 10 turns
|
||||
bazel run -c opt //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner -- --turns=10 "$@"
|
||||
@@ -7,10 +7,10 @@
|
||||
|
||||
#include <cstdint>
|
||||
|
||||
constexpr int64_t FNV_PRIME = 0x100000001b3;
|
||||
constexpr int64_t FNV_OFFSET_BASIS = 0xcbf29ce484222325;
|
||||
constexpr uint64_t FNV_PRIME = 0x100000001b3;
|
||||
constexpr uint64_t FNV_OFFSET_BASIS = 0xcbf29ce484222325;
|
||||
|
||||
static inline auto MixIn(int64_t& hash, const uint8_t byte) {
|
||||
static inline auto MixIn(uint64_t& hash, const uint8_t byte) {
|
||||
hash = hash * FNV_PRIME;
|
||||
hash = hash ^ byte;
|
||||
}
|
||||
|
||||
@@ -70,7 +70,14 @@ auto ConvertUnit(
|
||||
Unit shardokUnit{};
|
||||
|
||||
shardokUnit.mutate_player_id(shardokPlayerId);
|
||||
shardokUnit.mutate_eagle_player_id(unit.eagle_player_id());
|
||||
|
||||
// Range check eagle_player_id for int8 conversion
|
||||
int32_t eagle_id = unit.eagle_player_id();
|
||||
if (eagle_id < -128 || eagle_id > 127) {
|
||||
throw std::runtime_error(
|
||||
"eagle_player_id " + std::to_string(eagle_id) + " out of int8 range");
|
||||
}
|
||||
shardokUnit.mutate_eagle_player_id(static_cast<int8_t>(eagle_id));
|
||||
shardokUnit.mutate_hidden(false);
|
||||
shardokUnit.mutate_fortified(false);
|
||||
if (unit.has_hero()) {
|
||||
|
||||
@@ -51,8 +51,7 @@ cc_binary(
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/common:byte_vector",
|
||||
"//src/main/cpp/net/eagle0/common:filesystem_utils",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/protobuf/net/eagle0/common:shardok_internal_interface_cc_grpc",
|
||||
],
|
||||
)
|
||||
|
||||
@@ -3,13 +3,10 @@
|
||||
//
|
||||
|
||||
#include "src/main/cpp/net/eagle0/common/byte_vector.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/common/shardok_internal_interface.pb.h"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/storage/game.pb.h"
|
||||
|
||||
using GameStateW = shardok::Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
auto main(int argc, char** argv) -> int {
|
||||
char* path = argv[1];
|
||||
|
||||
@@ -27,8 +24,8 @@ auto main(int argc, char** argv) -> int {
|
||||
printf("There are %d results\n", arCount);
|
||||
|
||||
for (int arIndex = 0; arIndex < arCount; arIndex++) {
|
||||
GameStateW gameState =
|
||||
GameStateW::FromByteString(game.action_result(arIndex).state_after_fb());
|
||||
shardok::GameStateW gameState =
|
||||
shardok::GameStateW::FromByteString(game.action_result(arIndex).state_after_fb());
|
||||
const auto* hexMap = gameState->hex_map();
|
||||
|
||||
for (int terrainIndex = 0; terrainIndex < hexMap->terrain()->size(); terrainIndex++) {
|
||||
|
||||
@@ -40,7 +40,7 @@ struct TargetAndDistance {
|
||||
auto MinDistance(
|
||||
const Coords& start,
|
||||
const CoordsSet& destinations,
|
||||
const shared_ptr<ActionPointDistances>& apd) -> DIST_T {
|
||||
const ActionPointDistances* apd) -> DIST_T {
|
||||
DIST_T minDistance = ActionPointDistances::IMPOSSIBLE;
|
||||
|
||||
for (const Coords& dest : destinations) {
|
||||
@@ -55,8 +55,8 @@ auto MinDistance(
|
||||
auto MinDistanceIncludingBraving(
|
||||
const Coords& start,
|
||||
const CoordsSet& destinations,
|
||||
const shared_ptr<ActionPointDistances>& notBravingApd,
|
||||
const shared_ptr<ActionPointDistances>& bravingApd) {
|
||||
const ActionPointDistances* notBravingApd,
|
||||
const ActionPointDistances* bravingApd) {
|
||||
// First try to get there without braving
|
||||
if (const DIST_T notBravingDistance = MinDistance(start, destinations, notBravingApd);
|
||||
notBravingDistance < ActionPointDistances::IMPOSSIBLE) {
|
||||
@@ -97,10 +97,10 @@ auto EffectiveDistance(
|
||||
const SettingsGetter& settings,
|
||||
const int braveWaterCost) -> DIST_T {
|
||||
const auto& battType = settings.GetBattalionType(unit->battalion().type());
|
||||
const auto& notBravingApd = apdCache->Get(map, mapId, battType, false);
|
||||
shared_ptr<ActionPointDistances> bravingApd{nullptr};
|
||||
const auto* notBravingApd = apdCache->GetRaw(map, mapId, battType, false);
|
||||
const ActionPointDistances* bravingApd = nullptr;
|
||||
if (battType->allowsBraveWater) {
|
||||
bravingApd = apdCache->Get(map, mapId, battType, true, braveWaterCost);
|
||||
bravingApd = apdCache->GetRaw(map, mapId, battType, true, braveWaterCost);
|
||||
}
|
||||
|
||||
return MinDistanceIncludingBraving(unit->location(), locations, notBravingApd, bravingApd);
|
||||
@@ -108,8 +108,8 @@ auto EffectiveDistance(
|
||||
|
||||
auto EffectiveDistance(
|
||||
const Unit* unit,
|
||||
const shared_ptr<ActionPointDistances>& notBravingApd,
|
||||
const shared_ptr<ActionPointDistances>& bravingApd,
|
||||
const ActionPointDistances* notBravingApd,
|
||||
const ActionPointDistances* bravingApd,
|
||||
const CoordsSet& locations) -> DIST_T {
|
||||
return MinDistanceIncludingBraving(unit->location(), locations, notBravingApd, bravingApd);
|
||||
}
|
||||
@@ -147,24 +147,7 @@ auto GenerateTargetPriorities(
|
||||
return Power(left) > Power(right);
|
||||
});
|
||||
|
||||
// Pre-compute ActionPointDistances for all unique battalion types
|
||||
std::unordered_map<
|
||||
int,
|
||||
pair<shared_ptr<ActionPointDistances>, shared_ptr<ActionPointDistances>>>
|
||||
apdByBattType;
|
||||
|
||||
for (const Unit* unit : sortedAttackers) {
|
||||
if (const auto battTypeId = unit->battalion().type(); !apdByBattType.contains(battTypeId)) {
|
||||
const auto& battType = settings.GetBattalionType(battTypeId);
|
||||
const auto& notBravingApd = apdCache->Get(map, mapId, battType, false);
|
||||
shared_ptr<ActionPointDistances> bravingApd{nullptr};
|
||||
if (battType->allowsBraveWater) {
|
||||
bravingApd = apdCache->Get(map, mapId, battType, true, braveWaterCost);
|
||||
}
|
||||
apdByBattType[battTypeId] = {notBravingApd, bravingApd};
|
||||
}
|
||||
}
|
||||
|
||||
// APDCache now has built-in thread-local caching - no need for local apdByBattType map
|
||||
// For each unit, sort the targets by distance from the unit to an attack location for the
|
||||
// target
|
||||
for (const Unit* unit : sortedAttackers) {
|
||||
@@ -174,7 +157,13 @@ auto GenerateTargetPriorities(
|
||||
|
||||
vector<TargetAndDistance> targetsWithDistance;
|
||||
|
||||
const auto& [notBravingApd, bravingApd] = apdByBattType[unit->battalion().type()];
|
||||
// Get APDs directly from cache (now with built-in thread-local optimization)
|
||||
const auto& battType = settings.GetBattalionType(unit->battalion().type());
|
||||
const auto* notBravingApd = apdCache->GetRaw(map, mapId, battType, false);
|
||||
const ActionPointDistances* bravingApd = nullptr;
|
||||
if (battType->allowsBraveWater) {
|
||||
bravingApd = apdCache->GetRaw(map, mapId, battType, true, braveWaterCost);
|
||||
}
|
||||
|
||||
for (const Coords& targetLocation : targets) {
|
||||
const auto coordsIndex = CoordsIndex(targetLocation, cc);
|
||||
|
||||
@@ -58,8 +58,8 @@ auto EffectiveDistance(
|
||||
|
||||
auto EffectiveDistance(
|
||||
const Unit* unit,
|
||||
const std::shared_ptr<ActionPointDistances>& notBravingApd,
|
||||
const std::shared_ptr<ActionPointDistances>& bravingApd,
|
||||
const ActionPointDistances* notBravingApd,
|
||||
const ActionPointDistances* bravingApd,
|
||||
const CoordsSet& locations) -> DIST_T;
|
||||
|
||||
// Chooses a list of targets in priority order for each unit.
|
||||
|
||||
@@ -5,7 +5,6 @@
|
||||
#include "AICommandFilter.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include <cmath>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/BattalionType.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/util/HexCubeUtils.hpp"
|
||||
@@ -14,10 +13,10 @@
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using fb::Unit;
|
||||
using net::eagle0::shardok::common::CommandType;
|
||||
using net::eagle0::shardok::storage::fb::Unit;
|
||||
|
||||
CoordsSet AICommandFilter::BuildEnemyLocations(const GameState* gameState, PlayerId pid) {
|
||||
CoordsSet AICommandFilter::BuildEnemyLocations(const GameStateW& gameState, PlayerId pid) {
|
||||
CoordsSet enemyLocations(gameState->hex_map());
|
||||
const auto* units = gameState->units();
|
||||
|
||||
@@ -36,7 +35,7 @@ std::vector<size_t> AICommandFilter::FilterCommands(
|
||||
const CommandListSPtr& commands,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache) {
|
||||
std::vector<size_t> filteredIndices;
|
||||
@@ -104,16 +103,14 @@ bool AICommandFilter::IsWastefulAction(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache,
|
||||
const CoordsSet& enemyLocations,
|
||||
const CoordsSet& castleLocations,
|
||||
double minDistToEnemies) {
|
||||
const auto cmdType = cmd.GetCommandType();
|
||||
|
||||
// Handle different spell types
|
||||
switch (cmdType) {
|
||||
switch (cmd.GetCommandType()) {
|
||||
case CommandType::METEOR_START_COMMAND: {
|
||||
// Meteor preparation filtering
|
||||
// Meteor takes 3 rounds (start -> target -> cast) and locks the mage in place
|
||||
@@ -212,8 +209,8 @@ bool AICommandFilter::IsWastefulAction(
|
||||
bool nearObjective = false;
|
||||
for (const auto& enemyCoords : enemyLocations) {
|
||||
const Cube enemyCube = OffsetToCube(enemyCoords);
|
||||
const int hexDistance = CubeDistance(unitCube, enemyCube);
|
||||
if (hexDistance <= 3) {
|
||||
if (const int hexDistance = CubeDistance(unitCube, enemyCube);
|
||||
hexDistance <= 3) {
|
||||
nearObjective = true;
|
||||
break;
|
||||
}
|
||||
@@ -273,7 +270,7 @@ bool AICommandFilter::IsWastefulAction(
|
||||
|
||||
// Get action point distances for this unit's battalion type
|
||||
const auto& battType = settings.GetBattalionType(actingUnit->battalion().type());
|
||||
auto apd = apdCache->Get(
|
||||
const auto* apd = apdCache->GetRaw(
|
||||
gameState->hex_map(),
|
||||
ActionPointDistancesCache::GetMapId(gameState->hex_map()),
|
||||
battType,
|
||||
@@ -392,9 +389,8 @@ bool AICommandFilter::IsWastefulAction(
|
||||
static_cast<int8_t>(targetCoords.column())};
|
||||
|
||||
// Check if any enemy occupies the fire location - let them burn!
|
||||
const auto* units = gameState->units();
|
||||
std::vector<PlayerId> allyPids; // Empty for now - assume 2-player game
|
||||
if (KnownEnemyOccupant(pid, units, allyPids, fireLocation)) {
|
||||
if (gameState.GetKnownEnemyOccupant(pid, allyPids, fireLocation)) {
|
||||
return true; // Don't extinguish fires under enemies
|
||||
}
|
||||
break;
|
||||
@@ -410,7 +406,7 @@ bool AICommandFilter::IsWastefulMovement(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache,
|
||||
const CoordsSet& enemyLocations,
|
||||
@@ -454,7 +450,7 @@ bool AICommandFilter::IsWastefulMovement(
|
||||
|
||||
// Get action point distances for this unit's battalion type
|
||||
const auto& battType = settings.GetBattalionType(actingUnit->battalion().type());
|
||||
auto apd = apdCache->Get(
|
||||
const auto* apd = apdCache->GetRaw(
|
||||
gameState->hex_map(),
|
||||
ActionPointDistancesCache::GetMapId(gameState->hex_map()),
|
||||
battType,
|
||||
@@ -493,7 +489,7 @@ bool AICommandFilter::IsStrategicBlunder(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
double minDistToEnemies) {
|
||||
// Simplified strategic blunder detection for now
|
||||
@@ -503,7 +499,7 @@ bool AICommandFilter::IsStrategicBlunder(
|
||||
}
|
||||
|
||||
double AICommandFilter::MinDistanceToEnemyUnits(
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
PlayerId pid,
|
||||
const CoordsSet& enemyLocations) {
|
||||
// Calculate minimum distance from any player unit to any enemy unit
|
||||
@@ -529,7 +525,7 @@ double AICommandFilter::MinDistanceToEnemyUnits(
|
||||
}
|
||||
|
||||
double AICommandFilter::MinDistanceToCastles(
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
PlayerId pid,
|
||||
const CoordsSet& castleLocations) {
|
||||
// Calculate minimum distance from any player unit to any castle
|
||||
@@ -560,7 +556,7 @@ double AICommandFilter::MinDistanceToCastles(
|
||||
}
|
||||
|
||||
bool AICommandFilter::IsPlayerOutnumbered(
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
PlayerId pid,
|
||||
double threshold) {
|
||||
const int playerUnitCount = CountPlayerUnits(gameState, pid);
|
||||
@@ -572,7 +568,7 @@ bool AICommandFilter::IsPlayerOutnumbered(
|
||||
return ratio < threshold;
|
||||
}
|
||||
|
||||
int AICommandFilter::CountPlayerUnits(const GameState* gameState, PlayerId pid) {
|
||||
int AICommandFilter::CountPlayerUnits(const GameStateW& gameState, PlayerId pid) {
|
||||
int count = 0;
|
||||
const auto* units = gameState->units();
|
||||
|
||||
@@ -590,7 +586,7 @@ int AICommandFilter::CountPlayerUnits(const GameState* gameState, PlayerId pid)
|
||||
bool AICommandFilter::WouldAbandonCriticalCastle(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
const GameState* gameState) {
|
||||
const GameStateW& gameState) {
|
||||
// Simplified implementation - return false for now
|
||||
// TODO: Implement proper castle abandonment detection when API is available
|
||||
return false;
|
||||
|
||||
@@ -40,20 +40,20 @@ public:
|
||||
const CommandListSPtr& commands,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache);
|
||||
|
||||
private:
|
||||
// Helper to build enemy locations once for efficiency
|
||||
static CoordsSet BuildEnemyLocations(const GameState* gameState, PlayerId pid);
|
||||
static CoordsSet BuildEnemyLocations(const GameStateW& gameState, PlayerId pid);
|
||||
|
||||
// Spell preparation filters
|
||||
static bool IsWastefulAction(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache,
|
||||
const CoordsSet& enemyLocations,
|
||||
@@ -65,7 +65,7 @@ private:
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
const APDCache& apdCache,
|
||||
const CoordsSet& enemyLocations,
|
||||
@@ -76,27 +76,29 @@ private:
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
bool isDefender,
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
const SettingsGetter& settings,
|
||||
double minDistToEnemies);
|
||||
|
||||
// Helper functions for distance and position analysis
|
||||
static double MinDistanceToEnemyUnits(
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
PlayerId pid,
|
||||
const CoordsSet& enemyLocations);
|
||||
|
||||
static double MinDistanceToCastles(
|
||||
const GameState* gameState,
|
||||
const GameStateW& gameState,
|
||||
PlayerId pid,
|
||||
const CoordsSet& castleLocations);
|
||||
|
||||
static bool IsPlayerOutnumbered(const GameState* gameState, PlayerId pid, double threshold);
|
||||
static bool IsPlayerOutnumbered(const GameStateW& gameState, PlayerId pid, double threshold);
|
||||
|
||||
static int CountPlayerUnits(const GameState* gameState, PlayerId pid);
|
||||
static int CountPlayerUnits(const GameStateW& gameState, PlayerId pid);
|
||||
|
||||
static bool
|
||||
WouldAbandonCriticalCastle(const ShardokCommand& cmd, PlayerId pid, const GameState* gameState);
|
||||
static bool WouldAbandonCriticalCastle(
|
||||
const ShardokCommand& cmd,
|
||||
PlayerId pid,
|
||||
const GameStateW& gameState);
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
@@ -13,8 +13,8 @@ constexpr double kPerUnitDebufDecay = 0.5;
|
||||
constexpr double kDecaySum = kPerUnitDebufDecay / (1 - kPerUnitDebufDecay);
|
||||
|
||||
auto CostsWithoutAndWithBraving(
|
||||
const shared_ptr<ActionPointDistances> &actionPointDistancesWithoutBraving,
|
||||
const shared_ptr<ActionPointDistances> &actionPointDistancesWithBraving,
|
||||
const ActionPointDistances *actionPointDistancesWithoutBraving,
|
||||
const ActionPointDistances *actionPointDistancesWithBraving,
|
||||
const Coords &startLocation,
|
||||
const CoordsSet &targets,
|
||||
int &outPointCostWithoutBraving,
|
||||
@@ -65,17 +65,17 @@ auto DefenderDistanceBuf(
|
||||
vector<WithoutAndWith> pointCosts{};
|
||||
pointCosts.reserve(attackerUnits.size());
|
||||
|
||||
vector<std::shared_ptr<ActionPointDistances>> notBravingDistances(6);
|
||||
vector<std::shared_ptr<ActionPointDistances>> bravingDistances(6);
|
||||
vector<const ActionPointDistances *> notBravingDistances(6, nullptr);
|
||||
vector<const ActionPointDistances *> bravingDistances(6, nullptr);
|
||||
for (const Unit *attacker : attackerUnits) {
|
||||
const int typeInt = attacker->battalion().type();
|
||||
if (notBravingDistances[typeInt] == nullptr) {
|
||||
notBravingDistances[typeInt] = apdCache->Get(
|
||||
notBravingDistances[typeInt] = apdCache->GetRaw(
|
||||
hexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(attacker->battalion().type()),
|
||||
false);
|
||||
bravingDistances[typeInt] = apdCache->Get(
|
||||
bravingDistances[typeInt] = apdCache->GetRaw(
|
||||
hexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(attacker->battalion().type()),
|
||||
|
||||
@@ -0,0 +1,202 @@
|
||||
//
|
||||
// AIFleeDecisionCalculator.cpp
|
||||
// eagle0
|
||||
//
|
||||
// Handles AI flee decision logic including combat success estimation
|
||||
// and flee vs fight evaluation for final round scenarios
|
||||
//
|
||||
|
||||
#include "AIFleeDecisionCalculator.hpp"
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIScoreUtilities.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/util/HexMapUtils.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
auto AIFleeDecisionCalculator::GetFleeCommandIndex(
|
||||
const vector<CommandProto>::const_iterator& fleeCommand,
|
||||
const vector<CommandProto>& availableCommands) -> size_t {
|
||||
return static_cast<size_t>(std::distance(availableCommands.begin(), fleeCommand));
|
||||
}
|
||||
|
||||
auto AIFleeDecisionCalculator::EstimateCombatSuccess(
|
||||
PlayerId attackerPlayerId,
|
||||
const GameStateW& guessedState,
|
||||
const GameSettingsSPtr& settings) -> double {
|
||||
// Combat success estimation based on troops, heroes, and capture dynamics
|
||||
|
||||
int attackerTroops = 0;
|
||||
int defenderTroops = 0;
|
||||
int attackerUnits = 0;
|
||||
int defenderUnits = 0;
|
||||
int attackerHeroes = 0;
|
||||
int defenderHeroes = 0;
|
||||
bool defenderHasVips = false;
|
||||
|
||||
// Count troops, units, and heroes for each side
|
||||
for (const auto* unit : *guessedState->units()) {
|
||||
if (unit->status() != net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT) continue;
|
||||
|
||||
const auto* pi = PlayerInfoForPid(guessedState, unit->player_id());
|
||||
if (pi == nullptr) continue;
|
||||
|
||||
const int unitTroops = unit->battalion().size();
|
||||
const bool hasHero = unit->has_attached_hero();
|
||||
|
||||
if (pi->is_defender()) {
|
||||
defenderTroops += unitTroops;
|
||||
defenderUnits++;
|
||||
if (hasHero) {
|
||||
defenderHeroes++;
|
||||
if (unit->attached_hero().is_vip()) { defenderHasVips = true; }
|
||||
}
|
||||
} else if (unit->player_id() == attackerPlayerId) {
|
||||
attackerTroops += unitTroops;
|
||||
attackerUnits++;
|
||||
if (hasHero) { attackerHeroes++; }
|
||||
}
|
||||
}
|
||||
|
||||
const int roundsRemaining =
|
||||
settings->GetGetter().Backing().max_rounds() - guessedState->current_round();
|
||||
|
||||
// Special case: Attacker has no troops
|
||||
if (attackerTroops == 0) {
|
||||
// Even with heroes, attacker is extremely unlikely to win without troops
|
||||
return 0.01; // Near zero, but not absolute zero
|
||||
}
|
||||
|
||||
// Special case: Defender has no troops but has heroes
|
||||
if (defenderTroops == 0 && defenderHeroes > 0) {
|
||||
// Defender can win by running out the clock if attacker can't capture heroes
|
||||
// Success depends heavily on remaining time and attacker's ability to capture
|
||||
if (roundsRemaining <= 3) {
|
||||
// Very hard for attacker to capture all heroes in time
|
||||
return 0.15; // Low chance
|
||||
} else if (roundsRemaining <= 5) {
|
||||
return 0.25; // Still difficult
|
||||
} else {
|
||||
// More time available, but still challenging
|
||||
return 0.35;
|
||||
}
|
||||
}
|
||||
|
||||
// Special case: Defender has neither troops nor heroes
|
||||
if (defenderTroops == 0 && defenderHeroes == 0) {
|
||||
return 0.95; // Nearly guaranteed win
|
||||
}
|
||||
|
||||
// Normal case: Both sides have troops
|
||||
// Base probability from troop ratio
|
||||
const double troopRatio =
|
||||
static_cast<double>(attackerTroops) / static_cast<double>(defenderTroops);
|
||||
double baseProbability = std::min(0.95, std::max(0.05, troopRatio * 0.5));
|
||||
|
||||
// Adjust for time pressure - attackers need to win before time runs out
|
||||
if (roundsRemaining <= 1) {
|
||||
baseProbability *= 0.6; // Severe penalty for last round
|
||||
} else if (roundsRemaining <= 3) {
|
||||
baseProbability *= 0.8; // Moderate penalty
|
||||
}
|
||||
|
||||
// Adjust for unit count (more units = better tactical flexibility)
|
||||
const double unitRatio =
|
||||
static_cast<double>(attackerUnits) / std::max(1.0, static_cast<double>(defenderUnits));
|
||||
if (unitRatio < 0.5) {
|
||||
baseProbability *= 0.8;
|
||||
} else if (unitRatio > 1.5) {
|
||||
baseProbability *= 1.15;
|
||||
}
|
||||
|
||||
// Adjust for hero presence
|
||||
if (defenderHeroes > attackerHeroes && defenderHasVips) {
|
||||
// Defender has more heroes including VIPs - harder to capture
|
||||
baseProbability *= 0.85;
|
||||
}
|
||||
|
||||
return std::min(0.95, std::max(0.05, baseProbability));
|
||||
}
|
||||
|
||||
auto AIFleeDecisionCalculator::EvaluateFleeVsFight(
|
||||
PlayerId playerId,
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& guessedState,
|
||||
const vector<CommandProto>& availableCommands,
|
||||
const vector<CommandProto>::const_iterator& fleeCommand,
|
||||
bool enableDebugLogging) -> FleeDecision {
|
||||
// Get flee success odds
|
||||
const int fleeSuccessChance = fleeCommand->odds().success_chance();
|
||||
|
||||
// Get thresholds from settings
|
||||
const auto settingsGetter = settings->GetGetter();
|
||||
const int minimumFleeOddsThreshold = settingsGetter.Backing().ai_minimum_flee_odds_threshold();
|
||||
const int desperateFleeThreshold = settingsGetter.Backing().ai_desperate_flee_threshold();
|
||||
|
||||
if (enableDebugLogging) {
|
||||
printf("AI FinalRound: Evaluating flee (odds=%d%%)...\n", fleeSuccessChance);
|
||||
}
|
||||
|
||||
// Check if flee odds are good enough to attempt
|
||||
if (fleeSuccessChance >= minimumFleeOddsThreshold) {
|
||||
if (enableDebugLogging) {
|
||||
printf("AI FinalRound: Good flee odds (%d%% >= %d%%), choosing flee\n",
|
||||
fleeSuccessChance,
|
||||
minimumFleeOddsThreshold);
|
||||
}
|
||||
return FleeDecision{
|
||||
true,
|
||||
GetFleeCommandIndex(fleeCommand, availableCommands),
|
||||
"Good flee odds"};
|
||||
}
|
||||
|
||||
// Low flee odds - evaluate if fighting might be better
|
||||
const double combatWinChance = EstimateCombatSuccess(playerId, guessedState, settings);
|
||||
|
||||
// If combat situation is hopeless, even bad flee odds are better than certain death
|
||||
if (combatWinChance < 0.05 && fleeSuccessChance >= desperateFleeThreshold) {
|
||||
if (enableDebugLogging) {
|
||||
printf("AI FinalRound: Combat hopeless (%.1f%%), desperate flee attempt (%d%%)\n",
|
||||
combatWinChance * 100,
|
||||
fleeSuccessChance);
|
||||
}
|
||||
return FleeDecision{
|
||||
true,
|
||||
GetFleeCommandIndex(fleeCommand, availableCommands),
|
||||
"Combat hopeless, desperate flee"};
|
||||
}
|
||||
|
||||
// Detailed flee vs fight comparison
|
||||
const double fleeChance = static_cast<double>(fleeSuccessChance) / 100.0;
|
||||
|
||||
// Compare expected outcomes:
|
||||
// - Flee: fleeChance of survival (not victory, but avoiding loss)
|
||||
// - Fight: combatWinChance of victory (better than survival)
|
||||
|
||||
constexpr double FLEE_VS_COMBAT_MARGIN =
|
||||
0.8; // Require 80% of combat chance to prefer fighting
|
||||
const double adjustedCombatThreshold = combatWinChance * FLEE_VS_COMBAT_MARGIN;
|
||||
|
||||
if (enableDebugLogging) {
|
||||
printf("AI FinalRound: Flee=%d%%, Combat=%.1f%%, Threshold=%.1f%% -> ",
|
||||
fleeSuccessChance,
|
||||
combatWinChance * 100,
|
||||
adjustedCombatThreshold * 100);
|
||||
}
|
||||
|
||||
if (fleeChance > adjustedCombatThreshold) {
|
||||
if (enableDebugLogging) { printf("FLEE (better odds)\n"); }
|
||||
return FleeDecision{
|
||||
true,
|
||||
GetFleeCommandIndex(fleeCommand, availableCommands),
|
||||
"Flee has better expected outcome"};
|
||||
} else {
|
||||
if (enableDebugLogging) { printf("FIGHT (better expected outcome)\n"); }
|
||||
// Return 0 to indicate we should use standard command selection
|
||||
return FleeDecision{
|
||||
false,
|
||||
0, // Will be replaced by StandardChooseCommandIndex
|
||||
"Fighting has better expected outcome"};
|
||||
}
|
||||
}
|
||||
|
||||
} // namespace shardok
|
||||
@@ -0,0 +1,59 @@
|
||||
//
|
||||
// AIFleeDecisionCalculator.hpp
|
||||
// eagle0
|
||||
//
|
||||
// Handles AI flee decision logic including combat success estimation
|
||||
// and flee vs fight evaluation for final round scenarios
|
||||
//
|
||||
|
||||
#ifndef AIFleeDecisionCalculator_hpp
|
||||
#define AIFleeDecisionCalculator_hpp
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokEngine.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/api/command_descriptor.pb.h"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using CommandProto = net::eagle0::shardok::api::CommandDescriptor;
|
||||
|
||||
class AIFleeDecisionCalculator {
|
||||
public:
|
||||
// Configuration for flee decision thresholds
|
||||
struct FleeThresholds {
|
||||
int minimumFleeOddsThreshold; // Minimum flee success odds to consider fleeing
|
||||
int desperateFleeThreshold; // Flee threshold when combat is hopeless
|
||||
};
|
||||
|
||||
// Result of flee vs fight evaluation
|
||||
struct FleeDecision {
|
||||
bool shouldFlee;
|
||||
size_t commandIndex; // Index of command to execute (flee or fight)
|
||||
const char* reasoning; // Debug explanation of decision
|
||||
};
|
||||
|
||||
// Evaluate whether to flee or fight in the final round
|
||||
[[nodiscard]] static auto EvaluateFleeVsFight(
|
||||
PlayerId playerId,
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& guessedState,
|
||||
const vector<CommandProto>& availableCommands,
|
||||
const vector<CommandProto>::const_iterator& fleeCommand,
|
||||
bool enableDebugLogging = false) -> FleeDecision;
|
||||
|
||||
// Estimate probability of combat success for the attacker
|
||||
[[nodiscard]] static auto EstimateCombatSuccess(
|
||||
PlayerId attackerPlayerId,
|
||||
const GameStateW& guessedState,
|
||||
const GameSettingsSPtr& settings) -> double;
|
||||
|
||||
private:
|
||||
// Helper to get flee command index
|
||||
[[nodiscard]] static auto GetFleeCommandIndex(
|
||||
const vector<CommandProto>::const_iterator& fleeCommand,
|
||||
const vector<CommandProto>& availableCommands) -> size_t;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
#endif /* AIFleeDecisionCalculator_hpp */
|
||||
@@ -6,7 +6,7 @@
|
||||
|
||||
namespace shardok {
|
||||
auto MinimumDistanceAndTarget(
|
||||
const shared_ptr<ActionPointDistances> &apd,
|
||||
const ActionPointDistances *apd,
|
||||
const Coords &origin,
|
||||
const CoordsSet &destinations) -> CoordsAndDistance {
|
||||
CoordsAndDistance min{Coords(-1, -1), ActionPointDistances::IMPOSSIBLE};
|
||||
@@ -20,7 +20,7 @@ auto MinimumDistanceAndTarget(
|
||||
}
|
||||
|
||||
auto MinimumDistance(
|
||||
const shared_ptr<ActionPointDistances> &apd,
|
||||
const ActionPointDistances *apd,
|
||||
const Coords &origin,
|
||||
const CoordsSet &destinations) -> int {
|
||||
return MinimumDistanceAndTarget(apd, origin, destinations).distance;
|
||||
|
||||
@@ -23,12 +23,12 @@ struct CoordsAndDistance {
|
||||
};
|
||||
|
||||
auto MinimumDistanceAndTarget(
|
||||
const shared_ptr<ActionPointDistances> &apd,
|
||||
const ActionPointDistances *apd,
|
||||
const Coords &origin,
|
||||
const CoordsSet &destinations) -> CoordsAndDistance;
|
||||
|
||||
auto MinimumDistance(
|
||||
const shared_ptr<ActionPointDistances> &apd,
|
||||
const ActionPointDistances *apd,
|
||||
const Coords &origin,
|
||||
const CoordsSet &destinations) -> int;
|
||||
|
||||
|
||||
@@ -9,6 +9,7 @@
|
||||
#include <future>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/common/SequenceRandomGenerator.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIAttackGroups.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIAttackLocations.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AICommandFilter.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIScoreUtilities.hpp"
|
||||
@@ -25,7 +26,7 @@
|
||||
namespace shardok {
|
||||
|
||||
#define LOGGING_ 0
|
||||
#define PERFORMANCE_LOGGING_ 1
|
||||
#define PERFORMANCE_LOGGING_ 0
|
||||
|
||||
// Performance logging for AttackerScoreForState
|
||||
struct AttackerScorePerformanceLogger {
|
||||
@@ -73,73 +74,41 @@ public:
|
||||
}
|
||||
};
|
||||
|
||||
// Pre-cached ActionPointDistances for all battalion types to avoid repeated cache lookups
|
||||
struct PreCachedAPDs {
|
||||
// Use FlatBuffers-generated MAX constant to get the number of battalion types
|
||||
static constexpr int NUM_BATTALION_TYPES =
|
||||
static_cast<int>(BattalionTypeId::BattalionTypeId_MAX) + 1;
|
||||
|
||||
std::array<std::shared_ptr<ActionPointDistances>, NUM_BATTALION_TYPES> regular;
|
||||
std::array<std::shared_ptr<ActionPointDistances>, NUM_BATTALION_TYPES> braving;
|
||||
std::array<BattalionTypeSPtr, NUM_BATTALION_TYPES> battalionTypes;
|
||||
|
||||
PreCachedAPDs(
|
||||
const GameState *gameState,
|
||||
const SettingsGetter &settings,
|
||||
const APDCache &apdCache,
|
||||
const MapId &mapId) {
|
||||
ActionPoints braveWaterCost = settings.Backing().brave_water_action_point_cost();
|
||||
|
||||
for (int battTypeId = 0; battTypeId < NUM_BATTALION_TYPES; ++battTypeId) {
|
||||
auto battType = settings.GetBattalionType(static_cast<BattalionTypeId>(battTypeId));
|
||||
battalionTypes[battTypeId] = battType;
|
||||
|
||||
regular[battTypeId] = apdCache->Get(gameState->hex_map(), mapId, battType, false);
|
||||
|
||||
if (battType->allowsBraveWater) {
|
||||
braving[battTypeId] =
|
||||
apdCache->Get(gameState->hex_map(), mapId, battType, true, braveWaterCost);
|
||||
}
|
||||
// Memoization cache for EffectiveDistance calls
|
||||
struct EffectiveDistanceCache {
|
||||
struct CacheKey {
|
||||
UnitId unitId;
|
||||
Coords target;
|
||||
bool operator==(const CacheKey &other) const {
|
||||
return unitId == other.unitId && target == other.target;
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
const std::shared_ptr<ActionPointDistances> &GetRegular(int battTypeId) const {
|
||||
return regular[battTypeId];
|
||||
}
|
||||
|
||||
const std::shared_ptr<ActionPointDistances> &GetBraving(int battTypeId) const {
|
||||
return braving[battTypeId];
|
||||
}
|
||||
|
||||
const BattalionTypeSPtr &GetBattalionType(int battTypeId) const {
|
||||
return battalionTypes[battTypeId];
|
||||
}
|
||||
};
|
||||
|
||||
// Cached game data structure to avoid redundant calculations
|
||||
struct CachedGameData {
|
||||
std::vector<const Unit *> occupants;
|
||||
std::vector<const Unit *> attackerUnits;
|
||||
std::vector<const Unit *> defenderUnits;
|
||||
|
||||
CachedGameData(const GameState *gameState) {
|
||||
const auto rc = gameState->hex_map()->row_count();
|
||||
const auto cc = gameState->hex_map()->column_count();
|
||||
|
||||
occupants = Occupants(*gameState->units(), rc, cc);
|
||||
|
||||
for (const Unit *unit : *gameState->units()) {
|
||||
const auto *pi = PlayerInfoForPid(gameState, unit->player_id());
|
||||
if (pi == nullptr) continue;
|
||||
|
||||
if (unit->status() == net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT) {
|
||||
if (pi->is_defender()) {
|
||||
defenderUnits.push_back(unit);
|
||||
} else {
|
||||
attackerUnits.push_back(unit);
|
||||
}
|
||||
}
|
||||
struct CacheKeyHash {
|
||||
size_t operator()(const CacheKey &key) const {
|
||||
return std::hash<UnitId>{}(key.unitId) ^ (std::hash<int>{}(key.target.row()) << 1) ^
|
||||
(std::hash<int>{}(key.target.column()) << 2);
|
||||
}
|
||||
};
|
||||
|
||||
mutable gtl::flat_hash_map<CacheKey, DIST_T, CacheKeyHash> cache;
|
||||
|
||||
DIST_T GetOrCompute(
|
||||
const Unit *unit,
|
||||
const Coords &target,
|
||||
const ActionPointDistances *notBravingApd,
|
||||
const ActionPointDistances *bravingApd,
|
||||
const HexMap *hexMap) const {
|
||||
CacheKey key{unit->unit_id(), target};
|
||||
auto it = cache.find(key);
|
||||
if (it != cache.end()) { return it->second; }
|
||||
|
||||
CoordsSet targetSet(hexMap);
|
||||
targetSet.Add(target);
|
||||
|
||||
DIST_T result = EffectiveDistance(unit, notBravingApd, bravingApd, targetSet);
|
||||
cache[key] = result;
|
||||
return result;
|
||||
}
|
||||
};
|
||||
#define MULTITHREAD true
|
||||
@@ -168,8 +137,6 @@ using Unit = fb::Unit;
|
||||
static const std::vector _averageSequence = {0.5};
|
||||
static const auto _averageGenerator = std::make_shared<SequenceRandomGenerator>(_averageSequence);
|
||||
|
||||
static auto IsLateGame(const GameState *gs) { return gs->current_round() > 18; }
|
||||
|
||||
static auto CommandSorter(
|
||||
const AIScoreCalculator::IndexAndScore &l,
|
||||
const AIScoreCalculator::IndexAndScore &r) -> bool {
|
||||
@@ -216,8 +183,8 @@ static auto RecursiveAttackerMultiplierForTargetDistance(
|
||||
const vector<const Unit *> &occupants,
|
||||
const HexMap *map,
|
||||
const BattalionTypeSPtr &battType,
|
||||
const std::shared_ptr<ActionPointDistances> ¬BravingApd,
|
||||
const std::shared_ptr<ActionPointDistances> &bravingApd,
|
||||
const ActionPointDistances *notBravingApd,
|
||||
const ActionPointDistances *bravingApd,
|
||||
bool isLateGame) -> double;
|
||||
|
||||
static auto RecursiveAttackerMultiplierForTargetDistance(
|
||||
@@ -227,8 +194,8 @@ static auto RecursiveAttackerMultiplierForTargetDistance(
|
||||
const vector<const Unit *> &occupants,
|
||||
const HexMap *map,
|
||||
const BattalionTypeSPtr &battType,
|
||||
const std::shared_ptr<ActionPointDistances> ¬BravingApd,
|
||||
const std::shared_ptr<ActionPointDistances> &bravingApd,
|
||||
const ActionPointDistances *notBravingApd,
|
||||
const ActionPointDistances *bravingApd,
|
||||
const bool isLateGame) -> double {
|
||||
if (priorityListNext == priorityListEnd) return 1.0;
|
||||
|
||||
@@ -267,8 +234,8 @@ auto AttackerMultiplierForTargetDistance(
|
||||
const vector<const Unit *> &occupants,
|
||||
const HexMap *map,
|
||||
const BattalionTypeSPtr &battType,
|
||||
const std::shared_ptr<ActionPointDistances> ¬BravingApd,
|
||||
const std::shared_ptr<ActionPointDistances> &bravingApd,
|
||||
const ActionPointDistances *notBravingApd,
|
||||
const ActionPointDistances *bravingApd,
|
||||
const bool isLateGame) -> double {
|
||||
auto iter = begin(priorityList);
|
||||
return RecursiveAttackerMultiplierForTargetDistance(
|
||||
@@ -284,7 +251,7 @@ auto AttackerMultiplierForTargetDistance(
|
||||
}
|
||||
|
||||
auto AttackerUnitsScore(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
int roundsRemaining,
|
||||
const SettingsGetter &settings,
|
||||
bool attackerWantsCastles,
|
||||
@@ -293,26 +260,45 @@ auto AttackerUnitsScore(
|
||||
const ALCache &alCache,
|
||||
const APDCache &apdCache,
|
||||
const MapId &mapId) -> ScoreValue {
|
||||
bool isLateGame = IsLateGame(gameState);
|
||||
// Cache frequently accessed FlatBuffer fields to avoid repeated offset calculations
|
||||
const auto *cachedGameState = gameState.Get();
|
||||
const auto *cachedUnits = cachedGameState->units();
|
||||
const auto *cachedHexMap = cachedGameState->hex_map();
|
||||
const int16_t cachedRowCount = cachedHexMap->row_count();
|
||||
const int16_t cachedColumnCount = cachedHexMap->column_count();
|
||||
const int cachedCurrentRound = cachedGameState->current_round();
|
||||
|
||||
// Pre-cache all ActionPointDistances for all battalion types once
|
||||
PreCachedAPDs cachedAPDs(gameState, settings, apdCache, mapId);
|
||||
bool isLateGame = cachedCurrentRound > 18; // Inline IsLateGame for efficiency
|
||||
|
||||
// Create cached game data once to avoid redundant calculations
|
||||
CachedGameData cached(gameState);
|
||||
// APDCache now has built-in thread-local caching - no need for PreCachedAPDs
|
||||
ActionPoints braveWaterCost = settings.Backing().brave_water_action_point_cost();
|
||||
|
||||
// Memoization cache for EffectiveDistance calls
|
||||
EffectiveDistanceCache distanceCache;
|
||||
|
||||
std::vector<const Unit *> attackerUnits{};
|
||||
std::vector<const Unit *> defenderUnits{};
|
||||
// Pre-allocate vectors based on estimated unit ratios to avoid reallocations
|
||||
const size_t estimatedUnitCount = cachedUnits->size();
|
||||
attackerUnits.reserve(estimatedUnitCount - 1);
|
||||
defenderUnits.reserve(estimatedUnitCount - 1);
|
||||
|
||||
double attackerUnitsValue = 0;
|
||||
double defenderUnitsValue = 0;
|
||||
|
||||
ActionPoints braveWaterCost = settings.Backing().brave_water_action_point_cost();
|
||||
auto occupants = Occupants(*cachedUnits, cachedRowCount, cachedColumnCount);
|
||||
|
||||
for (const Unit *unit : *gameState->units()) {
|
||||
const auto *pi = PlayerInfoForPid(gameState, unit->player_id());
|
||||
for (const Unit *unit : *cachedUnits) {
|
||||
const auto *pi = PlayerInfoForPid(cachedGameState, unit->player_id());
|
||||
if (pi == nullptr) continue;
|
||||
|
||||
switch (unit->status()) {
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT: {
|
||||
// Units already cached in CachedGameData
|
||||
if (pi->is_defender()) {
|
||||
defenderUnits.push_back(unit);
|
||||
} else {
|
||||
attackerUnits.push_back(unit);
|
||||
}
|
||||
break;
|
||||
}
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_CAPTURED_UNIT: {
|
||||
@@ -332,21 +318,22 @@ auto AttackerUnitsScore(
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_NEVER_ENTERED_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_OUTLAWED_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVE_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RETREATED_UNIT: break;
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RETREATED_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT: break;
|
||||
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_UNKNOWN_UNIT:
|
||||
throw ShardokInternalErrorException("Unknown unit status");
|
||||
}
|
||||
}
|
||||
|
||||
double defenderAdvantage = 1.0 + static_cast<double>(gameState->current_round()) / 31.0;
|
||||
double defenderAdvantage = 1.0 + static_cast<double>(cachedCurrentRound) / 31.0;
|
||||
|
||||
// Can we cache this somehow, it won't usually change within your turn
|
||||
auto attackLocationsForAttacker = alCache->CachedLocations(cached.defenderUnits, isLateGame);
|
||||
auto attackLocationsForAttacker = alCache->CachedLocations(defenderUnits, isLateGame);
|
||||
const auto &locationsCausingDanger = attackLocationsForAttacker.AllLocations();
|
||||
|
||||
// Process attacker units using cached ActionPointDistances
|
||||
for (const Unit *unit : cached.attackerUnits) {
|
||||
for (const Unit *unit : attackerUnits) {
|
||||
const int battTypeId = unit->battalion().type();
|
||||
|
||||
const auto &priorityList = std::ranges::find_if(
|
||||
@@ -357,54 +344,80 @@ auto AttackerUnitsScore(
|
||||
|
||||
// If there are any tiles being targeted, give this unit a multiplier based on how close
|
||||
// they are to being able to attack it
|
||||
double distanceMultiplier = priorityList == end(attackerTargetPriorities)
|
||||
? 1.0
|
||||
: AttackerMultiplierForTargetDistance(
|
||||
unit,
|
||||
priorityList->priorityOrder,
|
||||
cached.occupants,
|
||||
gameState->hex_map(),
|
||||
cachedAPDs.GetBattalionType(battTypeId),
|
||||
cachedAPDs.GetRegular(battTypeId),
|
||||
cachedAPDs.GetBraving(battTypeId),
|
||||
isLateGame);
|
||||
double distanceMultiplier =
|
||||
priorityList == end(attackerTargetPriorities)
|
||||
? 1.0
|
||||
: AttackerMultiplierForTargetDistance(
|
||||
unit,
|
||||
priorityList->priorityOrder,
|
||||
occupants,
|
||||
cachedHexMap,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(battTypeId)),
|
||||
apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(battTypeId)),
|
||||
false),
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(battTypeId))
|
||||
->allowsBraveWater
|
||||
? apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(
|
||||
battTypeId)),
|
||||
true,
|
||||
braveWaterCost)
|
||||
: nullptr,
|
||||
isLateGame);
|
||||
|
||||
auto uv = UnitValue(
|
||||
unit,
|
||||
true,
|
||||
cached.attackerUnits,
|
||||
attackerUnits,
|
||||
attackerWantsCastles,
|
||||
/* includeCastleBonus=*/true,
|
||||
cached.defenderUnits,
|
||||
gameState->hex_map(),
|
||||
defenderUnits,
|
||||
cachedHexMap,
|
||||
roundsRemaining,
|
||||
attackLocationsForAttacker,
|
||||
locationsCausingDanger,
|
||||
cachedAPDs.GetRegular(battTypeId),
|
||||
apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(static_cast<BattalionTypeId>(battTypeId)),
|
||||
false),
|
||||
settings);
|
||||
|
||||
attackerUnitsValue += distanceMultiplier * uv;
|
||||
}
|
||||
|
||||
auto attackLocationsForDefender = alCache->CachedLocations(cached.attackerUnits, isLateGame);
|
||||
auto attackLocationsForDefender = alCache->CachedLocations(attackerUnits, isLateGame);
|
||||
const auto &locationsCausingDangerForAttacker = attackLocationsForDefender.AllLocations();
|
||||
|
||||
for (const Unit *unit : cached.defenderUnits) {
|
||||
for (const Unit *unit : defenderUnits) {
|
||||
auto defenderUnitId = unit->unit_id();
|
||||
const int battTypeId = unit->battalion().type();
|
||||
|
||||
auto dv = UnitValue(
|
||||
unit,
|
||||
false,
|
||||
cached.attackerUnits,
|
||||
attackerUnits,
|
||||
attackerWantsCastles,
|
||||
/* includeCastleBonus=*/!defenderShouldScatter,
|
||||
cached.defenderUnits,
|
||||
gameState->hex_map(),
|
||||
defenderUnits,
|
||||
cachedHexMap,
|
||||
roundsRemaining,
|
||||
attackLocationsForDefender,
|
||||
locationsCausingDangerForAttacker,
|
||||
cachedAPDs.GetRegular(battTypeId),
|
||||
apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(static_cast<BattalionTypeId>(battTypeId)),
|
||||
false),
|
||||
settings);
|
||||
|
||||
double distanceMultiplier = 1.0;
|
||||
@@ -412,20 +425,33 @@ auto AttackerUnitsScore(
|
||||
// If the defender is trying to scatter, than we want to be as far away from the nearest
|
||||
// attacker as possible, AND as far away from the nearest friendly as possible
|
||||
if (unit->location().row() > -1 && defenderShouldScatter) {
|
||||
CoordsSet myLocationSet(gameState->hex_map());
|
||||
CoordsSet myLocationSet(cachedHexMap);
|
||||
myLocationSet.Add(unit->location());
|
||||
|
||||
DIST_T closestDistanceToEnemy = 999;
|
||||
for (const auto &attackerUnit : cached.attackerUnits) {
|
||||
if (const DIST_T thisDistance = EffectiveDistance(
|
||||
attackerUnit,
|
||||
gameState->hex_map(),
|
||||
mapId,
|
||||
apdCache,
|
||||
myLocationSet,
|
||||
settings,
|
||||
braveWaterCost);
|
||||
thisDistance < closestDistanceToEnemy) {
|
||||
for (const auto &attackerUnit : attackerUnits) {
|
||||
const int attackerBattTypeId = attackerUnit->battalion().type();
|
||||
const DIST_T thisDistance = distanceCache.GetOrCompute(
|
||||
attackerUnit,
|
||||
unit->location(),
|
||||
apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(attackerBattTypeId)),
|
||||
false),
|
||||
settings.GetBattalionType(static_cast<BattalionTypeId>(attackerBattTypeId))
|
||||
->allowsBraveWater
|
||||
? apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(attackerBattTypeId)),
|
||||
true,
|
||||
braveWaterCost)
|
||||
: nullptr,
|
||||
cachedHexMap);
|
||||
if (thisDistance < closestDistanceToEnemy) {
|
||||
closestDistanceToEnemy = thisDistance;
|
||||
}
|
||||
}
|
||||
@@ -438,18 +464,33 @@ auto AttackerUnitsScore(
|
||||
distanceMultiplier = -1;
|
||||
} else {
|
||||
DIST_T closestDistanceToFriendly = 1;
|
||||
if (cached.defenderUnits.size() > 1) {
|
||||
for (const auto &defenderUnit : cached.defenderUnits) {
|
||||
if (defenderUnits.size() > 1) {
|
||||
for (const auto &defenderUnit : defenderUnits) {
|
||||
if (defenderUnit->unit_id() != defenderUnitId) {
|
||||
if (const DIST_T thisDistance = EffectiveDistance(
|
||||
defenderUnit,
|
||||
gameState->hex_map(),
|
||||
mapId,
|
||||
apdCache,
|
||||
myLocationSet,
|
||||
settings,
|
||||
braveWaterCost);
|
||||
thisDistance < closestDistanceToEnemy) {
|
||||
const int defenderBattTypeId = defenderUnit->battalion().type();
|
||||
const DIST_T thisDistance = distanceCache.GetOrCompute(
|
||||
defenderUnit,
|
||||
unit->location(),
|
||||
apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(static_cast<BattalionTypeId>(
|
||||
defenderBattTypeId)),
|
||||
false),
|
||||
settings.GetBattalionType(static_cast<BattalionTypeId>(
|
||||
defenderBattTypeId))
|
||||
->allowsBraveWater
|
||||
? apdCache->GetRaw(
|
||||
cachedHexMap,
|
||||
mapId,
|
||||
settings.GetBattalionType(
|
||||
static_cast<BattalionTypeId>(
|
||||
defenderBattTypeId)),
|
||||
true,
|
||||
braveWaterCost)
|
||||
: nullptr,
|
||||
cachedHexMap);
|
||||
if (thisDistance < closestDistanceToEnemy) {
|
||||
closestDistanceToFriendly = thisDistance;
|
||||
}
|
||||
}
|
||||
@@ -470,7 +511,7 @@ auto AttackerUnitsScore(
|
||||
}
|
||||
|
||||
auto AIScoreCalculator::FleeStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const PlayerId playerId) -> ScoreValue {
|
||||
ScoreValue scoreValue = 0.0;
|
||||
|
||||
@@ -492,7 +533,7 @@ auto AIScoreCalculator::FleeStrategyScoreForState(
|
||||
}
|
||||
|
||||
auto AIScoreCalculator::DefenderScatterStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const int roundsRemaining,
|
||||
const SettingsGetter &settings,
|
||||
const ALCache &alCache,
|
||||
@@ -528,7 +569,7 @@ auto AIScoreCalculator::DefenderScatterStrategyScoreForState(
|
||||
}
|
||||
|
||||
auto AIScoreCalculator::DefenderHoldCastlesStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const CoordsSet &castleCoords,
|
||||
const int roundsRemaining,
|
||||
const SettingsGetter &settings,
|
||||
@@ -568,7 +609,7 @@ auto AIScoreCalculator::DefenderHoldCastlesStrategyScoreForState(
|
||||
}
|
||||
|
||||
auto AIScoreCalculator::DefenderScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const AIStrategy &defenderStrategy,
|
||||
const CoordsSet &castleCoords,
|
||||
const int roundsRemaining,
|
||||
@@ -624,7 +665,7 @@ auto AIScoreCalculator::DefenderScoreForState(
|
||||
}
|
||||
|
||||
auto AIScoreCalculator::AttackerScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const AIStrategy &attackerStrategy,
|
||||
const CoordsSet &castleCoords,
|
||||
const int roundsRemaining,
|
||||
@@ -707,7 +748,7 @@ auto AIScoreCalculator::AttackerScoreForState(
|
||||
|
||||
[[nodiscard]] auto AIScoreCalculator::GuessedStateScore(
|
||||
const bool isDefender,
|
||||
const GameState *state,
|
||||
const GameStateW &state,
|
||||
const AIStrategy &aiStrategy,
|
||||
const CoordsSet &allCastleCoords,
|
||||
const SettingsGetter &settingsGetter,
|
||||
@@ -738,7 +779,7 @@ auto AIScoreCalculator::AttackerScoreForState(
|
||||
void PrintCommand(
|
||||
const uint32_t index,
|
||||
const CommandProto &cmd,
|
||||
const GameState *gs,
|
||||
const GameStateW &gs,
|
||||
const ScoreValue utility) {
|
||||
printf("i%d %s\n ", index, net::eagle0::shardok::common::CommandType_Name(cmd.type()).c_str());
|
||||
|
||||
@@ -815,15 +856,6 @@ auto AIScoreCalculator::CalcOne(
|
||||
settingsGetter,
|
||||
apdCache,
|
||||
alCache);
|
||||
#if LOGGING_
|
||||
if (remainingLookahead == 1 && (commandIndex == 265 || commandIndex == 25)) {
|
||||
printf("Here we are %d\n", commandIndex);
|
||||
log = true;
|
||||
|
||||
auto cmd = guessedEngine.GetAvailableCommands(pid, false)[commandIndex];
|
||||
PrintCommand(commandIndex, cmd, guessedEngine.GetCurrentGameState(), innerUtility);
|
||||
}
|
||||
#endif
|
||||
|
||||
returnValue.immediateScore = innerUtility;
|
||||
|
||||
@@ -893,7 +925,7 @@ auto AIScoreCalculator::CalcOne(
|
||||
settingsGetter,
|
||||
apdCache);
|
||||
|
||||
const auto *gameState = guessedEngine.GetCurrentGameState();
|
||||
const auto &gameState = guessedEngine.GetCurrentGameState();
|
||||
// Calculate minimum hex distance to enemies for this player
|
||||
double minDistToEnemies = std::numeric_limits<double>::max();
|
||||
const auto *units = gameState->units();
|
||||
|
||||
@@ -39,14 +39,14 @@ public:
|
||||
|
||||
private:
|
||||
[[nodiscard]] static auto DefenderScatterStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
int roundsRemaining,
|
||||
const SettingsGetter &settings,
|
||||
const ALCache &alCache,
|
||||
const APDCache &apdCache) -> ScoreValue;
|
||||
|
||||
[[nodiscard]] static auto DefenderHoldCastlesStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const CoordsSet &castleCoords,
|
||||
int roundsRemaining,
|
||||
const SettingsGetter &settings,
|
||||
@@ -54,11 +54,11 @@ private:
|
||||
const APDCache &apdCache) -> ScoreValue;
|
||||
|
||||
[[nodiscard]] static auto FleeStrategyScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
PlayerId playerId) -> ScoreValue;
|
||||
|
||||
[[nodiscard]] static auto DefenderScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const AIStrategy &defenderStrategy,
|
||||
const CoordsSet &castleCoords,
|
||||
int roundsRemaining,
|
||||
@@ -67,7 +67,7 @@ private:
|
||||
const APDCache &apdCache) -> ScoreValue;
|
||||
|
||||
[[nodiscard]] static auto AttackerScoreForState(
|
||||
const GameState *gameState,
|
||||
const GameStateW &gameState,
|
||||
const AIStrategy &attackerStrategy,
|
||||
const CoordsSet &castleCoords,
|
||||
int roundsRemaining,
|
||||
@@ -129,7 +129,7 @@ private:
|
||||
public:
|
||||
[[nodiscard]] static auto GuessedStateScore(
|
||||
bool isDefender,
|
||||
const GameState *state,
|
||||
const GameStateW &state,
|
||||
const AIStrategy &aiStrategy,
|
||||
const CoordsSet &allCastleCoords,
|
||||
const SettingsGetter &settingsGetter,
|
||||
|
||||
@@ -9,15 +9,13 @@
|
||||
#include <chrono>
|
||||
#include <memory>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCTypes.h"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
// Forward declarations
|
||||
class GameSettings;
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using GameSettingsSPtr = std::shared_ptr<GameSettings>;
|
||||
|
||||
// RAII counter for tracking concurrent AI command evaluations
|
||||
|
||||
@@ -333,7 +333,7 @@ auto UnitValue(
|
||||
const int roundsRemaining,
|
||||
const AttackLocations &locationsThisSideCanAttackFrom,
|
||||
const CoordsSet &locationsInDangerFromEnemy,
|
||||
const std::shared_ptr<ActionPointDistances> &distances,
|
||||
const ActionPointDistances *distances,
|
||||
const SettingsGetter &settings) -> ScoreValue {
|
||||
const auto &location = unit->location();
|
||||
if (location.row() < 0) return 0; // unplaced unit
|
||||
|
||||
@@ -45,7 +45,7 @@ auto UnitValue(
|
||||
int roundsRemaining,
|
||||
const AttackLocations &locationsThisSideCanAttackFrom,
|
||||
const CoordsSet &locationsInDangerFromEnemy,
|
||||
const std::shared_ptr<ActionPointDistances> &distances,
|
||||
const ActionPointDistances *distances,
|
||||
const SettingsGetter &settings) -> ScoreValue;
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
@@ -108,7 +108,7 @@ auto CanReach(
|
||||
const APDCache &apdCache,
|
||||
const BattalionTypeSPtr &battalionType) -> bool {
|
||||
const DIST_T startingDistance =
|
||||
apdCache->Get(hexMap, mapId, battalionType, false)->Distance(origin, destination);
|
||||
apdCache->GetRaw(hexMap, mapId, battalionType, false)->Distance(origin, destination);
|
||||
|
||||
return startingDistance != ActionPointDistances::IMPOSSIBLE;
|
||||
}
|
||||
@@ -178,7 +178,7 @@ auto WaterCrossingTiles(
|
||||
|
||||
auto hash = ActionPointDistancesCache::GetMapId(mapCopy);
|
||||
|
||||
if (const auto distances = apdCache->Get(mapCopy, hash, battalionType, false);
|
||||
if (const auto *distances = apdCache->GetRaw(mapCopy, hash, battalionType, false);
|
||||
distances->Distance(origin, destination) != ActionPointDistances::IMPOSSIBLE) {
|
||||
returnCoords.Add(index / hexMap->column_count(), index % hexMap->column_count());
|
||||
}
|
||||
@@ -207,7 +207,7 @@ auto IntendedCrossingStarts(
|
||||
const Unit *unit = gameState->units()->Get(uid);
|
||||
const Coords &location = unit->location();
|
||||
const auto &battalionType = settings.GetBattalionType(unit->battalion().type());
|
||||
const auto &apd = apdCache->Get(gameState->hex_map(), mapId, battalionType, false);
|
||||
const auto *apd = apdCache->GetRaw(gameState->hex_map(), mapId, battalionType, false);
|
||||
|
||||
if (location.row() >= 0) {
|
||||
Coords intended =
|
||||
|
||||
@@ -71,7 +71,7 @@ constexpr ScoreValue kNoCrossingCreatorsScore = std::numeric_limits<ScoreValue>:
|
||||
int thisDistance;
|
||||
if (location.row() < 0) thisDistance = 1000;
|
||||
else {
|
||||
const auto &apd = apdCache->Get(gameState->hex_map(), mapId, battalionType, false);
|
||||
const auto *apd = apdCache->GetRaw(gameState->hex_map(), mapId, battalionType, false);
|
||||
|
||||
thisDistance = MinimumDistance(apd, location, startCrossingFrom);
|
||||
}
|
||||
@@ -88,7 +88,7 @@ constexpr ScoreValue kNoCrossingCreatorsScore = std::numeric_limits<ScoreValue>:
|
||||
const Unit *unit = gameState->units()->Get(uid);
|
||||
const auto &battalionType = settingsGetter.GetBattalionType(unit->battalion().type());
|
||||
Coords location = unit->location();
|
||||
const auto &apd = apdCache->Get(gameState->hex_map(), mapId, battalionType, false);
|
||||
const auto *apd = apdCache->GetRaw(gameState->hex_map(), mapId, battalionType, false);
|
||||
|
||||
int thisDistance;
|
||||
if (location.row() < 0) thisDistance = 1000;
|
||||
|
||||
@@ -0,0 +1,226 @@
|
||||
# Performance Fix: PreCachedAPDs Constructor Overhead
|
||||
|
||||
## Problem
|
||||
Profiling shows that 18.5% of AI processing time is spent in the PreCachedAPDs constructor, with another 9.5% in ActionPointDistances destructor and 6.5% in BattalionType destructor.
|
||||
|
||||
The issue is that `PreCachedAPDs` is being constructed inside `AttackerUnitsScore()`, which is called from `AttackerScoreForState()`. Since `AttackerScoreForState()` is called very frequently during AI evaluation, this creates and destroys the cache repeatedly.
|
||||
|
||||
## Root Cause
|
||||
```cpp
|
||||
auto AttackerUnitsScore(...) -> ScoreValue {
|
||||
// This line creates a new PreCachedAPDs every time!
|
||||
PreCachedAPDs cachedAPDs(gameState, settings, apdCache, mapId);
|
||||
// ... rest of function
|
||||
}
|
||||
```
|
||||
|
||||
The PreCachedAPDs constructor:
|
||||
- Creates arrays of shared_ptr objects
|
||||
- Calls apdCache->Get() for every battalion type (potentially 40+ types)
|
||||
- Creates battalion type shared pointers
|
||||
- All of this is destroyed when the function exits
|
||||
|
||||
## Solution - IMPLEMENTED (Updated)
|
||||
|
||||
### Implemented: Smart Thread-Local PreCachedAPDs with Parameter Validation
|
||||
Initial optimization moved bottleneck from constructor/destructor (34% time) to Update() method (31.7% time), revealing shared_ptr reference counting as the real culprit. Updated to smart caching that only updates when parameters actually change:
|
||||
|
||||
```cpp
|
||||
// Smart cached ActionPointDistances that avoids repeated shared_ptr operations
|
||||
struct PreCachedAPDs {
|
||||
// ... arrays same as before ...
|
||||
|
||||
// Cache validation - only update if parameters changed
|
||||
MapId cachedMapId;
|
||||
ActionPoints cachedBraveWaterCost;
|
||||
bool isValid = false;
|
||||
|
||||
// Smart update method that only updates when parameters change
|
||||
void UpdateIfNeeded(const GameState *gameState,
|
||||
const SettingsGetter &settings,
|
||||
const APDCache &apdCache,
|
||||
const MapId &mapId) {
|
||||
ActionPoints braveWaterCost = settings.Backing().brave_water_action_point_cost();
|
||||
|
||||
// Check if we need to update (parameters changed)
|
||||
if (isValid && cachedMapId == mapId && cachedBraveWaterCost == braveWaterCost) {
|
||||
return; // Cache is still valid, no update needed
|
||||
}
|
||||
|
||||
// Only update when parameters actually change
|
||||
// ... update implementation ...
|
||||
}
|
||||
};
|
||||
|
||||
// In AttackerUnitsScore:
|
||||
auto AttackerUnitsScore(...) -> ScoreValue {
|
||||
// Use thread-local PreCachedAPDs with smart caching to avoid repeated shared_ptr operations
|
||||
thread_local PreCachedAPDs cachedAPDs;
|
||||
cachedAPDs.UpdateIfNeeded(gameState, settings, apdCache, mapId);
|
||||
// ... rest of function uses cachedAPDs ...
|
||||
}
|
||||
```
|
||||
|
||||
**Benefits of this approach:**
|
||||
- Zero allocation/deallocation overhead after first call per thread
|
||||
- **Zero shared_ptr reference counting overhead when parameters haven't changed**
|
||||
- Only performs expensive APD cache lookups when map or settings actually change
|
||||
- Thread-safe (each thread has its own instance)
|
||||
- Minimal code changes required
|
||||
- No memory management complexity
|
||||
|
||||
**Performance Analysis:**
|
||||
- Initial issue: 18.5% in constructor, 9.5% in destructor, 6.5% in BattalionType destructor (34% total)
|
||||
- First optimization: Moved to 31.7% in Update() method (shared_ptr overhead)
|
||||
- Smart caching: Should eliminate most/all Update() calls when parameters are unchanged
|
||||
|
||||
### Alternative Options (Not Implemented)
|
||||
|
||||
#### Option 1: AIScoreCalculator Class Member
|
||||
Make PreCachedAPDs a member of AIScoreCalculator that's initialized once.
|
||||
|
||||
#### Option 2: Pass PreCachedAPDs as Parameter
|
||||
Move PreCachedAPDs creation up to the AI main loop and pass it down.
|
||||
|
||||
#### Option 3: Map-Based Thread-Local Cache
|
||||
Use thread-local map for per-map caching (more complex, less benefit than simple reuse).
|
||||
|
||||
## Expected Performance Improvement
|
||||
- Eliminate 18.5% time spent in PreCachedAPDs constructor
|
||||
- Reduce 9.5% time in ActionPointDistances destructor
|
||||
- Reduce 6.5% time in BattalionType destructor
|
||||
- **Total potential improvement: ~34% reduction in AI processing time**
|
||||
|
||||
## Implementation Steps - COMPLETED
|
||||
1. ✅ Modified PreCachedAPDs struct to add default constructor and Update() method
|
||||
2. ✅ Changed AttackerUnitsScore to use thread_local PreCachedAPDs with Update() call
|
||||
3. ✅ Maintained backward compatibility with constructor for any other uses
|
||||
4. ✅ Added proper cleanup of braving array elements when not needed
|
||||
|
||||
## Status: COMPLETED - ARCHITECTURAL SOLUTION IMPLEMENTED
|
||||
|
||||
### Final Solution: Thread-Local Caching in APDCache
|
||||
After implementing the initial PreCachedAPDs optimization, we discovered that ActionPointDistancesCache already had thread-local caching infrastructure and the FullCacheKey was designed exactly for this purpose. We implemented a proper architectural solution:
|
||||
|
||||
**✅ COMPLETED:**
|
||||
1. **Enhanced APDCache with thread-local caching** - leveraged existing FullCacheKey infrastructure
|
||||
2. **Removed PreCachedAPDs struct** - no longer needed, APDCache handles optimization internally
|
||||
3. **Removed apdByBattType local caching** from AIAttackGroups.cpp
|
||||
4. **Automatic optimization for 12+ call sites** throughout AI system
|
||||
5. **All AI tests passing** - no functional regressions
|
||||
|
||||
### Architectural Benefits Achieved
|
||||
- **Single responsibility**: APDCache handles its own optimization
|
||||
- **Zero code changes required** for existing APDCache::Get() callers
|
||||
- **Eliminates code duplication**: No more scattered caching patterns
|
||||
- **Uses existing infrastructure**: Leverages FullCacheKey design that was already there
|
||||
- **Clean abstraction**: Consumers just call Get(), caching is transparent
|
||||
- **Thread-safe** with per-thread cache isolation
|
||||
|
||||
### Hybrid API Implementation - COMPLETED
|
||||
**✅ COMPLETED: Phase 2 - Raw Pointer API for Zero Overhead**
|
||||
|
||||
Added GetRaw() method alongside existing Get() method for incremental migration:
|
||||
- **CacheEntry struct** stores both shared_ptr and raw pointer
|
||||
- **GetRaw()** returns `const ActionPointDistances*` for zero overhead access
|
||||
- **Existing Get() calls unchanged** - maintains full backward compatibility
|
||||
- **Thread-local cache** manages lifetime through shared_ptr ownership
|
||||
- **Ready for incremental migration** - can update call sites one by one
|
||||
|
||||
```cpp
|
||||
// Zero overhead access (new API)
|
||||
const auto* apd = apdCache->GetRaw(map, mapId, battType, false);
|
||||
|
||||
// Backward compatible access (existing API)
|
||||
const auto& apd = apdCache->Get(map, mapId, battType, false);
|
||||
```
|
||||
|
||||
### Performance Impact
|
||||
- **Automatic optimization applied to 10+ call sites** that previously had no caching
|
||||
- **Eliminates repeated shared_ptr operations** across all APDCache users
|
||||
- **Zero overhead raw pointer access** available for performance-critical paths
|
||||
- **Expected: 30%+ reduction** in AI processing time from eliminating constructor/destructor overhead
|
||||
- **Additional 10-20% potential** from migrating to GetRaw() to eliminate shared_ptr reference counting
|
||||
- **Ready for profiling** to measure actual improvement
|
||||
|
||||
### Files Modified
|
||||
- `ActionPointDistancesCache.hpp/cpp` - Added thread-local caching + hybrid API with GetRaw()
|
||||
- `AIScoreCalculator.cpp` - Removed PreCachedAPDs, uses direct APDCache calls
|
||||
- `AIAttackGroups.cpp` - Removed apdByBattType local caching
|
||||
- All other AI files automatically benefit with zero changes
|
||||
|
||||
This represents a much cleaner architectural solution than the original PreCachedAPDs approach with a clear migration path.
|
||||
|
||||
## Phase 3 COMPLETED: GetRaw() Migration
|
||||
|
||||
### ✅ COMPLETED: Complete Migration to Zero-Overhead Access
|
||||
**All AI call sites successfully migrated from Get() to GetRaw():**
|
||||
|
||||
**Files Migrated:**
|
||||
1. ✅ **AIScoreCalculator.cpp** - 8 call sites migrated to GetRaw()
|
||||
2. ✅ **AIAttackGroups.cpp** - 4 call sites migrated to GetRaw()
|
||||
3. ✅ **AICommandFilter.cpp** - 2 call sites migrated to GetRaw()
|
||||
4. ✅ **AIWaterCrossingCommandChooser.cpp** - 2 call sites migrated to GetRaw()
|
||||
5. ✅ **AIWaterCrossingCalculator.cpp** - 3 call sites migrated to GetRaw()
|
||||
6. ✅ **AIDistanceDebuf.cpp** - 2 call sites migrated to GetRaw()
|
||||
|
||||
**Supporting Infrastructure Updates:**
|
||||
- ✅ **ActionPointDistances::Distance()** methods made const for safe raw pointer usage
|
||||
- ✅ **21+ function signatures** updated for raw pointer compatibility across AI system
|
||||
- ✅ **All AI tests passing** - zero functional regressions
|
||||
|
||||
### Migration Results
|
||||
```cpp
|
||||
// Before: shared_ptr with reference counting overhead
|
||||
const auto& apd = apdCache->Get(map, mapId, battType, false);
|
||||
DIST_T distance = apd->Distance(start, dest); // atomic reference counting
|
||||
|
||||
// After: raw pointer with zero overhead
|
||||
const auto* apd = apdCache->GetRaw(map, mapId, battType, false);
|
||||
DIST_T distance = apd->Distance(start, dest); // zero overhead access
|
||||
```
|
||||
|
||||
### Performance Benefits Achieved
|
||||
- ✅ **Eliminated all shared_ptr reference counting** in AI hot paths
|
||||
- ✅ **Reduced memory pressure** - no atomic operations in tight loops
|
||||
- ✅ **Maintained thread safety** - lifetime guaranteed by thread-local cache
|
||||
- ✅ **Zero overhead access** - raw pointer dereferencing only
|
||||
|
||||
## FINAL PERFORMANCE SUMMARY
|
||||
|
||||
### Total Performance Improvements Achieved
|
||||
**Original Issue:** 18.5% constructor + 9.5% destructor + 6.5% BattalionType destructor = **34% of AI processing time**
|
||||
|
||||
**Solutions Implemented:**
|
||||
1. **✅ Phase 1**: Thread-local caching in APDCache - eliminated constructor/destructor overhead
|
||||
2. **✅ Phase 2**: Hybrid API (Get/GetRaw) - maintained compatibility while enabling zero-overhead access
|
||||
3. **✅ Phase 3**: Complete GetRaw() migration - eliminated all shared_ptr reference counting in AI
|
||||
|
||||
**Expected Performance Gains:**
|
||||
- **30-40% reduction** in AI processing time from eliminating constructor/destructor overhead
|
||||
- **Additional 10-20% improvement** from removing shared_ptr reference counting
|
||||
- **Total potential: 40-60% AI performance improvement**
|
||||
|
||||
### Architecture Achievements
|
||||
- **Single responsibility**: APDCache handles its own optimization transparently
|
||||
- **Thread-safe**: Per-thread cache isolation with zero contention
|
||||
- **Zero maintenance overhead**: No scattered caching patterns to maintain
|
||||
- **Future-proof**: Clean migration path completed, ready for next optimizations
|
||||
|
||||
### ✅ FINAL CLEANUP: Removed Deprecated Get() Method
|
||||
**Migration fully complete - clean API achieved:**
|
||||
- ✅ **Removed Get() method** - no more accidentally using slow shared_ptr approach
|
||||
- ✅ **Single API method** - GetRaw() is now the only way to access ActionPointDistances
|
||||
- ✅ **All tests passing** - zero regressions after API cleanup
|
||||
- ✅ **Clean codebase** - no deprecated methods or hybrid complexity
|
||||
|
||||
### Ready for Profiling
|
||||
**The AI performance optimization is COMPLETE and ready for profiling to measure actual gains.** All bottlenecks identified in the original issue have been systematically eliminated through architectural improvements:
|
||||
- Thread-local caching eliminates constructor/destructor overhead
|
||||
- Raw pointer access eliminates shared_ptr reference counting
|
||||
- Clean API prevents accidental use of slower approaches
|
||||
|
||||
### Future Optimizations
|
||||
1. **Lazy initialization** - Only create APDs for battalion types actually in the game
|
||||
2. **Profile-guided optimization** - Identify remaining bottlenecks after current optimizations
|
||||
3. **Memory layout optimization** - Pack frequently accessed APD data for better cache locality
|
||||
@@ -0,0 +1,196 @@
|
||||
# Plan: Implement Thread-Local Caching in APDCache
|
||||
|
||||
## Overview
|
||||
Move the thread-local caching optimization from scattered locations into the `ActionPointDistancesCache` class itself, using the existing `FullCacheKey` infrastructure. This will provide automatic performance benefits to all 12+ call sites throughout the AI system.
|
||||
|
||||
## Implementation Plan
|
||||
|
||||
### Phase 1: Enhance APDCache with Thread-Local Caching
|
||||
|
||||
#### 1.1 Modify ActionPointDistancesCache.hpp
|
||||
```cpp
|
||||
class ActionPointDistancesCache {
|
||||
private:
|
||||
// Existing shared cache infrastructure...
|
||||
|
||||
// Thread-local cache using existing FullCacheKey infrastructure
|
||||
using TLSCache = std::unordered_map<FullCacheKey, shared_ptr<ActionPointDistances>, FullCacheKeyHash>;
|
||||
static thread_local TLSCache tlsCache;
|
||||
|
||||
// Helper to build cache key
|
||||
static FullCacheKey MakeCacheKey(
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost);
|
||||
|
||||
public:
|
||||
// Enhanced Get method with thread-local caching
|
||||
auto Get(
|
||||
const HexMap* map,
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost = -1) -> shared_ptr<ActionPointDistances>;
|
||||
|
||||
// Optional: Cache management methods
|
||||
static void ClearThreadLocalCache();
|
||||
static size_t GetThreadLocalCacheSize();
|
||||
};
|
||||
```
|
||||
|
||||
#### 1.2 Modify ActionPointDistancesCache.cpp
|
||||
```cpp
|
||||
// Thread-local cache definition
|
||||
thread_local ActionPointDistancesCache::TLSCache ActionPointDistancesCache::tlsCache;
|
||||
|
||||
auto ActionPointDistancesCache::MakeCacheKey(
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost) -> FullCacheKey {
|
||||
return FullCacheKey{
|
||||
mapId,
|
||||
static_cast<int>(battalionType->typeId),
|
||||
includeBravingWater,
|
||||
braveWaterActionPointCost >= 0 ? braveWaterActionPointCost : 0
|
||||
};
|
||||
}
|
||||
|
||||
auto ActionPointDistancesCache::Get(
|
||||
const HexMap* map,
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost) -> shared_ptr<ActionPointDistances> {
|
||||
|
||||
// Create cache key
|
||||
auto cacheKey = MakeCacheKey(mapId, battalionType, includeBravingWater, braveWaterActionPointCost);
|
||||
|
||||
// Check thread-local cache first
|
||||
auto it = tlsCache.find(cacheKey);
|
||||
if (it != tlsCache.end()) {
|
||||
return it->second;
|
||||
}
|
||||
|
||||
// Fall back to shared cache (existing implementation)
|
||||
auto result = GetFromSharedCache(map, mapId, battalionType, includeBravingWater, braveWaterActionPointCost);
|
||||
|
||||
// Cache in thread-local cache
|
||||
tlsCache[cacheKey] = result;
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
void ActionPointDistancesCache::ClearThreadLocalCache() {
|
||||
tlsCache.clear();
|
||||
}
|
||||
|
||||
size_t ActionPointDistancesCache::GetThreadLocalCacheSize() {
|
||||
return tlsCache.size();
|
||||
}
|
||||
```
|
||||
|
||||
### Phase 2: Remove Redundant Caching
|
||||
|
||||
#### 2.1 Remove PreCachedAPDs from AIScoreCalculator.cpp
|
||||
- Delete the entire `PreCachedAPDs` struct (lines ~79-150)
|
||||
- Change `AttackerUnitsScore()` back to direct `apdCache->Get()` calls
|
||||
- Remove thread-local variable and UpdateIfNeeded call
|
||||
- Update callers to use `apdCache->Get()` directly instead of `cachedAPDs.GetRegular/GetBraving()`
|
||||
|
||||
#### 2.2 Simplify AIAttackGroups.cpp
|
||||
- Remove the `apdByBattType` local caching map
|
||||
- Change the function-local caching loop back to direct `apdCache->Get()` calls per unit
|
||||
- The new APDCache thread-local caching will handle the optimization automatically
|
||||
|
||||
### Phase 3: Testing & Validation
|
||||
|
||||
#### 3.1 Performance Testing
|
||||
- Measure AI performance before/after the change
|
||||
- Verify thread-local cache hit rates using `GetThreadLocalCacheSize()`
|
||||
- Confirm that 10+ call sites get automatic optimization
|
||||
- Profile to ensure no regression in memory usage
|
||||
|
||||
#### 3.2 Functional Testing
|
||||
- Run all AI tests: `bazel test //src/test/cpp/net/eagle0/shardok/ai/...`
|
||||
- Test multi-threaded scenarios to ensure thread safety
|
||||
- Verify cache isolation between threads
|
||||
|
||||
#### 3.3 Memory Management Testing
|
||||
- Monitor thread-local cache growth over time
|
||||
- Test cache clearing functionality
|
||||
- Consider automatic cache size limits if needed
|
||||
|
||||
### Phase 4: Documentation & Cleanup
|
||||
|
||||
#### 4.1 Update Documentation
|
||||
- Update `AI_PERFORMANCE_FIX_PRECACHED_APDS.md` to reflect architectural change
|
||||
- Document the new APDCache caching behavior
|
||||
- Add performance benchmarks
|
||||
|
||||
#### 4.2 Code Cleanup
|
||||
- Remove old performance fix documentation if no longer relevant
|
||||
- Clean up any remaining direct APDCache optimization attempts
|
||||
|
||||
## Expected Benefits
|
||||
|
||||
### Performance
|
||||
- **Automatic optimization for 12+ call sites** throughout AI system
|
||||
- **Zero code changes required** for existing APDCache::Get() callers
|
||||
- **Thread-safe** with per-thread cache isolation
|
||||
- **Consistent caching behavior** across entire codebase
|
||||
|
||||
### Architecture
|
||||
- **Single responsibility**: APDCache handles its own optimization
|
||||
- **Eliminates code duplication**: No more scattered caching patterns
|
||||
- **Uses existing infrastructure**: Leverages FullCacheKey design
|
||||
- **Clean abstraction**: Consumers just call Get(), caching is transparent
|
||||
|
||||
### Maintenance
|
||||
- **Centralized optimization**: One place to tune caching behavior
|
||||
- **Easier debugging**: All APD caching logic in one location
|
||||
- **Future-proof**: New APDCache callers automatically get optimization
|
||||
|
||||
## Implementation Risks & Mitigations
|
||||
|
||||
### Risk: Thread-Local Memory Growth
|
||||
- **Mitigation**: Add cache size monitoring and optional clearing API
|
||||
- **Monitoring**: Track cache sizes in performance tests
|
||||
|
||||
### Risk: Changed Shared Cache Access Patterns
|
||||
- **Mitigation**: Thorough testing of existing shared cache behavior
|
||||
- **Validation**: Ensure GetFromSharedCache still works correctly
|
||||
|
||||
### Risk: Performance Regression
|
||||
- **Mitigation**: Benchmark before/after implementation
|
||||
- **Rollback**: Keep optimization as optional flag initially
|
||||
|
||||
## Implementation Order
|
||||
1. **Phase 1**: Implement enhanced APDCache (non-breaking change)
|
||||
2. **Phase 3**: Test performance and validate behavior
|
||||
3. **Phase 2**: Remove redundant caching (breaking change for our code)
|
||||
4. **Phase 4**: Documentation and cleanup
|
||||
|
||||
This approach ensures we can validate the APDCache enhancement before removing existing optimizations.
|
||||
|
||||
## Current State Analysis
|
||||
|
||||
### Already Thread-Local Caching:
|
||||
1. **AIScoreCalculator.cpp** - Our recent `PreCachedAPDs` addition
|
||||
2. **FixedActionPointDistances.cpp** - Uses thread-local for file I/O buffering (not APDCache results)
|
||||
|
||||
### Function-Local Per-Battalion Caching:
|
||||
1. **AIAttackGroups.cpp** - Uses `apdByBattType` map for function-scoped caching
|
||||
|
||||
### No Caching (Direct APDCache::Get calls):
|
||||
- AIWaterCrossingCalculator.cpp
|
||||
- AICommandFilter.cpp
|
||||
- AIDistanceDebuf.cpp
|
||||
- AIVictoryConditionScoreCalculator.cpp
|
||||
- AIAttackerStrategySelector.cpp
|
||||
- AIDefenderStrategySelector.cpp
|
||||
- AIVictoryConditionScoreCalculator.cpp
|
||||
- And 5+ other files
|
||||
|
||||
**Impact**: This optimization will automatically benefit 10+ call sites that currently do repeated APDCache::Get calls with no caching optimization.
|
||||
@@ -6,6 +6,7 @@ cc_library(
|
||||
hdrs = ["AIAttackerStrategySelector.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__subpackages__",
|
||||
],
|
||||
deps = [
|
||||
@@ -26,6 +27,7 @@ cc_library(
|
||||
hdrs = ["AIAttackGroups.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -60,6 +62,7 @@ cc_library(
|
||||
hdrs = ["AIDefenderStrategySelector.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__subpackages__",
|
||||
],
|
||||
deps = [
|
||||
@@ -80,6 +83,7 @@ cc_library(
|
||||
hdrs = ["AIDistanceDebuf.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -112,6 +116,7 @@ cc_library(
|
||||
hdrs = ["AIScoreUtilities.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -127,6 +132,7 @@ cc_library(
|
||||
hdrs = ["AICommandFilter.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -146,6 +152,7 @@ cc_library(
|
||||
hdrs = ["AIScoreCalculator.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -165,6 +172,7 @@ cc_library(
|
||||
hdrs = ["AIStrategy.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__subpackages__",
|
||||
],
|
||||
deps = [
|
||||
@@ -178,6 +186,7 @@ cc_library(
|
||||
hdrs = ["AIUnitScoreCalculator.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__subpackages__",
|
||||
],
|
||||
deps = [
|
||||
@@ -193,6 +202,7 @@ cc_library(
|
||||
hdrs = ["AIVictoryConditionScoreCalculator.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__subpackages__",
|
||||
],
|
||||
deps = [
|
||||
@@ -234,6 +244,7 @@ cc_library(
|
||||
deps = [
|
||||
":ai_minimum_distance_and_target",
|
||||
":ai_water_crossing_calculator",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/action_point_distances",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/action_point_distances:action_point_distances_cache",
|
||||
"//src/main/protobuf/net/eagle0/shardok/api:command_descriptor_cc_proto",
|
||||
@@ -246,10 +257,11 @@ cc_library(
|
||||
hdrs = ["AITimeBudget.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/util:hex_cube_utils",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/util:hex_map_utils",
|
||||
@@ -263,6 +275,7 @@ cc_library(
|
||||
hdrs = ["IterativeDeepeningAI.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
@@ -278,6 +291,24 @@ cc_library(
|
||||
],
|
||||
)
|
||||
|
||||
cc_library(
|
||||
name = "ai_flee_decision_calculator",
|
||||
srcs = ["AIFleeDecisionCalculator.cpp"],
|
||||
hdrs = ["AIFleeDecisionCalculator.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = [
|
||||
"//src/main/cpp/net/eagle0/shardok/ai_performance_runner:__pkg__",
|
||||
"//src/test/cpp/net/eagle0/shardok/ai:__pkg__",
|
||||
],
|
||||
deps = [
|
||||
":ai_score_utilities",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:engine",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/util:hex_map_utils",
|
||||
"//src/main/protobuf/net/eagle0/shardok/api:command_descriptor_cc_proto",
|
||||
],
|
||||
)
|
||||
|
||||
cc_library(
|
||||
name = "shardok_ai_client",
|
||||
srcs = ["ShardokAIClient.cpp"],
|
||||
@@ -287,6 +318,7 @@ cc_library(
|
||||
deps = [
|
||||
":ai_attacker_strategy_selector",
|
||||
":ai_defender_strategy_selector",
|
||||
":ai_flee_decision_calculator",
|
||||
":ai_iterative_deepening",
|
||||
":ai_score_calculator",
|
||||
":ai_time_budget",
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
#include "IterativeDeepeningAI.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include <limits>
|
||||
#include <numeric>
|
||||
#include <utility>
|
||||
|
||||
@@ -39,6 +40,7 @@ auto IterativeDeepeningAI::IterativeSearch(
|
||||
// Make a mutable copy of the time budget to track remaining time
|
||||
AITimeBudget timeBudget = initialBudget;
|
||||
const auto startTime = std::chrono::steady_clock::now();
|
||||
const auto initialBudgetMs = initialBudget.remainingBudget;
|
||||
SearchResult result;
|
||||
|
||||
if (commands.empty()) {
|
||||
@@ -49,6 +51,12 @@ auto IterativeDeepeningAI::IterativeSearch(
|
||||
return result;
|
||||
}
|
||||
|
||||
// Check if we're in SET_UP phase
|
||||
bool isSetupPhase =
|
||||
(state->status()->state() ==
|
||||
net::eagle0::shardok::storage::fb::GameStatus_::State_SET_UP);
|
||||
int maxDepth = isSetupPhase ? 2 : std::numeric_limits<int>::max();
|
||||
|
||||
// Calculate current utility and create engine once for all command evaluations
|
||||
const auto& settingsGetter = settings->GetGetter();
|
||||
const auto guessedEngine = ShardokEngine(settings, state);
|
||||
@@ -62,160 +70,178 @@ auto IterativeDeepeningAI::IterativeSearch(
|
||||
apdCache,
|
||||
alCache);
|
||||
|
||||
// Step 1: Evaluate ALL commands at depth 1 - reuse vector to reduce allocations
|
||||
reusableDepth1Results.clear();
|
||||
reusableDepth1Results.reserve(commands.size());
|
||||
// Initialize data structures for tracking scores at each depth
|
||||
scoresByDepth.clear();
|
||||
scoresByDepth.resize(commands.size());
|
||||
highestDepthCompleted.clear();
|
||||
highestDepthCompleted.resize(commands.size(), 0);
|
||||
|
||||
for (size_t i = 0; i < commands.size(); ++i) {
|
||||
if (IsTimeExpired(timeBudget)) {
|
||||
int currentDepth = 1;
|
||||
size_t previousBestCommand = 0; // Track best command from previous depth
|
||||
size_t evaluatedCountAtHighestDepth = 0;
|
||||
EvaluationCompletionReason completionReason = EvaluationCompletionReason::RAN_OUT_OF_TIME;
|
||||
|
||||
// Main iterative deepening loop
|
||||
while ((currentDepth == 1 || !IsTimeExpired(timeBudget)) && currentDepth <= maxDepth) {
|
||||
// Get command indices sorted by best score from previous depth
|
||||
std::vector<size_t> sortedIndices = GetCommandsSortedByPreviousDepth(
|
||||
currentDepth,
|
||||
scoresByDepth,
|
||||
highestDepthCompleted);
|
||||
|
||||
int evaluatedCount = 0;
|
||||
bool allEvaluated = true;
|
||||
bool allEndTurnCommands = true; // Track if all commands are END_TURN
|
||||
|
||||
// Try to evaluate all commands at this depth, within budget constraints
|
||||
for (size_t cmdIndex : sortedIndices) {
|
||||
if (currentDepth > 1 && IsTimeExpired(timeBudget)) {
|
||||
allEvaluated = false;
|
||||
break;
|
||||
}
|
||||
|
||||
auto cmdResult = SearchCommandAtDepthWithEngine(
|
||||
guessedEngine,
|
||||
settingsGetter,
|
||||
maxRepeatCount,
|
||||
commands,
|
||||
cmdIndex,
|
||||
currentDepth,
|
||||
currentUtility,
|
||||
timeBudget);
|
||||
|
||||
// Ensure scoresByDepth[cmdIndex] has enough space
|
||||
if (scoresByDepth[cmdIndex].size() <= currentDepth) {
|
||||
scoresByDepth[cmdIndex].resize(currentDepth + 1);
|
||||
}
|
||||
scoresByDepth[cmdIndex][currentDepth] = cmdResult.bestScore;
|
||||
highestDepthCompleted[cmdIndex] = currentDepth;
|
||||
evaluatedCount++;
|
||||
|
||||
// Check if this command is not END_TURN_COMMAND
|
||||
if (commands[cmdIndex].type() != net::eagle0::shardok::common::END_TURN_COMMAND) {
|
||||
allEndTurnCommands = false;
|
||||
}
|
||||
}
|
||||
|
||||
// Find the best command at current depth and check if it changed
|
||||
if (evaluatedCount > 0) {
|
||||
evaluatedCountAtHighestDepth = evaluatedCount;
|
||||
size_t currentBestCommand = 0;
|
||||
ScoreValue currentBestScore = -std::numeric_limits<ScoreValue>::infinity();
|
||||
|
||||
for (size_t i = 0; i < commands.size(); ++i) {
|
||||
if (highestDepthCompleted[i] >= currentDepth) {
|
||||
if (scoresByDepth[i][currentDepth] > currentBestScore) {
|
||||
currentBestScore = scoresByDepth[i][currentDepth];
|
||||
currentBestCommand = i;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Log if best command changed from previous depth
|
||||
if (currentDepth > 1 && currentBestCommand != previousBestCommand) {
|
||||
#if DEBUG_ITERATIVE_DEEPENING_TIMINGS
|
||||
printf("ID AI: Time expired during depth 1 evaluation at command %zu\n", i);
|
||||
printf("ID AI: Best command changed at depth %d:\n", currentDepth);
|
||||
printf(" Depth %d best: command %zu (score %.2f) - %s\n",
|
||||
currentDepth - 1,
|
||||
previousBestCommand,
|
||||
scoresByDepth[previousBestCommand][currentDepth - 1],
|
||||
commands[previousBestCommand].DebugString().c_str());
|
||||
printf(" Depth %d best: command %zu (score %.2f) - %s\n",
|
||||
currentDepth,
|
||||
currentBestCommand,
|
||||
currentBestScore,
|
||||
commands[currentBestCommand].DebugString().c_str());
|
||||
#endif
|
||||
}
|
||||
|
||||
previousBestCommand = currentBestCommand;
|
||||
}
|
||||
|
||||
// Only proceed to next depth if we completed all commands at current depth
|
||||
if (!allEvaluated) {
|
||||
completionReason = EvaluationCompletionReason::RAN_OUT_OF_TIME;
|
||||
break;
|
||||
}
|
||||
|
||||
auto commandResult = SearchCommandAtDepthWithEngine(
|
||||
guessedEngine,
|
||||
settingsGetter,
|
||||
maxRepeatCount,
|
||||
commands,
|
||||
i,
|
||||
1,
|
||||
currentUtility,
|
||||
timeBudget);
|
||||
reusableDepth1Results.push_back(commandResult);
|
||||
}
|
||||
|
||||
if (reusableDepth1Results.empty()) {
|
||||
#if DEBUG_ITERATIVE_DEEPENING_TIMINGS
|
||||
printf("ID AI: No depth 1 results, returning default\n");
|
||||
#endif
|
||||
result.searchCompleted = false;
|
||||
return result;
|
||||
}
|
||||
|
||||
// Step 2: Sort commands by depth-1 scores (highest first) - reuse vector
|
||||
reusableSortedIndices.clear();
|
||||
reusableSortedIndices.resize(reusableDepth1Results.size());
|
||||
std::iota(reusableSortedIndices.begin(), reusableSortedIndices.end(), 0);
|
||||
|
||||
std::ranges::sort(reusableSortedIndices, [this](const size_t a, const size_t b) {
|
||||
return reusableDepth1Results[a].bestScore > reusableDepth1Results[b].bestScore;
|
||||
});
|
||||
|
||||
// Best result starts with the highest-scoring depth-1 command - use reference to avoid copy
|
||||
const SearchResult& bestDepth1ResultRef = reusableDepth1Results[reusableSortedIndices[0]];
|
||||
SearchResult bestDepth1Result = bestDepth1ResultRef; // Copy only when we need to modify
|
||||
bestDepth1Result.depthAchieved = 1;
|
||||
bestDepth1Result.minimumDepthCompleted = 1 >= timeBudget.minDepthRequired;
|
||||
|
||||
// Step 3: Selectively evaluate individual commands at depth 2
|
||||
int depth2CompletedCount = 0;
|
||||
SearchResult bestDepth2Result;
|
||||
bestDepth2Result.searchCompleted = false;
|
||||
|
||||
for (const unsigned long commandIndex : reusableSortedIndices) {
|
||||
if (IsTimeExpired(timeBudget)) { break; }
|
||||
|
||||
auto depth2Result = SearchCommandAtDepthWithEngine(
|
||||
guessedEngine,
|
||||
settingsGetter,
|
||||
maxRepeatCount,
|
||||
commands,
|
||||
commandIndex,
|
||||
2,
|
||||
currentUtility,
|
||||
timeBudget);
|
||||
|
||||
depth2CompletedCount++;
|
||||
|
||||
// Keep the best depth-2 result
|
||||
if (depth2CompletedCount == 1 || (depth2Result.bestScore > bestDepth2Result.bestScore)) {
|
||||
depth2Result.depthAchieved = 2;
|
||||
depth2Result.minimumDepthCompleted = 2 >= timeBudget.minDepthRequired;
|
||||
bestDepth2Result = depth2Result;
|
||||
// Stop if all evaluated commands were END_TURN at the root - no point going deeper
|
||||
if (allEndTurnCommands && evaluatedCount > 0) {
|
||||
completionReason = EvaluationCompletionReason::RAN_OUT_OF_COMMANDS;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
printf("ID AI: Successfully completed %d depth-2 evaluations (out of %lu commands)\n",
|
||||
depth2CompletedCount,
|
||||
commands.size());
|
||||
// Also check if scores haven't changed from previous depth
|
||||
// This indicates we've hit END_TURN in the lookahead
|
||||
if (currentDepth > 1 && evaluatedCount > 0) {
|
||||
bool scoresUnchanged = true;
|
||||
int unchangedCount = 0;
|
||||
|
||||
// Step 4: Choose final result
|
||||
if (depth2CompletedCount) {
|
||||
#if DEBUG_ITERATIVE_DEEPENING_TIMINGS
|
||||
if (bestDepth2Result.bestCommandIndex != bestDepth1Result.bestCommandIndex) {
|
||||
printf("ID AI: Best depth-2 command differs from depth-1: \n");
|
||||
printf(" depth-2 command %zu, depth-1 command %zu\n",
|
||||
bestDepth2Result.bestCommandIndex,
|
||||
bestDepth1Result.bestCommandIndex);
|
||||
printf("depth 1 command: %s\n",
|
||||
commands[bestDepth1Result.bestCommandIndex].DebugString().c_str());
|
||||
printf("depth 2 command: %s\n",
|
||||
commands[bestDepth2Result.bestCommandIndex].DebugString().c_str());
|
||||
for (size_t i = 0; i < sortedIndices.size() && i < evaluatedCount; ++i) {
|
||||
size_t cmdIndex = sortedIndices[i];
|
||||
// This command was evaluated at both current and previous depth
|
||||
if (scoresByDepth[cmdIndex].size() > currentDepth &&
|
||||
scoresByDepth[cmdIndex].size() > currentDepth - 1) {
|
||||
// Check if score changed between depth N-1 and depth N
|
||||
if (std::abs(
|
||||
scoresByDepth[cmdIndex][currentDepth] -
|
||||
scoresByDepth[cmdIndex][currentDepth - 1]) < 1e-9) {
|
||||
unchangedCount++;
|
||||
} else {
|
||||
scoresUnchanged = false;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// If all evaluated commands had unchanged scores, we've hit END_TURN in lookahead
|
||||
if (scoresUnchanged && unchangedCount == evaluatedCount) {
|
||||
completionReason = EvaluationCompletionReason::RAN_OUT_OF_COMMANDS;
|
||||
break;
|
||||
}
|
||||
}
|
||||
#endif
|
||||
result = bestDepth2Result;
|
||||
} else {
|
||||
result = bestDepth1Result; // Fall back to best depth-1 result
|
||||
#if DEBUG_ITERATIVE_DEEPENING_TIMINGS
|
||||
printf("ID AI: Falling back to best depth-1 result\n");
|
||||
#endif
|
||||
|
||||
// Check if we've used more than 50% of total budget
|
||||
auto totalElapsed = std::chrono::steady_clock::now() - startTime;
|
||||
auto totalElapsedMs = std::chrono::duration_cast<std::chrono::milliseconds>(totalElapsed);
|
||||
double budgetUsedPercent = (double)totalElapsedMs.count() / initialBudgetMs.count();
|
||||
|
||||
if (budgetUsedPercent > 0.5) {
|
||||
printf("ID AI: Stopping after depth %d - used %.1f%% of time budget\n",
|
||||
currentDepth,
|
||||
budgetUsedPercent * 100);
|
||||
completionReason = EvaluationCompletionReason::NOT_ENOUGH_TIME_TO_CONTINUE;
|
||||
break;
|
||||
}
|
||||
|
||||
currentDepth++;
|
||||
}
|
||||
|
||||
// If we completed the loop without any breaks, we successfully exhausted meaningful search
|
||||
if (completionReason == EvaluationCompletionReason::RAN_OUT_OF_TIME &&
|
||||
currentDepth > maxDepth) {
|
||||
// We hit the depth limit rather than running out of time
|
||||
completionReason = EvaluationCompletionReason::RAN_OUT_OF_COMMANDS;
|
||||
}
|
||||
|
||||
// Select best result from highest depth achieved for each command
|
||||
result = SelectBestResult(scoresByDepth, highestDepthCompleted);
|
||||
result.minimumDepthCompleted = result.depthAchieved >= timeBudget.minDepthRequired;
|
||||
result.searchCompleted = result.minimumDepthCompleted;
|
||||
result.timeUsed = std::chrono::duration_cast<std::chrono::milliseconds>(
|
||||
std::chrono::steady_clock::now() - startTime);
|
||||
result.availableCommandCount = commands.size();
|
||||
result.commandCountEvaluated = evaluatedCountAtHighestDepth;
|
||||
result.completionReason = completionReason;
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
auto IterativeDeepeningAI::SearchAtDepth(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& state,
|
||||
const std::vector<CommandProto>& commands,
|
||||
const int depth) const -> SearchResult {
|
||||
SearchResult result;
|
||||
|
||||
#if DEBUG_ITERATIVE_DEEPENING_TIMINGS
|
||||
printf("SearchAtDepth: depth=%d, commands=%zu\n", depth, commands.size());
|
||||
#endif
|
||||
|
||||
if (commands.empty()) {
|
||||
result.searchCompleted = true;
|
||||
return result;
|
||||
// Validation: if completion reason is RAN_OUT_OF_COMMANDS, evaluation should be 100%
|
||||
if (completionReason == EvaluationCompletionReason::RAN_OUT_OF_COMMANDS &&
|
||||
result.commandCountEvaluated < result.availableCommandCount) {
|
||||
printf("ERROR: Completion reason RAN_OUT_OF_COMMANDS but evaluation %lu/%zu < 100%%\n",
|
||||
result.commandCountEvaluated,
|
||||
result.availableCommandCount);
|
||||
}
|
||||
|
||||
const auto& settingsGetter = settings->GetGetter();
|
||||
const auto guessedEngine = ShardokEngine(settings, state);
|
||||
const auto maxRepeatCount = settingsGetter.Backing().ai_utility_repeat_count();
|
||||
const ScoreValue currentUtility = AIScoreCalculator::GuessedStateScore(
|
||||
isDefender,
|
||||
state,
|
||||
strategy,
|
||||
castleCoords,
|
||||
settingsGetter,
|
||||
apdCache,
|
||||
alCache);
|
||||
|
||||
// Perform search at specified depth
|
||||
const auto indexAndScore = AIScoreCalculator::BestCommandIndex(
|
||||
playerId,
|
||||
isDefender,
|
||||
depth, // Use the specified depth for lookahead
|
||||
maxRepeatCount,
|
||||
guessedEngine,
|
||||
strategy,
|
||||
currentUtility,
|
||||
settingsGetter,
|
||||
castleCoords,
|
||||
apdCache,
|
||||
alCache);
|
||||
|
||||
result.bestCommandIndex = indexAndScore.index;
|
||||
result.bestScore = indexAndScore.lookaheadScore;
|
||||
result.searchCompleted = true;
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
@@ -223,38 +249,6 @@ bool IterativeDeepeningAI::IsTimeExpired(const AITimeBudget& budget) {
|
||||
return budget.remainingBudget <= std::chrono::milliseconds(0);
|
||||
}
|
||||
|
||||
auto IterativeDeepeningAI::SearchAllCommandsAtDepth(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& state,
|
||||
const std::vector<CommandProto>& commands,
|
||||
const int depth) const -> std::vector<SearchResult> {
|
||||
// Use SearchAtDepth to get the best overall result
|
||||
const auto bestResult = SearchAtDepth(settings, state, commands, depth);
|
||||
|
||||
std::vector<SearchResult> results;
|
||||
results.reserve(commands.size());
|
||||
|
||||
for (size_t i = 0; i < commands.size(); ++i) {
|
||||
SearchResult result;
|
||||
result.bestCommandIndex = i;
|
||||
result.depthAchieved = depth;
|
||||
result.searchCompleted = true;
|
||||
result.minimumDepthCompleted = true;
|
||||
|
||||
// For the best command, use the actual score
|
||||
// For others, use a slightly lower score (this is a simplification for Phase 2)
|
||||
if (i == bestResult.bestCommandIndex) {
|
||||
result.bestScore = bestResult.bestScore;
|
||||
} else {
|
||||
result.bestScore = bestResult.bestScore * 0.95; // Slightly lower but reasonable
|
||||
}
|
||||
|
||||
results.push_back(result);
|
||||
}
|
||||
|
||||
return results;
|
||||
}
|
||||
|
||||
auto IterativeDeepeningAI::SearchCommandAtDepthWithEngine(
|
||||
const ShardokEngine& guessedEngine,
|
||||
const GameSettings::Getter& settingsGetter,
|
||||
@@ -269,6 +263,8 @@ auto IterativeDeepeningAI::SearchCommandAtDepthWithEngine(
|
||||
result.depthAchieved = depth;
|
||||
result.searchCompleted = true;
|
||||
result.minimumDepthCompleted = true;
|
||||
result.availableCommandCount = commands.size();
|
||||
result.commandCountEvaluated = 1; // We're evaluating just this command
|
||||
|
||||
if (commandIndex >= commands.size()) {
|
||||
result.bestScore = 0.0;
|
||||
@@ -317,4 +313,53 @@ auto IterativeDeepeningAI::SearchCommandAtDepthWithEngine(
|
||||
return result;
|
||||
}
|
||||
|
||||
auto IterativeDeepeningAI::GetCommandsSortedByPreviousDepth(
|
||||
int currentDepth,
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) const -> std::vector<size_t> {
|
||||
std::vector<size_t> indices(scoresByDepth.size());
|
||||
std::iota(indices.begin(), indices.end(), 0);
|
||||
|
||||
if (currentDepth == 1) {
|
||||
// For depth 1, return natural order
|
||||
return indices;
|
||||
}
|
||||
|
||||
// Sort by score at previous depth
|
||||
int prevDepth = currentDepth - 1;
|
||||
std::sort(indices.begin(), indices.end(), [&](size_t a, size_t b) {
|
||||
// Only consider commands that were evaluated at previous depth
|
||||
if (highestDepthCompleted[a] >= prevDepth && highestDepthCompleted[b] >= prevDepth) {
|
||||
return scoresByDepth[a][prevDepth] > scoresByDepth[b][prevDepth];
|
||||
}
|
||||
// Commands not evaluated at prev depth go to the end
|
||||
return highestDepthCompleted[a] >= prevDepth;
|
||||
});
|
||||
|
||||
return indices;
|
||||
}
|
||||
|
||||
auto IterativeDeepeningAI::SelectBestResult(
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) const -> SearchResult {
|
||||
SearchResult result;
|
||||
result.bestScore = -std::numeric_limits<ScoreValue>::infinity();
|
||||
result.searchCompleted = false;
|
||||
|
||||
// Find the command with best score at its highest evaluated depth
|
||||
for (size_t i = 0; i < scoresByDepth.size(); ++i) {
|
||||
if (highestDepthCompleted[i] > 0) {
|
||||
int depth = highestDepthCompleted[i];
|
||||
ScoreValue score = scoresByDepth[i][depth];
|
||||
if (score > result.bestScore) {
|
||||
result.bestScore = score;
|
||||
result.bestCommandIndex = i;
|
||||
result.depthAchieved = depth;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
} // namespace shardok
|
||||
@@ -23,6 +23,13 @@ class ShardokEngine;
|
||||
using ScoreValue = double;
|
||||
using CommandProto = net::eagle0::shardok::api::CommandDescriptor;
|
||||
|
||||
/// Reason why AI evaluation completed at the achieved depth.
|
||||
enum class EvaluationCompletionReason {
|
||||
RAN_OUT_OF_COMMANDS, ///< All remaining commands were trivial (e.g., END_TURN)
|
||||
RAN_OUT_OF_TIME, ///< Time budget was exhausted with meaningful commands remaining
|
||||
NOT_ENOUGH_TIME_TO_CONTINUE ///< Insufficient time budget to start next depth iteration
|
||||
};
|
||||
|
||||
class IterativeDeepeningAI {
|
||||
public:
|
||||
struct SearchResult {
|
||||
@@ -32,6 +39,9 @@ public:
|
||||
std::chrono::milliseconds timeUsed;
|
||||
bool minimumDepthCompleted;
|
||||
bool searchCompleted;
|
||||
size_t availableCommandCount;
|
||||
size_t commandCountEvaluated;
|
||||
EvaluationCompletionReason completionReason;
|
||||
|
||||
SearchResult()
|
||||
: bestCommandIndex(0),
|
||||
@@ -39,7 +49,10 @@ public:
|
||||
depthAchieved(0),
|
||||
timeUsed(0),
|
||||
minimumDepthCompleted(false),
|
||||
searchCompleted(false) {}
|
||||
searchCompleted(false),
|
||||
availableCommandCount(0),
|
||||
commandCountEvaluated(0),
|
||||
completionReason(EvaluationCompletionReason::RAN_OUT_OF_TIME) {}
|
||||
};
|
||||
|
||||
IterativeDeepeningAI(
|
||||
@@ -65,23 +78,12 @@ private:
|
||||
const ALCache& alCache;
|
||||
|
||||
// Reusable vectors to reduce memory allocations
|
||||
mutable std::vector<SearchResult> reusableDepth1Results;
|
||||
mutable std::vector<std::vector<ScoreValue>> scoresByDepth;
|
||||
mutable std::vector<int> highestDepthCompleted;
|
||||
mutable std::vector<size_t> reusableSortedIndices;
|
||||
|
||||
[[nodiscard]] SearchResult SearchAtDepth(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& state,
|
||||
const std::vector<CommandProto>& commands,
|
||||
int depth) const;
|
||||
|
||||
[[nodiscard]] static bool IsTimeExpired(const AITimeBudget& budget);
|
||||
|
||||
[[nodiscard]] std::vector<SearchResult> SearchAllCommandsAtDepth(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& state,
|
||||
const std::vector<CommandProto>& commands,
|
||||
int depth) const;
|
||||
|
||||
[[nodiscard]] SearchResult SearchCommandAtDepthWithEngine(
|
||||
const ShardokEngine& guessedEngine,
|
||||
const GameSettings::Getter& settingsGetter,
|
||||
@@ -91,6 +93,15 @@ private:
|
||||
int depth,
|
||||
ScoreValue currentUtility,
|
||||
AITimeBudget& timeBudget) const;
|
||||
|
||||
[[nodiscard]] std::vector<size_t> GetCommandsSortedByPreviousDepth(
|
||||
int currentDepth,
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) const;
|
||||
|
||||
[[nodiscard]] SearchResult SelectBestResult(
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) const;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
@@ -8,10 +8,14 @@
|
||||
|
||||
#include "ShardokAIClient.hpp"
|
||||
|
||||
#define DEBUG_FLEE_DECISIONS
|
||||
|
||||
#include <google/protobuf/util/message_differencer.h>
|
||||
|
||||
#include "AIAttackerStrategySelector.hpp"
|
||||
#include "AIDefenderStrategySelector.hpp"
|
||||
#include "AIFleeDecisionCalculator.hpp"
|
||||
#include "AIScoreUtilities.hpp"
|
||||
#include "AITimeBudget.hpp"
|
||||
#include "IterativeDeepeningAI.hpp"
|
||||
#include "src/main/cpp/net/eagle0/common/TimeUtils.hpp"
|
||||
@@ -21,11 +25,11 @@
|
||||
|
||||
namespace shardok {
|
||||
|
||||
static constexpr bool kDebugTimings = true;
|
||||
|
||||
using net::eagle0::shardok::api::ActionResultView;
|
||||
using net::eagle0::shardok::api::GameStateView;
|
||||
|
||||
static constexpr bool kPerformanceLogging = true;
|
||||
|
||||
void ApplyUpdate(GameStateView ¤tView, const ActionResultView &update) {}
|
||||
|
||||
auto RoundsRemaining(const GameSettingsSPtr &settings, const GameStateView &gsv) -> int {
|
||||
@@ -42,7 +46,29 @@ ShardokAIClient::ShardokAIClient(
|
||||
: playerId(playerId),
|
||||
isDefender(isDefender),
|
||||
alCache(std::make_unique<AttackLocationsCache>(hexMap, settings)),
|
||||
waterCrossingCommandChooser(playerId, apdCache) {}
|
||||
waterCrossingCommandChooser(playerId, apdCache) {
|
||||
// Pre-generate the most common cache entries for better performance
|
||||
const auto mapId = ActionPointDistancesCache::GetMapId(hexMap);
|
||||
|
||||
// Pre-fetch for all battalion types, both with and without brave water
|
||||
using BattalionTypeId = net::eagle0::shardok::storage::fb::BattalionTypeId;
|
||||
|
||||
for (int typeId = BattalionTypeId::BattalionTypeId_MIN;
|
||||
typeId <= BattalionTypeId::BattalionTypeId_MAX;
|
||||
typeId++) {
|
||||
const auto battalionTypeId = static_cast<BattalionTypeId>(typeId);
|
||||
const auto battalionType = settings.GetBattalionType(battalionTypeId);
|
||||
|
||||
// Pre-fetch without brave water (braveWaterActionPointCost = -1)
|
||||
apdCache->GetRaw(hexMap, mapId, battalionType, false, -1);
|
||||
|
||||
// Pre-fetch with brave water (includeBravingWater = true, braveWaterActionPointCost = 0)
|
||||
apdCache->GetRaw(hexMap, mapId, battalionType, true, 0);
|
||||
}
|
||||
|
||||
// Consolidate all the pre-fetched entries into the persistent cache
|
||||
apdCache->ConsolidateThreadLocalCache_Racy();
|
||||
}
|
||||
|
||||
void CheckCommand(const CommandProto &realDescriptor, const CommandProto &guessedDescriptor) {
|
||||
string diff;
|
||||
@@ -63,7 +89,7 @@ void CheckCommand(const CommandProto &realDescriptor, const CommandProto &guesse
|
||||
auto ShardokAIClient::StandardChooseCommandIndex(
|
||||
const GameSettingsSPtr &settings,
|
||||
const GameStateW &guessedState,
|
||||
const vector<CommandProto> &realAvailableCommands) const -> size_t {
|
||||
const vector<CommandProto> &realAvailableCommands) const -> CommandChoiceResults {
|
||||
const auto settingsGetter = settings->GetGetter();
|
||||
const auto guessedEngine = ShardokEngine(settings, guessedState);
|
||||
|
||||
@@ -101,13 +127,34 @@ auto ShardokAIClient::StandardChooseCommandIndex(
|
||||
auto search_result =
|
||||
iterativeAI.IterativeSearch(settings, guessedState, realAvailableCommands, timeBudget);
|
||||
|
||||
return search_result.bestCommandIndex;
|
||||
CommandChoiceResults result{};
|
||||
result.chosenIndex = search_result.bestCommandIndex;
|
||||
result.availableCommandCount = search_result.availableCommandCount;
|
||||
result.depthAchieved = search_result.depthAchieved;
|
||||
result.commandCountEvaluated = search_result.commandCountEvaluated;
|
||||
result.completionReason = search_result.completionReason;
|
||||
|
||||
if constexpr (kPerformanceLogging) {
|
||||
if (result.commandCountEvaluated < result.availableCommandCount) {
|
||||
printf("ID AI: Depth %d - evaluated %lu/%zu commands\n",
|
||||
result.depthAchieved,
|
||||
result.commandCountEvaluated,
|
||||
result.availableCommandCount);
|
||||
}
|
||||
printf("ID AI: Search complete - achieved depth %d for best command %zu\n",
|
||||
result.depthAchieved,
|
||||
result.chosenIndex);
|
||||
|
||||
fflush(stdout);
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
auto ShardokAIClient::LateRoundAttackerChooseCommandIndex(
|
||||
const GameSettingsSPtr &settings,
|
||||
const GameStateW &guessedState,
|
||||
const vector<CommandProto> &realAvailableCommands) const -> size_t {
|
||||
const vector<CommandProto> &realAvailableCommands) const -> CommandChoiceResults {
|
||||
if (const auto dismissCommand = std::ranges::find_if(
|
||||
realAvailableCommands,
|
||||
[](const net::eagle0::shardok::api::CommandDescriptor &cmd) {
|
||||
@@ -116,49 +163,83 @@ auto ShardokAIClient::LateRoundAttackerChooseCommandIndex(
|
||||
dismissCommand == realAvailableCommands.end()) {
|
||||
return StandardChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
} else {
|
||||
return static_cast<size_t>(std::distance(realAvailableCommands.begin(), dismissCommand));
|
||||
CommandChoiceResults results{};
|
||||
results.chosenIndex =
|
||||
static_cast<size_t>(std::distance(realAvailableCommands.begin(), dismissCommand));
|
||||
results.availableCommandCount = realAvailableCommands.size();
|
||||
results.depthAchieved = 1; // Simple heuristic choice
|
||||
results.commandCountEvaluated = 1; // Only evaluated one command type
|
||||
results.completionReason =
|
||||
EvaluationCompletionReason::RAN_OUT_OF_COMMANDS; // Heuristic choice
|
||||
return results;
|
||||
}
|
||||
}
|
||||
|
||||
auto ShardokAIClient::FinalRoundAttackerChooseCommandIndex(
|
||||
const GameSettingsSPtr &settings,
|
||||
const GameStateW &guessedState,
|
||||
const vector<CommandProto> &realAvailableCommands) const -> size_t {
|
||||
if (const auto fleeCommand = std::ranges::find_if(
|
||||
realAvailableCommands,
|
||||
[](const net::eagle0::shardok::api::CommandDescriptor &cmd) {
|
||||
return cmd.type() == net::eagle0::shardok::common::FLEE_COMMAND;
|
||||
});
|
||||
fleeCommand == realAvailableCommands.end()) {
|
||||
const vector<CommandProto> &realAvailableCommands) const -> CommandChoiceResults {
|
||||
const auto fleeCommand = std::ranges::find_if(
|
||||
realAvailableCommands,
|
||||
[](const net::eagle0::shardok::api::CommandDescriptor &cmd) {
|
||||
return cmd.type() == net::eagle0::shardok::common::FLEE_COMMAND;
|
||||
});
|
||||
|
||||
if (fleeCommand == realAvailableCommands.end()) {
|
||||
return LateRoundAttackerChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
}
|
||||
|
||||
// Use the flee decision calculator
|
||||
const auto fleeDecision = AIFleeDecisionCalculator::EvaluateFleeVsFight(
|
||||
playerId,
|
||||
settings,
|
||||
guessedState,
|
||||
realAvailableCommands,
|
||||
fleeCommand,
|
||||
#ifdef DEBUG_FLEE_DECISIONS
|
||||
true // Enable debug logging
|
||||
#else
|
||||
false
|
||||
#endif
|
||||
);
|
||||
|
||||
if (fleeDecision.shouldFlee) {
|
||||
CommandChoiceResults results{};
|
||||
results.chosenIndex = fleeDecision.commandIndex;
|
||||
results.availableCommandCount = realAvailableCommands.size();
|
||||
results.depthAchieved = 1; // Heuristic choice
|
||||
results.commandCountEvaluated = 1; // Only evaluated one command type
|
||||
results.completionReason = EvaluationCompletionReason::RAN_OUT_OF_COMMANDS;
|
||||
return results;
|
||||
} else {
|
||||
return static_cast<size_t>(std::distance(realAvailableCommands.begin(), fleeCommand));
|
||||
// Fight instead of flee
|
||||
return StandardChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
}
|
||||
}
|
||||
|
||||
auto ShardokAIClient::ChooseCommandIndex(
|
||||
const GameSettingsSPtr &settings,
|
||||
const GameStateView &gsv,
|
||||
const vector<CommandProto> &realAvailableCommands) const -> size_t {
|
||||
const vector<CommandProto> &realAvailableCommands) const -> CommandChoiceResults {
|
||||
static int typeChosenCount[net::eagle0::shardok::common::CommandType_MAX + 1];
|
||||
static int totalChoices = 0;
|
||||
|
||||
size_t chosenIndex;
|
||||
CommandChoiceResults results{};
|
||||
|
||||
const auto guessedState = GameStateGuesser::GuessedState(playerId, settings->GetGetter(), gsv);
|
||||
|
||||
if (const int roundsRemaining = RoundsRemaining(settings, gsv);
|
||||
!isDefender && roundsRemaining <= 1) {
|
||||
chosenIndex =
|
||||
results =
|
||||
FinalRoundAttackerChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
} else if (!isDefender && roundsRemaining <= 3) {
|
||||
chosenIndex =
|
||||
results =
|
||||
LateRoundAttackerChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
} else {
|
||||
chosenIndex = StandardChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
results = StandardChooseCommandIndex(settings, guessedState, realAvailableCommands);
|
||||
}
|
||||
|
||||
const auto chosenType = realAvailableCommands[chosenIndex].type();
|
||||
const auto chosenType = realAvailableCommands[results.chosenIndex].type();
|
||||
typeChosenCount[static_cast<int>(chosenType)]++;
|
||||
totalChoices++;
|
||||
|
||||
@@ -179,12 +260,11 @@ auto ShardokAIClient::ChooseCommandIndex(
|
||||
printf("\n\n");
|
||||
}
|
||||
|
||||
return chosenIndex;
|
||||
return results;
|
||||
}
|
||||
|
||||
auto ShardokAIClient::ChooseCommandIndex(const ShardokEngine &engine) const -> size_t {
|
||||
const auto startTimeMicros = CurrentTimeMicros();
|
||||
|
||||
auto ShardokAIClient::ChooseCommandIndex(const ShardokEngine &engine) const
|
||||
-> CommandChoiceResults {
|
||||
if (const auto &availableCommands = engine.GetAvailableCommandProtos(playerId, false);
|
||||
availableCommands.empty()) {
|
||||
printf("no commands for player %d\n", playerId);
|
||||
@@ -194,15 +274,9 @@ auto ShardokAIClient::ChooseCommandIndex(const ShardokEngine &engine) const -> s
|
||||
const auto &settings = engine.GetGameSettings();
|
||||
const auto &gsv = engine.GetGameStateView(GetPlayerId());
|
||||
|
||||
const size_t chosenIndex = ChooseCommandIndex(settings, gsv, availableCommands);
|
||||
const auto elapsedMicros = CurrentTimeMicros() - startTimeMicros;
|
||||
|
||||
if (kDebugTimings) {
|
||||
std::cerr << "Milliseconds to choose command index: " << elapsedMicros / 1000
|
||||
<< std::endl;
|
||||
}
|
||||
|
||||
return chosenIndex;
|
||||
const auto results = ChooseCommandIndex(settings, gsv, availableCommands);
|
||||
apdCache->ConsolidateThreadLocalCache_Racy();
|
||||
return results;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -15,12 +15,22 @@
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIScoreCalculator.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AITimeBudget.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/AIWaterCrossingCommandChooser.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/IterativeDeepeningAI.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/api/game_state_view.pb.h"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using VictoryCondition = net::eagle0::shardok::storage::fb::VictoryCondition;
|
||||
|
||||
/// Results from AI command selection, including performance metrics.
|
||||
struct CommandChoiceResults {
|
||||
size_t chosenIndex; ///< Index of the chosen command in the available commands list
|
||||
size_t availableCommandCount; ///< Total number of commands that were available to choose from
|
||||
int depthAchieved; ///< Maximum search depth reached for the best command
|
||||
size_t commandCountEvaluated; ///< Number of commands evaluated at the highest achieved depth
|
||||
EvaluationCompletionReason completionReason; ///< Why evaluation stopped at this depth
|
||||
};
|
||||
|
||||
//
|
||||
// A ShardokGameClient representing an AI player.
|
||||
//
|
||||
@@ -37,19 +47,20 @@ private:
|
||||
[[nodiscard]] auto StandardChooseCommandIndex(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& guessedState,
|
||||
const vector<CommandProto>& realAvailableCommands) const -> size_t;
|
||||
const vector<CommandProto>& realAvailableCommands) const -> CommandChoiceResults;
|
||||
[[nodiscard]] auto LateRoundAttackerChooseCommandIndex(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& guessedState,
|
||||
const vector<CommandProto>& realAvailableCommands) const -> size_t;
|
||||
const vector<CommandProto>& realAvailableCommands) const -> CommandChoiceResults;
|
||||
[[nodiscard]] auto FinalRoundAttackerChooseCommandIndex(
|
||||
const GameSettingsSPtr& settings,
|
||||
const GameStateW& guessedState,
|
||||
const vector<CommandProto>& realAvailableCommands) const -> size_t;
|
||||
const vector<CommandProto>& realAvailableCommands) const -> CommandChoiceResults;
|
||||
|
||||
[[nodiscard]] auto ChooseCommandIndex(
|
||||
const GameSettingsSPtr& settings,
|
||||
const net::eagle0::shardok::api::GameStateView& gsv,
|
||||
const vector<CommandProto>& realAvailableCommands) const -> size_t;
|
||||
const vector<CommandProto>& realAvailableCommands) const -> CommandChoiceResults;
|
||||
|
||||
public:
|
||||
explicit ShardokAIClient(
|
||||
@@ -61,7 +72,8 @@ public:
|
||||
|
||||
[[nodiscard]] auto GetPlayerId() const -> PlayerId { return playerId; }
|
||||
|
||||
[[nodiscard]] auto ChooseCommandIndex(const ShardokEngine& engine) const -> size_t;
|
||||
[[nodiscard]] auto ChooseCommandIndex(const ShardokEngine& engine) const
|
||||
-> CommandChoiceResults;
|
||||
};
|
||||
} // namespace shardok
|
||||
|
||||
|
||||
@@ -0,0 +1,296 @@
|
||||
# True Iterative Deepening Implementation
|
||||
|
||||
## Current Status
|
||||
|
||||
### Phase 1: Core Implementation ✅ COMPLETED
|
||||
- ✅ Updated `IterativeDeepeningAI.hpp` with new data structures
|
||||
- ✅ Implemented new `IterativeSearch` function with generalized depth loop
|
||||
- ✅ Added `GetCommandsSortedByPreviousDepth` helper function
|
||||
- ✅ Added `SelectBestResult` helper function
|
||||
- ✅ Implemented 50% budget check to prevent incomplete deep searches
|
||||
- ✅ Added SET_UP phase detection and depth limiting
|
||||
- ✅ Ensured depth 1 always completes regardless of time budget
|
||||
- ✅ Added END_TURN detection to prevent excessive depth exploration
|
||||
- ✅ Implemented command change logging for debugging
|
||||
- ✅ All tests passing
|
||||
|
||||
### Phase 2: Code Cleanup 🚧 PLANNED
|
||||
|
||||
#### Proposed Cleanup Tasks
|
||||
|
||||
1. **Replace Heuristic END_TURN Detection**
|
||||
- Current: Uses score comparison heuristic to detect when lookahead hits END_TURN
|
||||
- Proposed: Modify `AIScoreCalculator` to return explicit `performedLookahead` flag
|
||||
- Benefits: More reliable, cleaner architecture, explicit intent
|
||||
|
||||
2. **Refactor Return Structures**
|
||||
- Add `bool performedLookahead` to `CommandEvaluationResult`
|
||||
- Update `BasicLookaheadCalculator` to track and return lookahead status
|
||||
- Thread this information through the scoring pipeline
|
||||
|
||||
3. **Architecture Improvements**
|
||||
- Consider extracting iterative deepening statistics into a separate class
|
||||
- Improve separation of concerns between search algorithm and scoring
|
||||
|
||||
4. **Performance Optimizations**
|
||||
- Profile memory allocations in deep searches
|
||||
- Consider pre-allocating vectors for very deep searches
|
||||
- Investigate parallel evaluation opportunities at each depth
|
||||
|
||||
### Key Implementation Details
|
||||
|
||||
1. **Data Structure Changes**:
|
||||
- Replaced `reusableDepth1Results` with `scoresByDepth` (2D vector)
|
||||
- Added `highestDepthCompleted` to track the maximum depth achieved per command
|
||||
|
||||
2. **Algorithm Flow**:
|
||||
- Starts at depth 1, evaluates ALL commands regardless of time budget
|
||||
- For each subsequent depth, evaluates commands ordered by previous depth scores
|
||||
- Continues until time expires, all commands at max depth are evaluated, or 50% budget is used
|
||||
- SET_UP phase limits max depth to 2
|
||||
- **Important**: Depth 1 always completes even if time budget is exhausted
|
||||
|
||||
3. **Memory Efficiency**:
|
||||
- Reuses data structures across searches to minimize allocations
|
||||
- Dynamically resizes score vectors as needed
|
||||
|
||||
4. **Command Change Logging**:
|
||||
- Tracks the best command at each depth
|
||||
- Logs when a new depth results in a different best command selection
|
||||
- Provides detailed debug output showing old and new commands with scores
|
||||
|
||||
## Overview
|
||||
|
||||
This document tracks the implementation of true iterative deepening for the Shardok AI, upgrading from a hard-coded 2-depth limit to dynamic depth exploration based on available time budget. The implementation is complete and functional, with planned cleanup tasks for future improvement.
|
||||
|
||||
## Current Implementation
|
||||
|
||||
The current implementation:
|
||||
- Evaluates ALL commands at depth 1
|
||||
- Sorts commands by depth-1 scores
|
||||
- Evaluates commands at depth 2 in sorted order until time expires
|
||||
- Never proceeds beyond depth 2
|
||||
|
||||
## Proposed Implementation
|
||||
|
||||
### Core Algorithm
|
||||
|
||||
The new algorithm will:
|
||||
1. **Depth 1**: Evaluate ALL commands (unchanged)
|
||||
2. **Depth 2+**: For each depth, attempt to evaluate all commands ordered by their scores from the previous depth
|
||||
3. **Completion check**: Only proceed to depth N+1 if all commands at depth N were evaluated
|
||||
4. **50% budget check**: Only proceed to depth N+1 if less than 50% of total time budget has been used
|
||||
5. **SET_UP phase limit**: Limit maximum depth to 2 during the SET_UP game phase
|
||||
|
||||
### Main Loop Pseudocode
|
||||
|
||||
```cpp
|
||||
int currentDepth = 1;
|
||||
bool isSetupPhase = (guessedState->status()->state() == GameStatus_::State_SET_UP);
|
||||
int maxDepth = isSetupPhase ? 2 : std::numeric_limits<int>::max();
|
||||
|
||||
// Track initial budget for percentage calculations
|
||||
const auto initialBudget = timeBudget.remainingBudget;
|
||||
auto startTime = std::chrono::steady_clock::now();
|
||||
|
||||
// Track scores at each depth for each command
|
||||
std::vector<std::vector<ScoreValue>> scoresByDepth(commands.size());
|
||||
std::vector<int> highestDepthCompleted(commands.size(), 0);
|
||||
|
||||
while (!IsTimeExpired(timeBudget) && currentDepth <= maxDepth) {
|
||||
auto depthStartTime = std::chrono::steady_clock::now();
|
||||
|
||||
// Get command indices sorted by best score from previous depth
|
||||
std::vector<size_t> sortedIndices = GetCommandsSortedByPreviousDepth(
|
||||
currentDepth, scoresByDepth, highestDepthCompleted);
|
||||
|
||||
int evaluatedCount = 0;
|
||||
bool allEvaluated = true;
|
||||
|
||||
// Try to evaluate all commands at this depth
|
||||
for (size_t cmdIndex : sortedIndices) {
|
||||
if (IsTimeExpired(timeBudget)) {
|
||||
allEvaluated = false;
|
||||
break;
|
||||
}
|
||||
|
||||
auto result = SearchCommandAtDepthWithEngine(
|
||||
guessedEngine, settingsGetter, maxRepeatCount,
|
||||
commands, cmdIndex, currentDepth, currentUtility, timeBudget);
|
||||
|
||||
scoresByDepth[cmdIndex][currentDepth] = result.bestScore;
|
||||
highestDepthCompleted[cmdIndex] = currentDepth;
|
||||
evaluatedCount++;
|
||||
}
|
||||
|
||||
printf("ID AI: Depth %d - evaluated %d/%zu commands\n",
|
||||
currentDepth, evaluatedCount, commands.size());
|
||||
|
||||
// Only proceed to next depth if we completed all commands at current depth
|
||||
if (!allEvaluated) {
|
||||
printf("ID AI: Stopping - time expired during depth %d\n", currentDepth);
|
||||
break;
|
||||
}
|
||||
|
||||
// Check if we've used more than 50% of total budget
|
||||
auto totalElapsed = std::chrono::steady_clock::now() - startTime;
|
||||
auto totalElapsedMs = std::chrono::duration_cast<std::chrono::milliseconds>(totalElapsed);
|
||||
double budgetUsedPercent = (double)totalElapsedMs.count() / initialBudget.count();
|
||||
|
||||
if (budgetUsedPercent > 0.5) {
|
||||
printf("ID AI: Stopping after depth %d - used %.1f%% of time budget\n",
|
||||
currentDepth, budgetUsedPercent * 100);
|
||||
break;
|
||||
}
|
||||
|
||||
currentDepth++;
|
||||
}
|
||||
|
||||
// Select best result from highest depth achieved for each command
|
||||
SearchResult finalResult = SelectBestResult(scoresByDepth, highestDepthCompleted);
|
||||
```
|
||||
|
||||
### Key Helper Functions
|
||||
|
||||
#### GetCommandsSortedByPreviousDepth
|
||||
|
||||
Sort commands by their scores at the previous depth:
|
||||
|
||||
```cpp
|
||||
std::vector<size_t> GetCommandsSortedByPreviousDepth(
|
||||
int currentDepth,
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) {
|
||||
|
||||
std::vector<size_t> indices(scoresByDepth.size());
|
||||
std::iota(indices.begin(), indices.end(), 0);
|
||||
|
||||
if (currentDepth == 1) {
|
||||
// For depth 1, return natural order
|
||||
return indices;
|
||||
}
|
||||
|
||||
// Sort by score at previous depth
|
||||
int prevDepth = currentDepth - 1;
|
||||
std::sort(indices.begin(), indices.end(),
|
||||
[&](size_t a, size_t b) {
|
||||
// Only consider commands that were evaluated at previous depth
|
||||
if (highestDepthCompleted[a] >= prevDepth &&
|
||||
highestDepthCompleted[b] >= prevDepth) {
|
||||
return scoresByDepth[a][prevDepth] > scoresByDepth[b][prevDepth];
|
||||
}
|
||||
// Commands not evaluated at prev depth go to the end
|
||||
return highestDepthCompleted[a] >= prevDepth;
|
||||
});
|
||||
|
||||
return indices;
|
||||
}
|
||||
```
|
||||
|
||||
#### SelectBestResult
|
||||
|
||||
Choose the best command considering the depth achieved:
|
||||
|
||||
```cpp
|
||||
SearchResult SelectBestResult(
|
||||
const std::vector<std::vector<ScoreValue>>& scoresByDepth,
|
||||
const std::vector<int>& highestDepthCompleted) {
|
||||
|
||||
SearchResult result;
|
||||
result.bestScore = -std::numeric_limits<ScoreValue>::infinity();
|
||||
|
||||
// Find the command with best score at its highest evaluated depth
|
||||
for (size_t i = 0; i < scoresByDepth.size(); ++i) {
|
||||
if (highestDepthCompleted[i] > 0) {
|
||||
ScoreValue score = scoresByDepth[i][highestDepthCompleted[i]];
|
||||
if (score > result.bestScore) {
|
||||
result.bestScore = score;
|
||||
result.bestCommandIndex = i;
|
||||
result.depthAchieved = highestDepthCompleted[i];
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
```
|
||||
|
||||
### Data Structure Updates
|
||||
|
||||
Replace the current separate tracking with unified structures:
|
||||
|
||||
```cpp
|
||||
class IterativeDeepeningAI {
|
||||
// ... existing members ...
|
||||
|
||||
// New reusable storage to reduce allocations
|
||||
mutable std::vector<std::vector<ScoreValue>> scoresByDepth;
|
||||
mutable std::vector<int> highestDepthCompleted;
|
||||
mutable std::vector<size_t> reusableSortedIndices;
|
||||
};
|
||||
```
|
||||
|
||||
## Rationale for 50% Budget Check
|
||||
|
||||
The 50% time budget check is crucial because of the exponential nature of game tree search:
|
||||
- If depth N takes time T, depth N+1 typically takes B×T (where B is the branching factor)
|
||||
- If we've used >50% of budget at depth N, we likely can't complete even one command at depth N+1
|
||||
- Better to have complete results at depth N than incomplete results at depth N+1
|
||||
|
||||
Example with branching factor ~40:
|
||||
- Depth 1: 100ms (10% of 1000ms budget)
|
||||
- Depth 2: 400ms (total 50%)
|
||||
- Depth 3: Would take ~1600ms (total 210%) - don't attempt
|
||||
|
||||
## Benefits
|
||||
|
||||
1. **Adaptability**: Automatically adjusts search depth based on available time
|
||||
2. **Completeness**: Ensures all commands are evaluated at each attempted depth
|
||||
3. **Optimality**: Commands are always evaluated in order of promise from previous depth
|
||||
4. **Scalability**: Can search arbitrarily deep when time permits
|
||||
5. **Robustness**: 50% check prevents wasting time on incomplete deep searches
|
||||
|
||||
## Implementation Notes
|
||||
|
||||
- Maintain backward compatibility with existing time budget calculations
|
||||
- Add comprehensive logging to track depth progression
|
||||
- Consider memory allocation optimizations for deep searches
|
||||
- Test thoroughly with various time budgets and game states
|
||||
|
||||
## Implementation Results
|
||||
|
||||
The true iterative deepening implementation has been successfully completed. The key changes include:
|
||||
|
||||
1. **Generalized Depth Loop**: The algorithm now supports arbitrary depths instead of being limited to depth 2
|
||||
2. **50% Budget Check**: Prevents starting a new depth if more than half the time budget is consumed
|
||||
3. **SET_UP Phase Handling**: Limits depth to 2 during game setup to avoid overthinking unit placement
|
||||
4. **Efficient Sorting**: Commands are evaluated at each depth in order of their scores from the previous depth
|
||||
5. **Memory Optimization**: Reuses data structures to minimize allocations during search
|
||||
|
||||
The implementation maintains backward compatibility while enabling deeper searches when time permits, leading to potentially better AI decisions in complex game situations.
|
||||
|
||||
### Critical Fixes Applied
|
||||
|
||||
#### 1. Depth 1 Always Completes
|
||||
We ensured that depth 1 ALWAYS completes regardless of time budget by:
|
||||
- Modifying the outer loop condition: `(currentDepth == 1 || !IsTimeExpired(timeBudget))`
|
||||
- Modifying the inner loop condition: `if (currentDepth > 1 && IsTimeExpired(timeBudget))`
|
||||
|
||||
This guarantees the AI always has at least a depth-1 evaluation for every command, preventing the AI from making no decision due to time constraints.
|
||||
|
||||
#### 2. END_TURN Detection
|
||||
Added logic to prevent excessive depth exploration when the game tree terminates:
|
||||
- **Root-level check**: If all commands at the current game state are END_TURN_COMMAND, stop after depth 1
|
||||
- **Lookahead termination check**: If scores don't change between depth N-1 and depth N for all commands, it indicates the lookahead hit END_TURN_COMMAND and stopped recursing
|
||||
|
||||
This prevents the AI from exploring to extreme depths (1000+) when there are no meaningful decisions to make, which can happen when there are very few commands available and the game tree quickly reaches states where only END_TURN_COMMAND is available.
|
||||
|
||||
#### 3. Command Change Logging
|
||||
Added comprehensive logging to track when deeper search changes the AI's decision:
|
||||
- After each depth, identifies the best command based on current evaluations
|
||||
- Compares with the best command from the previous depth
|
||||
- Logs detailed information when the best command changes, including:
|
||||
- Both commands' indices and scores
|
||||
- Full command debug strings for analysis
|
||||
|
||||
This helps understand when and why deeper search is beneficial, providing insights into the AI's decision-making process.
|
||||
@@ -0,0 +1,74 @@
|
||||
# Shardok Performance Optimization Plan
|
||||
|
||||
## Current Status
|
||||
PostActionUnchecked reduced from 45.4% to 39.3% of total runtime after shared_ptr optimizations.
|
||||
|
||||
## ✅ Completed Optimizations
|
||||
|
||||
### 1. APDCache Thread-Local Caching
|
||||
- **Problem**: PreCachedAPDs constructor taking 18.5% of processing time
|
||||
- **Solution**: Moved thread-local caching into APDCache API using existing FullCacheKey infrastructure
|
||||
- **Implementation**: Hybrid API with both shared_ptr and raw pointer access, migrated 21+ call sites
|
||||
- **Result**: Successfully eliminated shared_ptr overhead in AI calculations
|
||||
|
||||
### 2. SharedPtr Reference Counting Fix
|
||||
- **Problem**: Atomic reference counting overhead in ShardokAction::Execute (28.4% of total runtime)
|
||||
- **Solution**: Changed RandomGenerator parameter from `std::shared_ptr<RandomGenerator>` to `const std::shared_ptr<RandomGenerator>&`
|
||||
- **Implementation**: Updated 49+ override sites across all command and action classes
|
||||
- **Result**: Reduced PostActionUnchecked from 45.4% to 39.3% of runtime
|
||||
|
||||
## ❌ Failed Attempts
|
||||
|
||||
### 1. ToByteString() Caching
|
||||
- **Problem**: Suspected expensive game state serialization calls
|
||||
- **Solution**: Added hash-based caching to avoid repeated ToByteString() calls
|
||||
- **Result**: No measurable performance improvement (discarded)
|
||||
|
||||
## 📋 Next Steps (Priority Order)
|
||||
|
||||
### 1. Optimize Occupant() with Array-based Indexing (HIGH PRIORITY)
|
||||
- **Problem**: `Occupant()` function iterates through ALL units (O(n)) to find unit at specific coordinates
|
||||
- **Solution**: Replace with O(1) array lookup indexed by `row * columnCount + column`
|
||||
- **Implementation**:
|
||||
- Simple array storing UnitId (or INVALID_UNIT_ID) at each map position
|
||||
- Update index when units move/spawn/die
|
||||
- Use in GameStateW wrapper with lazy initialization
|
||||
- **Rationale**: Clear algorithmic improvement, frequently called function
|
||||
- **Expected Impact**: Unknown but potentially significant
|
||||
|
||||
### 2. Profile Next Bottleneck (HIGH PRIORITY)
|
||||
- **Goal**: After Occupant() optimization, re-profile to identify next hotspot
|
||||
- **Focus**: PostActionUnchecked still 39.3% - drill deeper into remaining time consumption
|
||||
- **Approach**: Look for unexpected bottlenecks like the shared_ptr reference counting we discovered
|
||||
- **Rationale**: Profiling has revealed surprising performance issues
|
||||
|
||||
### 3. Defer UpdateGameStatusAction (MEDIUM PRIORITY)
|
||||
- **Problem**: Victory conditions checked after every action
|
||||
- **Solution**: Batch victory condition checks to end of turn or specific triggers
|
||||
- **Expected Impact**: Reduce redundant computation overhead
|
||||
|
||||
### 4. Object Pooling (MEDIUM PRIORITY)
|
||||
- **Problem**: Frequent allocation/deallocation of ActionResult and other objects
|
||||
- **Solution**: Implement object pools for frequently created objects
|
||||
- **Focus**: ActionResult objects, other high-frequency allocations
|
||||
- **Expected Impact**: Reduce memory allocation overhead
|
||||
|
||||
### 5. Lazy Modifier Hash Calculation (LOW PRIORITY)
|
||||
- **Problem**: Hash calculations performed unnecessarily
|
||||
- **Solution**: Compute hashes only when needed, cache between modifications
|
||||
- **Expected Impact**: Minor optimization for specific scenarios
|
||||
|
||||
## Key Insights
|
||||
|
||||
1. **Profiling Reveals Surprises**: Both major optimizations (APDCache and shared_ptr) were discovered through profiling rather than intuition
|
||||
2. **Atomic Operations Are Expensive**: Shared_ptr reference counting showed up as significant assembly-level overhead
|
||||
3. **Algorithmic Improvements Matter**: O(n) → O(1) optimizations like the proposed Occupant() fix are worth pursuing
|
||||
4. **Measurement is Critical**: ToByteString() caching seemed logical but provided no benefit
|
||||
5. **Incremental Progress**: Each optimization reveals the next bottleneck, requiring continuous profiling
|
||||
|
||||
## Implementation Notes
|
||||
|
||||
- Always profile before and after changes to measure actual impact
|
||||
- Be prepared to discard optimizations that don't provide measurable benefit
|
||||
- Focus on algorithmic improvements and unexpected bottlenecks revealed by profiling
|
||||
- Continue systematic analysis of PostActionUnchecked hotspots
|
||||
@@ -0,0 +1,306 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-15.
|
||||
//
|
||||
|
||||
#include "AIPerformanceRunner.hpp"
|
||||
|
||||
#include <cstdlib>
|
||||
#include <iomanip>
|
||||
#include <iostream>
|
||||
#include <string>
|
||||
|
||||
#include "PerformanceTestGameStateBuilder.hpp"
|
||||
#include "src/main/cpp/net/eagle0/common/FilesystemUtils.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/ShardokAIClient.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokEngine.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_point_distances/FixedActionPointDistances.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/common/command_type.pb.h"
|
||||
|
||||
using namespace shardok;
|
||||
|
||||
namespace {
|
||||
|
||||
/**
|
||||
* Convert completion reason to human-readable string.
|
||||
*/
|
||||
auto CompletionReasonToString(EvaluationCompletionReason reason) -> std::string {
|
||||
switch (reason) {
|
||||
case EvaluationCompletionReason::RAN_OUT_OF_COMMANDS:
|
||||
return "completed all meaningful commands";
|
||||
case EvaluationCompletionReason::RAN_OUT_OF_TIME: return "time budget exhausted";
|
||||
case EvaluationCompletionReason::NOT_ENOUGH_TIME_TO_CONTINUE:
|
||||
return "insufficient time for next depth";
|
||||
default: return "unknown";
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Parse command line arguments into a configuration struct.
|
||||
*/
|
||||
auto ParseCommandLineArgs(int argc, char* argv[]) -> PerformanceTestConfig {
|
||||
PerformanceTestConfig config;
|
||||
|
||||
for (int i = 1; i < argc; ++i) {
|
||||
std::string arg(argv[i]);
|
||||
|
||||
if (arg == "--help" || arg == "-h") {
|
||||
std::cout << "Shardok AI Performance Runner\n"
|
||||
<< "Usage: " << argv[0] << " [options]\n"
|
||||
<< "\n"
|
||||
<< "Options:\n"
|
||||
<< " --map=NAME Map name (default: Alah)\n"
|
||||
<< " --turns=N Number of turns to test (default: 5)\n"
|
||||
<< " --defender=BOOL AI is defender (default: false)\n"
|
||||
<< " --verbose Enable verbose output\n"
|
||||
<< " --help, -h Show this help message\n";
|
||||
std::exit(0);
|
||||
} else if (arg.starts_with("--map=")) {
|
||||
config.mapName = arg.substr(6);
|
||||
} else if (arg.starts_with("--turns=")) {
|
||||
config.numTurns = std::stoi(arg.substr(8));
|
||||
} else if (arg.starts_with("--defender=")) {
|
||||
std::string value = arg.substr(11);
|
||||
config.defenderToggle = (value == "true" || value == "1");
|
||||
} else if (arg == "--verbose") {
|
||||
config.verbose = true;
|
||||
} else {
|
||||
std::cerr << "Unknown argument: " << arg << "\n";
|
||||
std::cerr << "Use --help for usage information.\n";
|
||||
std::exit(1);
|
||||
}
|
||||
}
|
||||
|
||||
return config;
|
||||
}
|
||||
|
||||
} // namespace
|
||||
|
||||
int main(int argc, char* argv[]) {
|
||||
std::cout << "Starting AI Performance Runner..." << std::endl;
|
||||
|
||||
// Set exec path so FilesystemUtils can find resource files
|
||||
FilesystemUtils::SetExecPath(argv[0]);
|
||||
|
||||
// Set cache directory for ActionPointDistances
|
||||
FixedActionPointDistances::SetCacheDirectory(
|
||||
FilesystemUtils::CacheFilesDirectory() + "apdCache/");
|
||||
|
||||
try {
|
||||
std::cout << "Shardok AI Performance Runner\n";
|
||||
std::cout << "==============================\n";
|
||||
|
||||
// Parse command line arguments
|
||||
auto config = ParseCommandLineArgs(argc, argv);
|
||||
|
||||
if (config.verbose) {
|
||||
std::cout << "Configuration:\n";
|
||||
std::cout << " Map: " << config.mapName << "\n";
|
||||
std::cout << " Turns: " << config.numTurns << "\n";
|
||||
std::cout << " AI is defender: " << (config.defenderToggle ? "Yes" : "No") << "\n";
|
||||
}
|
||||
|
||||
// Initialize game settings
|
||||
auto settings = PerformanceTestGameStateBuilder::InitializeGameSettings();
|
||||
|
||||
// Create test game state
|
||||
auto gameState = PerformanceTestGameStateBuilder::CreatePerfTestGameState(
|
||||
settings,
|
||||
config.defenderToggle);
|
||||
|
||||
// Create engine
|
||||
ShardokEngine engine(settings, gameState);
|
||||
|
||||
// Test basic functionality
|
||||
auto currentState = engine.GetCurrentGameState();
|
||||
|
||||
// Create AI client for testing
|
||||
const PlayerId aiPlayerId = 0;
|
||||
const bool isDefender = config.defenderToggle;
|
||||
const auto* hexMap = currentState->hex_map();
|
||||
const auto settingsGetter = settings->GetGetter();
|
||||
|
||||
ShardokAIClient aiClient(aiPlayerId, isDefender, hexMap, settingsGetter);
|
||||
|
||||
// Create a second AI client for the human player during setup
|
||||
// This ensures consistent state handling during setup phase
|
||||
const PlayerId humanPlayerId = 1;
|
||||
ShardokAIClient humanSetupAI(humanPlayerId, !isDefender, hexMap, settingsGetter);
|
||||
|
||||
// Complete setup phase - AI makes intelligent placement decisions
|
||||
if (currentState->status()->state() ==
|
||||
net::eagle0::shardok::storage::fb::GameStatus_::State_SET_UP) {
|
||||
while (currentState->status()->state() ==
|
||||
net::eagle0::shardok::storage::fb::GameStatus_::State_SET_UP) {
|
||||
PlayerId currentPlayer = currentState->current_player();
|
||||
auto availableCommands = engine.GetAvailableCommandProtos(currentPlayer, false);
|
||||
|
||||
if (availableCommands.empty()) {
|
||||
std::cout << "No commands available for player "
|
||||
<< static_cast<int>(currentPlayer) << "\n";
|
||||
break;
|
||||
}
|
||||
|
||||
if (currentPlayer == aiPlayerId) {
|
||||
// Let AI make intelligent placement decisions
|
||||
auto choiceResults = aiClient.ChooseCommandIndex(engine);
|
||||
engine.PostCommand(currentPlayer, choiceResults.chosenIndex);
|
||||
} else {
|
||||
// Human player: use AI for setup to ensure consistent state handling
|
||||
auto choiceResults = humanSetupAI.ChooseCommandIndex(engine);
|
||||
engine.PostCommand(currentPlayer, choiceResults.chosenIndex);
|
||||
}
|
||||
|
||||
currentState = engine.GetCurrentGameState();
|
||||
}
|
||||
}
|
||||
|
||||
// Test AI performance for configured number of turns
|
||||
std::cout << "Running AI performance test for " << config.numTurns << " turns...\n";
|
||||
|
||||
std::vector<AIPerformanceMetrics> metrics;
|
||||
|
||||
for (int turn = 0; turn < config.numTurns; ++turn) {
|
||||
// Check if AI can make a move
|
||||
const auto availableCommands = engine.GetAvailableCommandProtos(aiPlayerId, false);
|
||||
if (availableCommands.empty()) {
|
||||
std::cout << " No commands available for AI player. Ending test.\n";
|
||||
break;
|
||||
}
|
||||
|
||||
// Get AI decision with performance metrics
|
||||
auto choiceResults = aiClient.ChooseCommandIndex(engine);
|
||||
|
||||
std::cout << " AI chose command index: " << choiceResults.chosenIndex << "\n";
|
||||
std::cout << " Depth achieved: " << choiceResults.depthAchieved << "\n";
|
||||
std::cout << " Commands evaluated: " << choiceResults.commandCountEvaluated << "/"
|
||||
<< choiceResults.availableCommandCount << "\n";
|
||||
|
||||
// Create metrics for this turn
|
||||
AIPerformanceMetrics turnMetrics;
|
||||
turnMetrics.commandNumber = turn + 1;
|
||||
turnMetrics.totalCommands = static_cast<int>(choiceResults.availableCommandCount);
|
||||
turnMetrics.depthAchieved = choiceResults.depthAchieved;
|
||||
turnMetrics.commandsEvaluated = static_cast<int>(choiceResults.commandCountEvaluated);
|
||||
turnMetrics.selectedCommandType = net::eagle0::shardok::common::CommandType_Name(
|
||||
availableCommands[choiceResults.chosenIndex].type());
|
||||
turnMetrics.completionReason = choiceResults.completionReason;
|
||||
|
||||
metrics.push_back(turnMetrics);
|
||||
|
||||
if (config.verbose) {
|
||||
std::cout << " Command: " << turnMetrics.selectedCommandType << "\n";
|
||||
std::cout << " Search depth: " << turnMetrics.depthAchieved << "\n";
|
||||
std::cout << " Commands evaluated: " << turnMetrics.commandsEvaluated << "\n";
|
||||
std::cout << " Applying command...\n";
|
||||
}
|
||||
|
||||
// Apply the chosen command
|
||||
engine.PostCommand(aiPlayerId, choiceResults.chosenIndex);
|
||||
|
||||
// Check if game is over
|
||||
if (engine.GameIsOver()) {
|
||||
std::cout << " Game over after " << (turn + 1) << " turns.\n";
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
// Print summary
|
||||
std::cout << "\nAI Search Performance Summary:\n";
|
||||
std::cout << "==============================\n";
|
||||
std::cout << "Total turns: " << metrics.size() << "\n";
|
||||
|
||||
if (!metrics.empty()) {
|
||||
// Calculate summary statistics
|
||||
double avgDepth = 0.0;
|
||||
int totalEvaluated = 0;
|
||||
int totalAvailable = 0;
|
||||
|
||||
for (const auto& metric : metrics) {
|
||||
avgDepth += metric.depthAchieved;
|
||||
totalEvaluated += metric.commandsEvaluated;
|
||||
totalAvailable += metric.totalCommands;
|
||||
}
|
||||
|
||||
avgDepth /= metrics.size();
|
||||
|
||||
std::cout << "Average search depth: " << std::fixed << std::setprecision(1) << avgDepth
|
||||
<< "\n";
|
||||
std::cout << "Total commands evaluated: " << totalEvaluated << "/" << totalAvailable
|
||||
<< "\n";
|
||||
|
||||
// Calculate evaluation rate by depth
|
||||
// Find max depth achieved across all turns
|
||||
int maxDepth = 0;
|
||||
for (const auto& metric : metrics) {
|
||||
maxDepth = std::max(maxDepth, metric.depthAchieved);
|
||||
}
|
||||
|
||||
if (maxDepth >= 2) {
|
||||
std::cout << "\nCommands evaluated by depth:\n";
|
||||
for (int depth = 2; depth <= maxDepth; ++depth) {
|
||||
int turnsAtThisDepth = 0;
|
||||
int totalCommandsAtDepth = 0;
|
||||
int totalCommandsAvailableAtDepth = 0;
|
||||
|
||||
for (const auto& metric : metrics) {
|
||||
bool reachedThisDepth = metric.depthAchieved >= depth;
|
||||
bool completedAtLowerDepth =
|
||||
(metric.depthAchieved < depth &&
|
||||
metric.completionReason ==
|
||||
EvaluationCompletionReason::RAN_OUT_OF_COMMANDS);
|
||||
|
||||
if (reachedThisDepth || completedAtLowerDepth) {
|
||||
turnsAtThisDepth++;
|
||||
totalCommandsAvailableAtDepth += metric.totalCommands;
|
||||
|
||||
if (metric.depthAchieved > depth || completedAtLowerDepth) {
|
||||
// If achieved higher depth OR completed all commands at lower
|
||||
// depth, we evaluated ALL commands at this depth
|
||||
totalCommandsAtDepth += metric.totalCommands;
|
||||
} else if (metric.depthAchieved == depth) {
|
||||
// If stopped at this depth, we evaluated commandsEvaluated commands
|
||||
if (metric.completionReason ==
|
||||
EvaluationCompletionReason::RAN_OUT_OF_COMMANDS) {
|
||||
// If ran out of commands, we evaluated all of them
|
||||
totalCommandsAtDepth += metric.totalCommands;
|
||||
} else {
|
||||
// Otherwise we evaluated the reported number
|
||||
totalCommandsAtDepth += metric.commandsEvaluated;
|
||||
}
|
||||
}
|
||||
}
|
||||
// If didn't reach this depth, contributes 0 commands (implicit)
|
||||
}
|
||||
|
||||
double evalRate =
|
||||
totalCommandsAvailableAtDepth > 0
|
||||
? (100.0 * totalCommandsAtDepth / totalCommandsAvailableAtDepth)
|
||||
: 0.0;
|
||||
|
||||
std::cout << " Depth " << depth << ": " << totalCommandsAtDepth << "/"
|
||||
<< totalCommandsAvailableAtDepth << " commands (" << std::fixed
|
||||
<< std::setprecision(1) << evalRate << "%, " << turnsAtThisDepth
|
||||
<< "/" << metrics.size() << " turns reached)\n";
|
||||
}
|
||||
}
|
||||
|
||||
std::cout << "\nTurn-by-turn details:\n";
|
||||
for (const auto& metric : metrics) {
|
||||
std::string depthStr = std::to_string(metric.depthAchieved);
|
||||
if (metric.completionReason == EvaluationCompletionReason::RAN_OUT_OF_COMMANDS) {
|
||||
depthStr += "*";
|
||||
}
|
||||
std::cout << "Turn " << metric.commandNumber << ": depth " << depthStr
|
||||
<< ", evaluated " << metric.commandsEvaluated << "/"
|
||||
<< metric.totalCommands << ", chose " << metric.selectedCommandType
|
||||
<< " (" << CompletionReasonToString(metric.completionReason) << ")\n";
|
||||
}
|
||||
}
|
||||
|
||||
} catch (const std::exception& e) {
|
||||
std::cerr << "Error: " << e.what() << "\n";
|
||||
return 1;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -0,0 +1,55 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-15.
|
||||
//
|
||||
|
||||
#ifndef EAGLE0_AIPERFORMANCERUNNER_HPP
|
||||
#define EAGLE0_AIPERFORMANCERUNNER_HPP
|
||||
|
||||
#include <chrono>
|
||||
#include <map>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/ai/IterativeDeepeningAI.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
/**
|
||||
* Metrics captured for each AI command evaluation during performance testing.
|
||||
*/
|
||||
struct AIPerformanceMetrics {
|
||||
int commandNumber;
|
||||
int depthAchieved;
|
||||
int commandsEvaluated;
|
||||
int totalCommands;
|
||||
std::string selectedCommandType;
|
||||
EvaluationCompletionReason completionReason;
|
||||
};
|
||||
|
||||
/**
|
||||
* Overall results from a performance test run.
|
||||
*/
|
||||
struct PerformanceTestResults {
|
||||
std::string mapName;
|
||||
int totalTurns;
|
||||
std::vector<AIPerformanceMetrics> commandMetrics;
|
||||
double averageDepth;
|
||||
double completionRate;
|
||||
std::chrono::milliseconds totalTime;
|
||||
};
|
||||
|
||||
/**
|
||||
* Configuration options for performance testing.
|
||||
*/
|
||||
struct PerformanceTestConfig {
|
||||
std::string mapName = "Alah";
|
||||
int numTurns = 5;
|
||||
bool defenderToggle = false;
|
||||
bool verbose = false;
|
||||
int aiUnitCount = 6;
|
||||
int humanUnitCount = 6;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
#endif // EAGLE0_AIPERFORMANCERUNNER_HPP
|
||||
@@ -0,0 +1,51 @@
|
||||
load("//tools:copts.bzl", "COPTS")
|
||||
|
||||
cc_binary(
|
||||
name = "ai_performance_runner",
|
||||
srcs = [
|
||||
"AIPerformanceRunner.cpp",
|
||||
"AIPerformanceRunner.hpp",
|
||||
],
|
||||
copts = COPTS,
|
||||
data = [
|
||||
"//src/main/resources/net/eagle0/shardok:battalion_types",
|
||||
"//src/main/resources/net/eagle0/shardok:settings",
|
||||
"//src/main/resources/net/eagle0/shardok/maps",
|
||||
],
|
||||
deps = [
|
||||
":performance_test_game_state_builder",
|
||||
"//src/main/cpp/net/eagle0/common:filesystem_utils",
|
||||
"//src/main/cpp/net/eagle0/common:time_utils",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_attacker_strategy_selector",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_defender_strategy_selector",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_iterative_deepening",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_score_calculator",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_time_budget",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_water_crossing_command_chooser",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:shardok_ai_client",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:engine",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:battalion_type_registrar",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:map_loader",
|
||||
],
|
||||
)
|
||||
|
||||
cc_library(
|
||||
name = "performance_test_game_state_builder",
|
||||
srcs = ["PerformanceTestGameStateBuilder.cpp"],
|
||||
hdrs = [
|
||||
"PerformanceTestGameStateBuilder.hpp",
|
||||
],
|
||||
copts = COPTS,
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:shardok_c_types",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:game_state_helpers",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:battalion_type_registrar",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:map_loader",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:unit_cc_fbs",
|
||||
"//src/main/protobuf/net/eagle0/shardok/common:player_info_cc_proto",
|
||||
],
|
||||
)
|
||||
@@ -0,0 +1,205 @@
|
||||
# AI Performance Runner Implementation Plan
|
||||
|
||||
## Overview
|
||||
|
||||
This document outlines the implementation plan for an automated AI performance testing tool for Shardok. The tool will replicate the manual performance testing currently done through the Unity client's "Custom Battle" interface, providing reproducible and automated performance measurements.
|
||||
|
||||
## Goals
|
||||
|
||||
1. **Automate Performance Testing**: Eliminate the need for manual Unity client interaction
|
||||
2. **Reproducible Results**: Ensure consistent test conditions across runs
|
||||
3. **Detailed Metrics**: Capture the same metrics currently observed manually (commands evaluated at each depth)
|
||||
4. **Clean Architecture**: Maintain proper dependency boundaries (no src/test dependencies in src/main)
|
||||
|
||||
## Directory Structure
|
||||
|
||||
```
|
||||
src/main/cpp/net/eagle0/shardok/ai_performance_runner/
|
||||
├── AIPerformanceRunner.cpp # Main binary entry point
|
||||
├── AIPerformanceRunner.hpp # Performance metrics structs and helpers
|
||||
├── PerformanceTestGameStateBuilder.cpp # Game state setup utilities
|
||||
├── PerformanceTestGameStateBuilder.hpp # Game state builder interface
|
||||
├── BUILD.bazel # Build configuration
|
||||
└── README.md # Usage documentation
|
||||
```
|
||||
|
||||
## Implementation Details
|
||||
|
||||
### 1. Performance Metrics Structure
|
||||
|
||||
```cpp
|
||||
struct AIPerformanceMetrics {
|
||||
int commandNumber;
|
||||
int depthAchieved;
|
||||
std::map<int, int> commandsEvaluatedAtDepth; // depth -> count
|
||||
std::chrono::milliseconds timeUsed;
|
||||
bool minimumDepthCompleted;
|
||||
bool searchCompleted;
|
||||
std::string selectedCommandType;
|
||||
};
|
||||
|
||||
struct PerformanceTestResults {
|
||||
std::string mapName;
|
||||
int totalTurns;
|
||||
std::vector<AIPerformanceMetrics> commandMetrics;
|
||||
double averageDepth;
|
||||
double completionRate;
|
||||
std::chrono::milliseconds totalTime;
|
||||
};
|
||||
```
|
||||
|
||||
### 2. Test Configuration
|
||||
|
||||
The default configuration replicates the Unity client's "Perf" button:
|
||||
|
||||
- **Map**: "Alah"
|
||||
- **AI Player**: 6 units with professions 1-6, all battalion type 4 (Heavy Infantry)
|
||||
- **Human Player**: 6 units (no specific configuration needed since AI will control)
|
||||
- **Defender Toggle**: Configurable (affects starting positions)
|
||||
|
||||
### 3. Key Components
|
||||
|
||||
#### AIPerformanceRunner.cpp
|
||||
- Main entry point with command-line argument parsing
|
||||
- Test execution loop
|
||||
- Results formatting and output
|
||||
- Integration with ShardokEngine and IterativeDeepeningAI
|
||||
|
||||
#### PerformanceTestGameStateBuilder.cpp
|
||||
- Game state creation utilities (migrated from test code)
|
||||
- Map loading helpers
|
||||
- Unit placement logic
|
||||
- Player setup functions
|
||||
|
||||
### 4. Build Configuration
|
||||
|
||||
```python
|
||||
load("//tools:copts.bzl", "COPTS")
|
||||
|
||||
cc_binary(
|
||||
name = "ai_performance_runner",
|
||||
srcs = ["AIPerformanceRunner.cpp"],
|
||||
copts = COPTS,
|
||||
data = [
|
||||
"//src/main/resources/net/eagle0/shardok:battalion_types",
|
||||
"//src/main/resources/net/eagle0/shardok:settings",
|
||||
"//src/main/resources/net/eagle0/shardok/maps",
|
||||
],
|
||||
deps = [
|
||||
":performance_test_game_state_builder",
|
||||
"//src/main/cpp/net/eagle0/common:time_utils",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_iterative_deepening",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_attacker_strategy_selector",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_defender_strategy_selector",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_score_calculator",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_time_budget",
|
||||
"//src/main/cpp/net/eagle0/shardok/ai:ai_water_crossing_command_chooser",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:engine",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:battalion_type_registrar",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:map_loader",
|
||||
],
|
||||
)
|
||||
|
||||
cc_library(
|
||||
name = "performance_test_game_state_builder",
|
||||
srcs = ["PerformanceTestGameStateBuilder.cpp"],
|
||||
hdrs = [
|
||||
"AIPerformanceRunner.hpp",
|
||||
"PerformanceTestGameStateBuilder.hpp",
|
||||
],
|
||||
copts = COPTS,
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/common:filesystem_utils",
|
||||
"//src/main/cpp/net/eagle0/common:tsv_parser",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/util:map_loader",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:player_info_cc_fbs",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:unit_cc_fbs",
|
||||
],
|
||||
)
|
||||
```
|
||||
|
||||
### 5. Command-Line Interface
|
||||
|
||||
```bash
|
||||
# Run default performance test (Alah map, 6v6 units)
|
||||
bazel run //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner
|
||||
|
||||
# Run with specific number of turns
|
||||
bazel run //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner -- --turns=10
|
||||
|
||||
# Run with defender configuration
|
||||
bazel run //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner -- --defender=true
|
||||
|
||||
# Run with verbose output
|
||||
bazel run //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner -- --verbose
|
||||
|
||||
# Run with specific map
|
||||
bazel run //src/main/cpp/net/eagle0/shardok/ai_performance_runner:ai_performance_runner -- --map=Chipingia
|
||||
```
|
||||
|
||||
### 6. Expected Output Format
|
||||
|
||||
```
|
||||
Shardok AI Performance Test
|
||||
===========================
|
||||
Map: Alah
|
||||
Configuration: 6v6 units (AI as attacker)
|
||||
Time Budget: Dynamic (proximity-based)
|
||||
|
||||
Turn 1:
|
||||
Command 1: Depth 2, evaluated 140/280 commands, time: 1250ms [MoveCommand]
|
||||
Command 2: Depth 2, evaluated ALL commands, time: 1180ms [MeleeCommand]
|
||||
Command 3: Depth 3, evaluated 21/156 commands, time: 1300ms [ArcheryCommand]
|
||||
Command 4: Depth 3, evaluated 78/312 commands, time: 1290ms [MoveCommand]
|
||||
Turn Summary: Avg depth 2.5, Total time: 5020ms
|
||||
|
||||
Overall Results:
|
||||
Total Turns: 5
|
||||
Average Depth Achieved: 2.4
|
||||
Commands Completed at Target Depth: 85%
|
||||
Total Time: 25.1s
|
||||
Average Time per Command: 1255ms
|
||||
```
|
||||
|
||||
### 7. Implementation Phases
|
||||
|
||||
#### Phase 1: Basic Infrastructure
|
||||
1. Create directory structure and BUILD.bazel
|
||||
2. Implement PerformanceTestGameStateBuilder with minimal game state creation
|
||||
3. Create basic AIPerformanceRunner that can load a map and create players
|
||||
|
||||
#### Phase 2: AI Integration
|
||||
1. Integrate IterativeDeepeningAI
|
||||
2. Implement performance metric collection
|
||||
3. Add basic output formatting
|
||||
|
||||
#### Phase 3: Full Feature Set
|
||||
1. Add command-line argument parsing
|
||||
2. Implement multiple test configurations (Perf, Rivers, Custom)
|
||||
3. Add detailed performance metrics and analysis
|
||||
|
||||
#### Phase 4: Polish and Documentation
|
||||
1. Create comprehensive README.md
|
||||
2. Add error handling and validation
|
||||
3. Implement baseline comparison features
|
||||
|
||||
## Success Criteria
|
||||
|
||||
1. **Functional**: Tool successfully runs AI turns and captures performance metrics
|
||||
2. **Accurate**: Results match manually observed performance within reasonable variance
|
||||
3. **Reproducible**: Multiple runs produce consistent results
|
||||
4. **Maintainable**: Clean code structure with no dependencies on src/test
|
||||
5. **Usable**: Clear command-line interface and helpful output
|
||||
|
||||
## Future Enhancements
|
||||
|
||||
- JSON output format for automated analysis
|
||||
- Performance regression detection
|
||||
- Integration with CI/CD pipeline
|
||||
- Configurable test scenarios beyond "Perf" and "Rivers"
|
||||
- Multi-threaded performance testing
|
||||
+253
@@ -0,0 +1,253 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-15.
|
||||
//
|
||||
|
||||
#include "PerformanceTestGameStateBuilder.hpp"
|
||||
|
||||
#include <filesystem>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/common/FilesystemUtils.hpp"
|
||||
#include "src/main/cpp/net/eagle0/common/TsvParser.hpp"
|
||||
#include "src/main/cpp/net/eagle0/common/byte_vector.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/GameStateHelpers.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/util/BattalionTypeRegistrar.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/util/MapLoader.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/unit.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/common/player_info.pb.h"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
namespace {
|
||||
|
||||
// Profession enum values
|
||||
constexpr int NO_PROFESSION = 0;
|
||||
|
||||
// Player IDs
|
||||
constexpr PlayerId AI_PLAYER_ID = 0;
|
||||
constexpr PlayerId HUMAN_PLAYER_ID = 1;
|
||||
|
||||
} // namespace
|
||||
|
||||
auto PerformanceTestGameStateBuilder::InitializeGameSettings() -> GameSettingsSPtr {
|
||||
auto settings = std::make_shared<GameSettings>();
|
||||
auto setter = settings->GetSetter();
|
||||
|
||||
// Load battalion types
|
||||
BattalionTypeRegistrar::RegisterBattalionTypes(setter);
|
||||
|
||||
// Load complete settings from settings.tsv file
|
||||
TsvParser parser;
|
||||
const string settingsPath = FilesystemUtils::StaticShardokFilesDirectory() + "settings.tsv";
|
||||
const string settingsTsv = string(byte_vector::FromPath(settingsPath));
|
||||
const auto valuesAndTypes = parser.ParseColumnEntryTsv(settingsTsv);
|
||||
setter.SetFromTypesAndValues(valuesAndTypes[1], valuesAndTypes[0]);
|
||||
|
||||
return settings;
|
||||
}
|
||||
|
||||
auto PerformanceTestGameStateBuilder::CreatePerfTestGameState(
|
||||
const GameSettingsSPtr& settings,
|
||||
bool defenderToggle) -> GameStateW {
|
||||
return CreateCustomTestGameState(
|
||||
settings,
|
||||
"Alah",
|
||||
6, // 6 AI units (full test configuration)
|
||||
6, // 6 human units (full test configuration)
|
||||
defenderToggle);
|
||||
}
|
||||
|
||||
auto PerformanceTestGameStateBuilder::CreateCustomTestGameState(
|
||||
const GameSettingsSPtr& settings,
|
||||
const std::string& mapName,
|
||||
int aiUnitCount,
|
||||
int humanUnitCount,
|
||||
bool defenderToggle) -> GameStateW {
|
||||
// Load the map using existing utilities
|
||||
auto hexMapProto = LoadMap(mapName);
|
||||
|
||||
// Create player info protos
|
||||
std::vector<net::eagle0::shardok::common::PlayerInfo> playerInfoProtos;
|
||||
|
||||
// AI player
|
||||
net::eagle0::shardok::common::PlayerInfo aiPlayerInfo;
|
||||
aiPlayerInfo.set_player_id(AI_PLAYER_ID);
|
||||
aiPlayerInfo.set_is_defender(defenderToggle);
|
||||
aiPlayerInfo.set_starting_food(1000);
|
||||
aiPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_LAST_PLAYER_STANDING);
|
||||
if (defenderToggle) {
|
||||
aiPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_WIN_AFTER_MAX_ROUNDS);
|
||||
} else {
|
||||
aiPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_HOLDS_CRITICAL_TILES);
|
||||
}
|
||||
playerInfoProtos.push_back(aiPlayerInfo);
|
||||
|
||||
// Human player
|
||||
net::eagle0::shardok::common::PlayerInfo humanPlayerInfo;
|
||||
humanPlayerInfo.set_player_id(HUMAN_PLAYER_ID);
|
||||
humanPlayerInfo.set_is_defender(!defenderToggle);
|
||||
humanPlayerInfo.set_starting_food(1000);
|
||||
humanPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_LAST_PLAYER_STANDING);
|
||||
if (!defenderToggle) {
|
||||
humanPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_WIN_AFTER_MAX_ROUNDS);
|
||||
} else {
|
||||
humanPlayerInfo.add_victory_conditions(
|
||||
net::eagle0::shardok::common::VICTORY_CONDITION_HOLDS_CRITICAL_TILES);
|
||||
}
|
||||
playerInfoProtos.push_back(humanPlayerInfo);
|
||||
|
||||
// Create units
|
||||
std::vector<net::eagle0::shardok::storage::fb::Unit> units;
|
||||
|
||||
// Create AI units in reserve (location -1, -1)
|
||||
for (int i = 0; i < aiUnitCount && i < 6; ++i) {
|
||||
units.push_back(AddGenericUnit(
|
||||
AI_PLAYER_ID,
|
||||
i, // Unit ID
|
||||
net::eagle0::shardok::storage::fb::Coords(-1, -1), // Reserve location
|
||||
i + 1, // Profession: 1-6 (Mage through Strategist)
|
||||
HEAVY_INFANTRY_BATTALION_TYPE,
|
||||
defenderToggle ? -1 : 0)); // Defender: -1, Attacker: 0
|
||||
}
|
||||
|
||||
// Create human units in reserve (location -1, -1)
|
||||
for (int i = 0; i < humanUnitCount && i < 6; ++i) {
|
||||
units.push_back(AddGenericUnit(
|
||||
HUMAN_PLAYER_ID,
|
||||
aiUnitCount + i, // Unit ID starting aiUnitCount
|
||||
net::eagle0::shardok::storage::fb::Coords(-1, -1), // Reserve location
|
||||
NO_PROFESSION,
|
||||
HEAVY_INFANTRY_BATTALION_TYPE,
|
||||
defenderToggle ? 0 : -1)); // Defender: -1, Attacker: 0
|
||||
}
|
||||
|
||||
// Use the proper SetupInitialGameState helper (setup phase will be handled by AI)
|
||||
return shardok::fb::SetupInitialGameState(
|
||||
"performance_test_game", // gameId
|
||||
hexMapProto,
|
||||
playerInfoProtos,
|
||||
units,
|
||||
4, // month
|
||||
false, // isWinter
|
||||
settings->GetGetter());
|
||||
}
|
||||
|
||||
auto PerformanceTestGameStateBuilder::AddPlayerInfo(
|
||||
flatbuffers::FlatBufferBuilder& fbb,
|
||||
int playerId,
|
||||
bool isDefender,
|
||||
int food) -> flatbuffers::Offset<net::eagle0::shardok::storage::fb::PlayerInfo> {
|
||||
std::vector<int8_t> victoryConditions{
|
||||
net::eagle0::shardok::storage::fb::
|
||||
VictoryCondition_VICTORY_CONDITION_LAST_PLAYER_STANDING};
|
||||
|
||||
if (isDefender) {
|
||||
victoryConditions.push_back(
|
||||
net::eagle0::shardok::storage::fb::
|
||||
VictoryCondition_VICTORY_CONDITION_WIN_AFTER_MAX_ROUNDS);
|
||||
} else {
|
||||
victoryConditions.push_back(
|
||||
net::eagle0::shardok::storage::fb::
|
||||
VictoryCondition_VICTORY_CONDITION_HOLDS_CRITICAL_TILES);
|
||||
}
|
||||
|
||||
auto victoryConditionsOffset = fbb.CreateVector(victoryConditions);
|
||||
|
||||
net::eagle0::shardok::storage::fb::PlayerInfoBuilder pib(fbb);
|
||||
pib.add_player_id(playerId);
|
||||
pib.add_starting_food(food);
|
||||
pib.add_is_defender(isDefender);
|
||||
pib.add_victory_conditions(victoryConditionsOffset);
|
||||
|
||||
return pib.Finish();
|
||||
}
|
||||
|
||||
auto PerformanceTestGameStateBuilder::AddGenericUnit(
|
||||
PlayerId playerId,
|
||||
UnitId unitId,
|
||||
const net::eagle0::shardok::storage::fb::Coords& location,
|
||||
int profession,
|
||||
int battalionType,
|
||||
int startingPositionIndex) -> net::eagle0::shardok::storage::fb::Unit {
|
||||
net::eagle0::shardok::storage::fb::Unit unit{}; // Initialize to zero
|
||||
|
||||
// Basic unit properties (following UnitConversions.cpp pattern)
|
||||
unit.mutate_player_id(playerId);
|
||||
unit.mutate_unit_id(unitId);
|
||||
unit.mutate_eagle_player_id(playerId); // Set eagle player ID
|
||||
unit.mutable_location() = location;
|
||||
unit.mutate_status(net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT);
|
||||
unit.mutate_remaining_action_points(12);
|
||||
unit.mutate_hidden(false);
|
||||
unit.mutate_fortified(false);
|
||||
unit.mutate_can_flee(true);
|
||||
unit.mutate_can_start_fire(false);
|
||||
unit.mutate_can_archery(false);
|
||||
unit.mutate_stun_rounds_remaining(0);
|
||||
unit.mutate_commanding_unit_id(-1);
|
||||
unit.mutate_targeted_unit(-1);
|
||||
unit.mutate_starting_position_index(startingPositionIndex);
|
||||
unit.mutate_has_moved_in_zoc(false);
|
||||
unit.mutate_volleys_remaining(0);
|
||||
unit.mutate_food_remaining(1000.0f); // Set food remaining
|
||||
|
||||
// Battalion
|
||||
net::eagle0::shardok::storage::fb::Battalion battalion;
|
||||
battalion.mutate_type(
|
||||
static_cast<net::eagle0::shardok::storage::fb::BattalionTypeId>(battalionType));
|
||||
battalion.mutate_size(1000.0);
|
||||
battalion.mutate_armament(100.0f);
|
||||
battalion.mutate_training(100.0f);
|
||||
battalion.mutate_morale(50.0f);
|
||||
unit.mutable_battalion() = battalion;
|
||||
|
||||
// Hero (if profession is specified)
|
||||
if (profession != NO_PROFESSION) {
|
||||
unit.mutate_has_attached_hero(true);
|
||||
|
||||
net::eagle0::shardok::storage::fb::Hero hero;
|
||||
hero.mutate_strength(50);
|
||||
hero.mutate_strength_xp(0);
|
||||
hero.mutate_agility(50);
|
||||
hero.mutate_agility_xp(0);
|
||||
hero.mutate_wisdom(50);
|
||||
hero.mutate_wisdom_xp(0);
|
||||
hero.mutate_charisma(50);
|
||||
hero.mutate_charisma_xp(0);
|
||||
hero.mutate_constitution(80);
|
||||
hero.mutate_constitution_xp(0);
|
||||
hero.mutate_vigor(50);
|
||||
hero.mutate_starting_vigor(50);
|
||||
hero.mutate_spent_vigor(0);
|
||||
hero.mutate_bravery(50);
|
||||
hero.mutate_integrity(50);
|
||||
hero.mutate_ambition(50);
|
||||
hero.mutate_eagle_hero_id(unitId + 1);
|
||||
hero.mutate_is_vip(false);
|
||||
|
||||
hero.mutable_profession_info().mutate_profession(
|
||||
static_cast<net::eagle0::shardok::storage::fb::Profession>(profession));
|
||||
hero.mutable_profession_info().mutate_meteor_cast_state(
|
||||
net::eagle0::shardok::storage::fb::MultiroundMagicState_NONE);
|
||||
|
||||
hero.mutable_control_info().mutate_controlled_unit_id(-1);
|
||||
hero.mutable_control_info().mutate_controlled_this_round(false);
|
||||
|
||||
unit.mutable_attached_hero() = hero;
|
||||
} else {
|
||||
unit.mutate_has_attached_hero(false);
|
||||
}
|
||||
|
||||
// Initialize opponent knowledge for both players (player IDs 0 and 1)
|
||||
unit.mutable_opponent_knowledge()->Mutate(0, 0); // Player 0 knowledge
|
||||
unit.mutable_opponent_knowledge()->Mutate(1, 0); // Player 1 knowledge
|
||||
|
||||
return unit;
|
||||
}
|
||||
|
||||
} // namespace shardok
|
||||
+88
@@ -0,0 +1,88 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-15.
|
||||
//
|
||||
|
||||
#ifndef EAGLE0_PERFORMANCETESTGAMESTATEBUILDER_HPP
|
||||
#define EAGLE0_PERFORMANCETESTGAMESTATEBUILDER_HPP
|
||||
|
||||
#include <flatbuffers/flatbuffers.h>
|
||||
|
||||
#include <memory>
|
||||
#include <vector>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCTypes.h"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/player_info.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/unit.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
// Forward declarations
|
||||
class GameSettings;
|
||||
using GameSettingsSPtr = std::shared_ptr<GameSettings>;
|
||||
|
||||
/**
|
||||
* Builder class for creating game states used in performance testing.
|
||||
* Provides utilities to set up specific test scenarios matching the Unity client's
|
||||
* "Perf" button configuration.
|
||||
*/
|
||||
class PerformanceTestGameStateBuilder {
|
||||
public:
|
||||
/**
|
||||
* Initialize game settings from the default configuration files.
|
||||
* Must be called before creating game states.
|
||||
*/
|
||||
static auto InitializeGameSettings() -> GameSettingsSPtr;
|
||||
|
||||
/**
|
||||
* Create the standard "Perf" test configuration:
|
||||
* - Map: Alah
|
||||
* - 6 AI units with professions 1-6, all Heavy Infantry
|
||||
* - 6 Human units (minimal configuration)
|
||||
*
|
||||
* @param settings The game settings to use
|
||||
* @param defenderToggle If true, AI is defender; if false, AI is attacker
|
||||
* @return A GameStateW with the configured battle
|
||||
*/
|
||||
static auto CreatePerfTestGameState(
|
||||
const GameSettingsSPtr& settings,
|
||||
bool defenderToggle = false) -> GameStateW;
|
||||
|
||||
/**
|
||||
* Create a custom test configuration with specified parameters.
|
||||
*
|
||||
* @param settings The game settings to use
|
||||
* @param mapName Name of the map to load
|
||||
* @param aiUnitCount Number of AI units to create
|
||||
* @param humanUnitCount Number of human units to create
|
||||
* @param defenderToggle If true, AI is defender; if false, AI is attacker
|
||||
* @return A GameStateW with the configured battle
|
||||
*/
|
||||
static auto CreateCustomTestGameState(
|
||||
const GameSettingsSPtr& settings,
|
||||
const std::string& mapName,
|
||||
int aiUnitCount,
|
||||
int humanUnitCount,
|
||||
bool defenderToggle) -> GameStateW;
|
||||
|
||||
private:
|
||||
// Helper functions for building game state components
|
||||
static auto
|
||||
AddPlayerInfo(flatbuffers::FlatBufferBuilder& fbb, int playerId, bool isDefender, int food)
|
||||
-> flatbuffers::Offset<net::eagle0::shardok::storage::fb::PlayerInfo>;
|
||||
|
||||
static auto AddGenericUnit(
|
||||
PlayerId playerId,
|
||||
UnitId unitId,
|
||||
const net::eagle0::shardok::storage::fb::Coords& location,
|
||||
int profession,
|
||||
int battalionType,
|
||||
int startingPositionIndex = -1) -> net::eagle0::shardok::storage::fb::Unit;
|
||||
|
||||
// Battalion type constants (matching Unity client)
|
||||
static constexpr int HEAVY_INFANTRY_BATTALION_TYPE = 4;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
#endif // EAGLE0_PERFORMANCETESTGAMESTATEBUILDER_HPP
|
||||
@@ -129,7 +129,7 @@ auto ShardokGameController::LockedCheckOneAICommand() -> bool {
|
||||
|
||||
const PlayerId currentPid = engine->GetCurrentPlayerId();
|
||||
if (const shared_ptr<ShardokAIClient> currentPlayerClient = LockedAIClientForPid(currentPid)) {
|
||||
const int index = currentPlayerClient->ChooseCommandIndex(*engine);
|
||||
const int index = currentPlayerClient->ChooseCommandIndex(*engine).chosenIndex;
|
||||
|
||||
engine->PostCommand(currentPid, index);
|
||||
LockedNotifyClients();
|
||||
|
||||
@@ -9,17 +9,15 @@
|
||||
#ifndef AvailableCommandsFactory_hpp
|
||||
#define AvailableCommandsFactory_hpp
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCommand.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/unit/Unit.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using std::optional;
|
||||
using std::unique_ptr;
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using UnitIdOptional = optional<UnitId>;
|
||||
|
||||
class AvailableCommandsFactory {
|
||||
|
||||
@@ -1,5 +1,20 @@
|
||||
load("//tools:copts.bzl", "COPTS")
|
||||
|
||||
cc_library(
|
||||
name = "game_state_w",
|
||||
srcs = ["GameStateW.cpp"],
|
||||
hdrs = ["GameStateW.hpp"],
|
||||
copts = COPTS,
|
||||
visibility = ["//visibility:public"],
|
||||
deps = [
|
||||
":shardok_c_types",
|
||||
"//src/main/cpp/net/eagle0/common:container_utils",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:unit_cc_fbs",
|
||||
],
|
||||
)
|
||||
|
||||
cc_library(
|
||||
name = "engine",
|
||||
srcs = ["ShardokEngine.cpp"],
|
||||
@@ -7,6 +22,7 @@ cc_library(
|
||||
copts = COPTS,
|
||||
visibility = ["//visibility:public"],
|
||||
deps = [
|
||||
":game_state_w",
|
||||
":unit_placement_info",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/actions:perform_undead_commands_action",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/actions:update_game_status_action",
|
||||
@@ -15,7 +31,6 @@ cc_library(
|
||||
"//src/main/cpp/net/eagle0/shardok/library/util:game_state_validator",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/view_filters:action_result_filter",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/view_filters:game_state_filter",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/protobuf/net/eagle0/shardok/storage:action_with_resulting_state_cc_proto",
|
||||
],
|
||||
)
|
||||
@@ -117,10 +132,9 @@ cc_library(
|
||||
copts = COPTS,
|
||||
visibility = ["//src/main/cpp/net/eagle0/shardok/library:__subpackages__"],
|
||||
deps = [
|
||||
":game_state_w",
|
||||
":shardok_exception",
|
||||
"//src/main/cpp/net/eagle0/common:random_generator",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/protobuf/net/eagle0/shardok/storage:action_result_cc_proto",
|
||||
],
|
||||
)
|
||||
|
||||
@@ -0,0 +1,125 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-21.
|
||||
//
|
||||
|
||||
#include "GameStateW.hpp"
|
||||
|
||||
#include "src/main/cpp/net/eagle0/common/ContainerUtils.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
auto GameStateW::GetOccupant(const net::eagle0::shardok::storage::fb::Coords& coords) const
|
||||
-> const Unit* {
|
||||
const auto* state = Get();
|
||||
if (!state || !state->hex_map()) { return nullptr; }
|
||||
|
||||
const int16_t rowCount = state->hex_map()->row_count();
|
||||
const int16_t columnCount = state->hex_map()->column_count();
|
||||
|
||||
// Check bounds
|
||||
if (coords.row() < 0 || coords.row() >= rowCount || coords.column() < 0 ||
|
||||
coords.column() >= columnCount) {
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
// Fast path: use bitfield cache if available
|
||||
if (state->occupied_tiles() && !state->occupied_tiles()->empty()) {
|
||||
const size_t tileIndex = coords.row() * columnCount + coords.column();
|
||||
const size_t expectedBitfieldSize = (rowCount * columnCount + 7) / 8; // Ceiling division
|
||||
|
||||
if (state->occupied_tiles()->size() == expectedBitfieldSize) {
|
||||
const size_t byteIndex = tileIndex / 8;
|
||||
const size_t bitOffset = tileIndex % 8;
|
||||
const uint8_t byte = state->occupied_tiles()->Get(byteIndex);
|
||||
const bool isOccupied = (byte & (1 << bitOffset)) != 0;
|
||||
|
||||
if (!isOccupied) {
|
||||
return nullptr; // Fast path: definitely no unit here (90% of cases)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Slow path: O(n) search through units
|
||||
// Used when bitfield not available OR when bitfield indicates occupation
|
||||
if (!state->units()) { return nullptr; }
|
||||
|
||||
for (int i = 0; i < state->units()->size(); ++i) {
|
||||
const auto* unit = state->units()->Get(i);
|
||||
if (unit && unit->status() == net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT &&
|
||||
unit->location().row() == coords.row() &&
|
||||
unit->location().column() == coords.column()) {
|
||||
return unit;
|
||||
}
|
||||
}
|
||||
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
auto GameStateW::GetKnownEnemyOccupant(
|
||||
PlayerId playerId,
|
||||
const std::vector<PlayerId>& allyPids,
|
||||
const net::eagle0::shardok::storage::fb::Coords& coords) const -> const Unit* {
|
||||
const auto* occupant = GetOccupant(coords);
|
||||
if (occupant) {
|
||||
if (!occupant->hidden() && occupant->player_id() != playerId &&
|
||||
!common::Contains(allyPids, occupant->player_id())) {
|
||||
return occupant;
|
||||
}
|
||||
}
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
void GameStateW::UpdateOccupiedTile(
|
||||
const net::eagle0::shardok::storage::fb::Coords& oldCoords,
|
||||
const net::eagle0::shardok::storage::fb::Coords& newCoords) {
|
||||
const auto* state = Get();
|
||||
auto* mutableOccupiedTiles = (*this)->mutable_occupied_tiles();
|
||||
if (!state || !state->hex_map() || !mutableOccupiedTiles) { return; }
|
||||
|
||||
const int16_t rowCount = state->hex_map()->row_count();
|
||||
const int16_t columnCount = state->hex_map()->column_count();
|
||||
|
||||
// Clear old position in bitfield
|
||||
if (oldCoords.row() >= 0 && oldCoords.row() < rowCount && oldCoords.column() >= 0 &&
|
||||
oldCoords.column() < columnCount) {
|
||||
const size_t tileIndex = oldCoords.row() * columnCount + oldCoords.column();
|
||||
const size_t byteIndex = tileIndex / 8;
|
||||
const size_t bitOffset = tileIndex % 8;
|
||||
if (byteIndex < mutableOccupiedTiles->size()) {
|
||||
uint8_t byte = mutableOccupiedTiles->Get(byteIndex);
|
||||
byte &= ~(1 << bitOffset); // Clear the bit
|
||||
mutableOccupiedTiles->Mutate(byteIndex, byte);
|
||||
}
|
||||
}
|
||||
|
||||
// Set new position in bitfield
|
||||
if (newCoords.row() >= 0 && newCoords.row() < rowCount && newCoords.column() >= 0 &&
|
||||
newCoords.column() < columnCount) {
|
||||
const size_t tileIndex = newCoords.row() * columnCount + newCoords.column();
|
||||
const size_t byteIndex = tileIndex / 8;
|
||||
const size_t bitOffset = tileIndex % 8;
|
||||
if (byteIndex < mutableOccupiedTiles->size()) {
|
||||
uint8_t byte = mutableOccupiedTiles->Get(byteIndex);
|
||||
byte |= (1 << bitOffset); // Set the bit
|
||||
mutableOccupiedTiles->Mutate(byteIndex, byte);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
auto GameStateW::GetOccupiedTilesBitfield() const -> const flatbuffers::Vector<uint8_t>* {
|
||||
const auto* state = Get();
|
||||
if (!state || !state->hex_map()) { return nullptr; }
|
||||
|
||||
if (!state->occupied_tiles() || state->occupied_tiles()->empty()) { return nullptr; }
|
||||
|
||||
// Verify the bitfield size matches expected map size
|
||||
const int16_t rowCount = state->hex_map()->row_count();
|
||||
const int16_t columnCount = state->hex_map()->column_count();
|
||||
const size_t expectedBitfieldSize = (rowCount * columnCount + 7) / 8;
|
||||
|
||||
if (state->occupied_tiles()->size() != expectedBitfieldSize) { return nullptr; }
|
||||
|
||||
return state->occupied_tiles();
|
||||
}
|
||||
|
||||
} // namespace shardok
|
||||
@@ -0,0 +1,109 @@
|
||||
//
|
||||
// Created by Dan Crosby on 2025-01-15.
|
||||
//
|
||||
|
||||
#ifndef EAGLE0_GAMESTATEW_HPP
|
||||
#define EAGLE0_GAMESTATEW_HPP
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCTypes.h"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/unit.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
/**
|
||||
* @class GameStateW
|
||||
* @brief A wrapper class for the FlatBuffer-generated GameState type.
|
||||
*
|
||||
* GameStateW extends the Wrapper class to provide additional functionality
|
||||
* for working with the net::eagle0::shardok::storage::fb::GameState type.
|
||||
* It inherits all constructors and assignment operators from the base Wrapper
|
||||
* class, enabling seamless integration with the underlying FlatBuffer type.
|
||||
*
|
||||
* This class is part of the shardok namespace and is designed to simplify
|
||||
* interactions with the GameState FlatBuffer type while maintaining the
|
||||
* flexibility and functionality of the Wrapper base class.
|
||||
*/
|
||||
class GameStateW : public Wrapper<net::eagle0::shardok::storage::fb::GameState> {
|
||||
public:
|
||||
using BaseType = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using Unit = net::eagle0::shardok::storage::fb::Unit;
|
||||
|
||||
// Inherit all constructors from Wrapper
|
||||
using BaseType::BaseType;
|
||||
|
||||
// Default constructor
|
||||
GameStateW() : BaseType() {}
|
||||
|
||||
// Copy constructor
|
||||
GameStateW(const GameStateW& other) : BaseType(other) {}
|
||||
|
||||
// Move constructor
|
||||
GameStateW(GameStateW&& other) noexcept : BaseType(std::move(other)) {}
|
||||
|
||||
// Copy assignment
|
||||
GameStateW& operator=(const GameStateW& other) {
|
||||
BaseType::operator=(other);
|
||||
return *this;
|
||||
}
|
||||
|
||||
// Move assignment
|
||||
GameStateW& operator=(GameStateW&& other) noexcept {
|
||||
BaseType::operator=(std::move(other));
|
||||
return *this;
|
||||
}
|
||||
|
||||
// Constructor from base type
|
||||
GameStateW(const BaseType& base) : BaseType(base) {}
|
||||
GameStateW(BaseType&& base) : BaseType(std::move(base)) {}
|
||||
|
||||
/**
|
||||
* @brief Get the unit occupying the specified coordinates using occupied tiles bitfield.
|
||||
* @param coords The coordinates to check.
|
||||
* @return Pointer to the unit at the coordinates, or nullptr if none.
|
||||
*
|
||||
* Fast path: O(1) bitfield check for empty tiles (~90% of cases).
|
||||
* Slow path: O(n) unit search only when bitfield indicates occupation (~10% of cases).
|
||||
*/
|
||||
[[nodiscard]] auto GetOccupant(const net::eagle0::shardok::storage::fb::Coords& coords) const
|
||||
-> const Unit*;
|
||||
|
||||
/**
|
||||
* @brief Get the known enemy unit occupying the specified coordinates using occupied tiles
|
||||
* bitfield.
|
||||
* @param playerId The player ID to check enemies for.
|
||||
* @param allyPids Vector of allied player IDs.
|
||||
* @param coords The coordinates to check.
|
||||
* @return Pointer to the enemy unit at the coordinates, or nullptr if none.
|
||||
*
|
||||
* Uses the bitfield-optimized GetOccupant() internally.
|
||||
*/
|
||||
[[nodiscard]] auto GetKnownEnemyOccupant(
|
||||
PlayerId playerId,
|
||||
const std::vector<PlayerId>& allyPids,
|
||||
const net::eagle0::shardok::storage::fb::Coords& coords) const -> const Unit*;
|
||||
|
||||
/**
|
||||
* @brief Update the occupied tiles bitfield when a unit changes position.
|
||||
* @param oldCoords The previous coordinates (use {-1, -1} if unit was off-map).
|
||||
* @param newCoords The new coordinates (use {-1, -1} if unit is now off-map).
|
||||
*/
|
||||
void UpdateOccupiedTile(
|
||||
const net::eagle0::shardok::storage::fb::Coords& oldCoords,
|
||||
const net::eagle0::shardok::storage::fb::Coords& newCoords);
|
||||
|
||||
/**
|
||||
* @brief Get the occupied tiles bitfield for efficient tile occupancy checking.
|
||||
* @return Pointer to the bitfield data, or nullptr if not available.
|
||||
*
|
||||
* Returns the raw bitfield where bit at index (row*column_count + col) indicates
|
||||
* if that tile is occupied. Useful for caching the bitfield to avoid repeated
|
||||
* GameStateW lookups in performance-critical code like MoveCommand.
|
||||
*/
|
||||
[[nodiscard]] auto GetOccupiedTilesBitfield() const -> const flatbuffers::Vector<uint8_t>*;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
#endif // EAGLE0_GAMESTATEW_HPP
|
||||
@@ -14,7 +14,7 @@ using std::vector;
|
||||
|
||||
auto ShardokAction::Execute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results = InternalExecute(currentState, generator);
|
||||
|
||||
return results;
|
||||
@@ -22,7 +22,7 @@ auto ShardokAction::Execute(
|
||||
|
||||
auto ShardokAction::ExecuteWithRoll(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator,
|
||||
const std::shared_ptr<RandomGenerator>& generator,
|
||||
const std::optional<int32_t> roll) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results = InternalExecuteWithRoll(currentState, generator, roll);
|
||||
|
||||
|
||||
@@ -13,14 +13,12 @@
|
||||
|
||||
#include "ShardokException.hpp"
|
||||
#include "src/main/cpp/net/eagle0/common/RandomGenerator.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/storage/action_result.pb.h"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using net::eagle0::shardok::storage::ActionResult;
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using std::shared_ptr;
|
||||
using std::vector;
|
||||
using PercentileRollOdds = net::eagle0::shardok::storage::Odds;
|
||||
@@ -39,13 +37,13 @@ private:
|
||||
// override that one and get the default behavior here.
|
||||
[[nodiscard]] virtual auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> std::vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> std::vector<ActionResult> {
|
||||
return InternalExecuteWithRoll(currentState, generator, std::optional<int32_t>());
|
||||
}
|
||||
|
||||
[[nodiscard]] virtual auto InternalExecuteWithRoll(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator,
|
||||
const std::shared_ptr<RandomGenerator>& generator,
|
||||
std::optional<int32_t> roll) const -> std::vector<ActionResult> {
|
||||
throw ShardokClientErrorException("Roll not supported");
|
||||
}
|
||||
@@ -58,11 +56,11 @@ public:
|
||||
|
||||
[[nodiscard]] auto Execute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> std::vector<ActionResult>;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> std::vector<ActionResult>;
|
||||
|
||||
[[nodiscard]] auto ExecuteWithRoll(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator,
|
||||
const std::shared_ptr<RandomGenerator>& generator,
|
||||
std::optional<int32_t> roll) const -> std::vector<ActionResult>;
|
||||
};
|
||||
|
||||
|
||||
@@ -37,11 +37,6 @@ using net::eagle0::shardok::storage::ShardokActionWithResultingState;
|
||||
using GameStatusProto = net::eagle0::shardok::common::GameStatus;
|
||||
using TileModifierProto = net::eagle0::shardok::common::TileModifier;
|
||||
|
||||
[[nodiscard]] auto ShardokEngine::GetCurrentGameState() const
|
||||
-> net::eagle0::shardok::storage::fb::GameState const * {
|
||||
return gameState.Get();
|
||||
}
|
||||
|
||||
[[nodiscard]] auto ShardokEngine::GetCurrentGameStateBytes() const -> byte_vector {
|
||||
return gameState.ToByteVector();
|
||||
}
|
||||
@@ -97,7 +92,7 @@ void ShardokEngine::ApplyAndAddActionResults(const vector<ActionResultProto> &re
|
||||
}
|
||||
|
||||
void ShardokEngine::ApplyAndAddActionResult(const ActionResultProto &result) {
|
||||
MutatingApplyResult(gameState, result, settingsGetter);
|
||||
gameState = ApplyResult(std::move(gameState), result, settingsGetter);
|
||||
|
||||
if (trackHistory) {
|
||||
actionHistory.emplace_back();
|
||||
@@ -114,7 +109,7 @@ ShardokEngine::ShardokEngine(
|
||||
settingsGetter(settings->GetGetter()),
|
||||
availableCommandsFactory(
|
||||
AvailableCommandsFactory::MakeAvailableCommandsFactory(settingsGetter)),
|
||||
gameState(fb::GameStateW::FromByteString(history.back().state_after_fb())),
|
||||
gameState(GameStateW::FromByteString(history.back().state_after_fb())),
|
||||
trackHistory(trackHistory),
|
||||
actionHistory(history),
|
||||
criticalTileCoords(gameState->hex_map()) {}
|
||||
@@ -184,7 +179,7 @@ auto ShardokEngine::GetGameStateView(const PlayerId askingPlayer) const
|
||||
const ShardokActionWithResultingState &awrs : newHistory) {
|
||||
GameStateView viewAfter = GameStateFilteredForPlayer(
|
||||
settingsGetter,
|
||||
fb::GameStateW::FromByteString(awrs.state_after_fb()),
|
||||
GameStateW::FromByteString(awrs.state_after_fb()),
|
||||
askingPlayer);
|
||||
|
||||
if (auto filteredResult = ActionResultFilteredForPlayer(
|
||||
@@ -197,7 +192,7 @@ auto ShardokEngine::GetGameStateView(const PlayerId askingPlayer) const
|
||||
filteredResult.has_value()) {
|
||||
filteredHistory.push_back(*filteredResult);
|
||||
}
|
||||
previousState = fb::GameStateW::FromByteString(awrs.state_after_fb());
|
||||
previousState = GameStateW::FromByteString(awrs.state_after_fb());
|
||||
previousStatePtr = previousState.Get();
|
||||
previousView = viewAfter;
|
||||
}
|
||||
@@ -219,7 +214,7 @@ auto ShardokEngine::GetUnitById(const PlayerId askingPlayer, const UnitId unitId
|
||||
}
|
||||
|
||||
void ShardokEngine::PostWhileCurrentPlayerHasOnlyOneOption(
|
||||
const std::shared_ptr<RandomGenerator> &randomGenerator) {
|
||||
std::shared_ptr<RandomGenerator> randomGenerator) {
|
||||
while (GetGameStatus()->state() ==
|
||||
net::eagle0::shardok::storage::fb::GameStatus_::State_GAME_RUNNING &&
|
||||
GetCurrentPlayerId() != UNCONTROLLED_PLAYER_ID) {
|
||||
@@ -460,7 +455,7 @@ void ShardokEngine::HandleActionResult(
|
||||
const Coords modifiedCoords = FromCoordsProto(modifierWithCoords.coords());
|
||||
const TileModifierProto &modifier = modifierWithCoords.modifiers();
|
||||
|
||||
const Unit *occupant = Occupant(GetCurrentGameState()->units(), modifiedCoords);
|
||||
const Unit *occupant = gameState.GetOccupant(modifiedCoords);
|
||||
// Check for swept away hero
|
||||
if (const Terrain *terrain = GetTerrain(GetCurrentGameState()->hex_map(), modifiedCoords);
|
||||
occupant && IsWater(terrain->type()) && !IsTraversible(modifier) &&
|
||||
@@ -587,6 +582,7 @@ void AddUnits(vector<net::eagle0::shardok::storage::ResolvedUnit> &to, const Uni
|
||||
break;
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVE_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_NEVER_ENTERED_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT:
|
||||
ru.set_status(
|
||||
net::eagle0::shardok::storage::ResolvedUnit_UnitStatus_NEVER_ENTERED_UNIT);
|
||||
break;
|
||||
@@ -604,7 +600,7 @@ auto ShardokEngine::EndGameUnits() const -> vector<net::eagle0::shardok::storage
|
||||
"Trying to get the end game units before the game is over");
|
||||
}
|
||||
|
||||
const auto *gs = GetCurrentGameState();
|
||||
const auto &gs = GetCurrentGameState();
|
||||
|
||||
vector<net::eagle0::shardok::storage::ResolvedUnit> endgameUnits;
|
||||
AddUnits(endgameUnits, *gs->units());
|
||||
|
||||
@@ -20,7 +20,6 @@
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/GameStateHelpers.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/map/CoordsSet.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/api/action_result_view.pb.h"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/api/game_state_view.pb.h"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/api/unit_view.pb.h"
|
||||
@@ -35,7 +34,6 @@ using std::vector;
|
||||
|
||||
using net::eagle0::shardok::api::UnitView;
|
||||
using PlayerInfoProto = net::eagle0::shardok::common::PlayerInfo;
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using net::eagle0::shardok::storage::ShardokActionWithResultingState;
|
||||
using HexMapProto = net::eagle0::shardok::common::HexMap;
|
||||
|
||||
@@ -62,15 +60,14 @@ private:
|
||||
|
||||
[[nodiscard]] auto HandleUnitFallingIntoWater(
|
||||
const Terrain *terrain,
|
||||
const net::eagle0::shardok::storage::fb::Unit *unit,
|
||||
const fb::Unit *unit,
|
||||
std::shared_ptr<RandomGenerator> randomGenerator) const -> vector<ActionResult>;
|
||||
|
||||
void HandleActionResult(
|
||||
const ActionResult &actionResult,
|
||||
const std::shared_ptr<RandomGenerator> &randomGenerator);
|
||||
|
||||
[[nodiscard]] auto GetUnit(const UnitId uid) const
|
||||
-> const net::eagle0::shardok::storage::fb::Unit * {
|
||||
[[nodiscard]] auto GetUnit(const UnitId uid) const -> const fb::Unit * {
|
||||
return GetCurrentGameState()->units()->Get(uid);
|
||||
}
|
||||
|
||||
@@ -114,8 +111,7 @@ public:
|
||||
|
||||
[[nodiscard]] auto GetGameStateAtStartOfAction(ActionId startingActionId) const -> GameStateW;
|
||||
|
||||
[[nodiscard]] auto GetCurrentGameState() const
|
||||
-> net::eagle0::shardok::storage::fb::GameState const *;
|
||||
[[nodiscard]] auto GetCurrentGameState() const -> const GameStateW & { return gameState; }
|
||||
|
||||
[[nodiscard]] auto GetCurrentGameStateBytes() const -> byte_vector;
|
||||
|
||||
@@ -129,7 +125,7 @@ public:
|
||||
|
||||
// Controller API
|
||||
[[nodiscard]] auto GetGameHistory(ActionId lastUpdatedActionId) const
|
||||
-> vector<net::eagle0::shardok::storage::ShardokActionWithResultingState>;
|
||||
-> vector<ShardokActionWithResultingState>;
|
||||
|
||||
[[nodiscard]] auto GetUnfilteredHistoryCount() const -> size_t {
|
||||
return actionHistory.size() + startingHistoryCount;
|
||||
@@ -145,8 +141,7 @@ public:
|
||||
[[nodiscard]] auto GetFilteredGameHistory(PlayerId askingPlayer) const
|
||||
-> vector<net::eagle0::shardok::api::ActionResultView>;
|
||||
|
||||
[[nodiscard]] auto GetUnitById(PlayerId askingPlayer, UnitId unitId) const
|
||||
-> net::eagle0::shardok::api::UnitView;
|
||||
[[nodiscard]] auto GetUnitById(PlayerId askingPlayer, UnitId unitId) const -> UnitView;
|
||||
|
||||
void PostPlacementCommands(
|
||||
PlayerId player,
|
||||
@@ -161,8 +156,7 @@ public:
|
||||
std::shared_ptr<RandomGenerator> randomGenerator = nullptr,
|
||||
std::optional<int32_t> roll = std::nullopt);
|
||||
|
||||
void PostWhileCurrentPlayerHasOnlyOneOption(
|
||||
const std::shared_ptr<RandomGenerator> &randomGenerator);
|
||||
void PostWhileCurrentPlayerHasOnlyOneOption(std::shared_ptr<RandomGenerator> randomGenerator);
|
||||
auto PostWhilePlayerHasOnlyOneOption(
|
||||
PlayerId playerId,
|
||||
std::shared_ptr<RandomGenerator> randomGenerator) -> bool;
|
||||
@@ -180,7 +174,7 @@ public:
|
||||
[[nodiscard]] auto GetMonth() const -> int { return GetCurrentGameState()->month(); }
|
||||
|
||||
[[nodiscard]] auto GetPlayerInfos() const -> vector<PlayerInfoProto> {
|
||||
const auto *currentGameState = GetCurrentGameState();
|
||||
const auto ¤tGameState = GetCurrentGameState();
|
||||
vector<PlayerInfoProto> protos{};
|
||||
for (const auto *const piFB : *currentGameState->player_infos()) {
|
||||
protos.push_back(fb::ToPlayerInfoProto(piFB));
|
||||
@@ -188,18 +182,18 @@ public:
|
||||
return protos;
|
||||
}
|
||||
|
||||
auto GetGameStatus() const -> const net::eagle0::shardok::storage::fb::GameStatus * {
|
||||
[[nodiscard]] auto GetGameStatus() const
|
||||
-> const net::eagle0::shardok::storage::fb::GameStatus * {
|
||||
return GetCurrentGameState()->status();
|
||||
}
|
||||
|
||||
auto GetGameSettings() const -> GameSettingsSPtr { return gameSettings; }
|
||||
[[nodiscard]] auto GetGameSettings() const -> GameSettingsSPtr { return gameSettings; }
|
||||
|
||||
static inline auto GameIsOver(const net::eagle0::shardok::storage::fb::GameStatus *status)
|
||||
-> bool {
|
||||
static inline auto GameIsOver(const fb::GameStatus *status) -> bool {
|
||||
return (status->state() == net::eagle0::shardok::storage::fb::GameStatus_::State_VICTORY);
|
||||
}
|
||||
|
||||
inline auto GameIsOver() const -> bool { return GameIsOver(GetGameStatus()); }
|
||||
[[nodiscard]] inline auto GameIsOver() const -> bool { return GameIsOver(GetGameStatus()); }
|
||||
};
|
||||
} // namespace shardok
|
||||
|
||||
|
||||
@@ -10,14 +10,10 @@
|
||||
#define MeteorCastActionFactory_hpp
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokAction.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class MeteorCastActionFactory {
|
||||
private:
|
||||
const SettingsGetter settings;
|
||||
|
||||
+2
-2
@@ -28,7 +28,7 @@ auto PlayerSetupCommandFactory::AddAvailablePlaceAndHideUnitCommandsForOneUnit(
|
||||
|
||||
CoordsSet unusedStartingPositions(gameState->hex_map());
|
||||
for (const Coords *possiblePosition : *thisUnitStartingPositions) {
|
||||
if (!Occupant(gameState->units(), *possiblePosition)) {
|
||||
if (!gameState.GetOccupant(*possiblePosition)) {
|
||||
unusedStartingPositions.Add(*possiblePosition);
|
||||
}
|
||||
}
|
||||
@@ -37,7 +37,7 @@ auto PlayerSetupCommandFactory::AddAvailablePlaceAndHideUnitCommandsForOneUnit(
|
||||
CoordsSet unusedHidingPositions(gameState->hex_map());
|
||||
|
||||
for (const Coords &possibleHidingPosition : GetAllCoords(gameState->hex_map())) {
|
||||
if (!Occupant(gameState->units(), possibleHidingPosition)) {
|
||||
if (!gameState.GetOccupant(possibleHidingPosition)) {
|
||||
const Terrain *terrain = GetTerrain(gameState->hex_map(), possibleHidingPosition);
|
||||
if (AllowsHiding(terrain)) { unusedHidingPositions.Add(possibleHidingPosition); }
|
||||
}
|
||||
|
||||
+1
-3
@@ -5,14 +5,12 @@
|
||||
#ifndef EAGLE0_PLAYERSETUPCOMMANDFACTORY_HPP
|
||||
#define EAGLE0_PLAYERSETUPCOMMANDFACTORY_HPP
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCommand.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using Unit = net::eagle0::shardok::storage::fb::Unit;
|
||||
|
||||
class PlayerSetupCommandFactory {
|
||||
|
||||
+1
-3
@@ -5,13 +5,11 @@
|
||||
#ifndef EAGLE0_UNDEADCHANGEACTIONFACTORY_HPP
|
||||
#define EAGLE0_UNDEADCHANGEACTIONFACTORY_HPP
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokAction.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class UndeadChangeActionFactory {
|
||||
private:
|
||||
|
||||
+4
-9
@@ -69,9 +69,9 @@ public:
|
||||
|
||||
virtual ~ActionPointDistances() = default;
|
||||
|
||||
virtual auto Distance(int fromIndex, int toIndex) -> DIST_T = 0;
|
||||
virtual auto Distance(int fromIndex, int toIndex) const -> DIST_T = 0;
|
||||
|
||||
virtual auto Distance(const Coords &from, const Coords &to) -> DIST_T = 0;
|
||||
virtual auto Distance(const Coords &from, const Coords &to) const -> DIST_T = 0;
|
||||
};
|
||||
|
||||
class OnDemandActionPointDistances final : public ActionPointDistances {
|
||||
@@ -81,11 +81,6 @@ private:
|
||||
|
||||
vector<shared_future<vector<int16_t>>> distances;
|
||||
|
||||
static void fill(
|
||||
vector<std::unordered_map<size_t, std::shared_ptr<ActionPointDistances>>> &vec) {
|
||||
for (int i = 0; i < 6; i++) { vec.emplace_back(); }
|
||||
}
|
||||
|
||||
public:
|
||||
explicit OnDemandActionPointDistances(
|
||||
const HexMap *map,
|
||||
@@ -95,11 +90,11 @@ public:
|
||||
|
||||
~OnDemandActionPointDistances() override = default;
|
||||
|
||||
auto Distance(const int fromIndex, const int toIndex) -> int16_t override {
|
||||
auto Distance(const int fromIndex, const int toIndex) const -> int16_t override {
|
||||
return distances[fromIndex].get()[toIndex];
|
||||
}
|
||||
|
||||
auto Distance(const Coords &from, const Coords &to) -> int16_t override {
|
||||
auto Distance(const Coords &from, const Coords &to) const -> int16_t override {
|
||||
return Distance(ToIndex(from), ToIndex(to));
|
||||
}
|
||||
};
|
||||
|
||||
+170
-75
@@ -4,41 +4,110 @@
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_point_distances/ActionPointDistancesCache.hpp"
|
||||
|
||||
#include <algorithm>
|
||||
#include <chrono>
|
||||
#include <unordered_map>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_point_distances/FixedActionPointDistances.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/HexMapHelpers.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/map/HexMapHasher.hpp"
|
||||
|
||||
#define CACHE_STATS_LOGGING_ false
|
||||
#define CACHE_STATS_FREQUENCY_SECONDS_ 1
|
||||
|
||||
namespace shardok {
|
||||
|
||||
// Thread-local cache to avoid mutex contention for repeated lookups
|
||||
thread_local std::unordered_map<FullCacheKey, shared_ptr<ActionPointDistances>, FullCacheKeyHash>
|
||||
localCache;
|
||||
// Thread-local cache definition - stores raw pointers for zero overhead access
|
||||
thread_local ActionPointDistancesCache::TLSCache ActionPointDistancesCache::tlsCache;
|
||||
|
||||
#if CACHE_STATS_LOGGING_
|
||||
// Thread-local statistics for performance monitoring
|
||||
thread_local struct {
|
||||
int persistentHits = 0;
|
||||
int persistentMisses = 0;
|
||||
int localHits = 0;
|
||||
int localMisses = 0;
|
||||
int sharedAccesses = 0;
|
||||
int evictionEvents = 0;
|
||||
int apdLoadedFromFile = 0;
|
||||
int apdGeneratedFresh = 0;
|
||||
std::chrono::steady_clock::time_point lastReportTime = std::chrono::steady_clock::now();
|
||||
} cacheStats;
|
||||
|
||||
// Helper function to print stats periodically
|
||||
static void MaybePrintCacheStats() {
|
||||
auto now = std::chrono::steady_clock::now();
|
||||
if (std::chrono::duration_cast<std::chrono::seconds>(now - cacheStats.lastReportTime).count() >=
|
||||
CACHE_STATS_FREQUENCY_SECONDS_) {
|
||||
printf("Thread cache stats: %d persistent hits, %d persistent misses, %d local hits, "
|
||||
"%d local misses, %d shared accesses, %d eviction events, "
|
||||
"%d APD loaded from file, %d APD generated fresh\n",
|
||||
cacheStats.persistentHits,
|
||||
cacheStats.persistentMisses,
|
||||
cacheStats.localHits,
|
||||
cacheStats.localMisses,
|
||||
cacheStats.sharedAccesses,
|
||||
cacheStats.evictionEvents,
|
||||
cacheStats.apdLoadedFromFile,
|
||||
cacheStats.apdGeneratedFresh);
|
||||
cacheStats.lastReportTime = now;
|
||||
}
|
||||
}
|
||||
#endif
|
||||
|
||||
class BadHashException : public std::exception {
|
||||
class BadHashException final : public std::exception {
|
||||
public:
|
||||
BadHashException() = default;
|
||||
|
||||
[[nodiscard]] auto what() const noexcept -> const char* override { return "Bad map hash!"; };
|
||||
};
|
||||
|
||||
constexpr int kBattalionTypeCount = 6;
|
||||
// Helper function to check if any ice is present on the map
|
||||
static auto HasIceOnMap(const HexMap* map) -> bool {
|
||||
return std::ranges::any_of(*map->terrain(), [](const auto* terrain) {
|
||||
return terrain->modifier().ice().present();
|
||||
});
|
||||
}
|
||||
|
||||
ActionPointDistancesCache::ActionPointDistancesCache() {
|
||||
bravingDistances.resize(kBattalionTypeCount);
|
||||
noBravingDistances.resize(kBattalionTypeCount);
|
||||
// Helper function to create a copy of the map with all ice removed
|
||||
// This ensures AI pathfinding treats ice as impassable water
|
||||
// This should only be called if ice is present on the map
|
||||
static auto CreateIceClearedMap(const HexMap* map) -> fb::HexMapW {
|
||||
using namespace flatbuffers;
|
||||
using namespace net::eagle0::shardok::storage::fb;
|
||||
|
||||
// First, create a full copy using the efficient memcpy approach
|
||||
auto mapCopy = fb::CopyHexMap(map);
|
||||
|
||||
// Now modify the ice on the mutable copy
|
||||
auto* mutableMap = mapCopy.Get();
|
||||
const auto* terrainVec = mutableMap->mutable_terrain();
|
||||
|
||||
for (size_t i = 0; i < terrainVec->size(); i++) {
|
||||
// Only process tiles with ice
|
||||
if (auto* terrain = terrainVec->GetMutableObject(i); terrain->modifier().ice().present()) {
|
||||
terrain->mutable_modifier().mutable_ice().mutate_present(false);
|
||||
terrain->mutable_modifier().mutable_ice().mutate_integrity(0.0f);
|
||||
}
|
||||
}
|
||||
|
||||
// Recompute the modifier hash using the canonical function
|
||||
// This ensures consistency with the standard hash computation
|
||||
mutableMap->mutate_modifier_hash(GetModifierHash(mutableMap));
|
||||
|
||||
return mapCopy;
|
||||
}
|
||||
|
||||
auto ActionPointDistancesCache::MakeCacheKey(
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
const bool includeBravingWater,
|
||||
const int braveWaterActionPointCost) -> FullCacheKey {
|
||||
return FullCacheKey{
|
||||
mapId,
|
||||
static_cast<int>(battalionType->typeId),
|
||||
includeBravingWater,
|
||||
braveWaterActionPointCost >= 0 ? braveWaterActionPointCost : 0};
|
||||
}
|
||||
|
||||
auto ActionPointDistancesCache::GetMapId(const HexMap* map) -> MapId {
|
||||
@@ -47,105 +116,131 @@ auto ActionPointDistancesCache::GetMapId(const HexMap* map) -> MapId {
|
||||
|
||||
return MapId{.terrainTypesId = map->base_hash(), .modifierId = modifierId};
|
||||
}
|
||||
void ActionPointDistancesCache::ConsolidateThreadLocalCache_Racy() {
|
||||
persistentCache.insert(std::begin(sharedDistances), std::end(sharedDistances));
|
||||
sharedDistances.clear();
|
||||
|
||||
auto ActionPointDistancesCache::Get(
|
||||
// Clear the current thread's cache since persistent cache now has everything
|
||||
tlsCache.clear();
|
||||
}
|
||||
|
||||
auto ActionPointDistancesCache::GetRaw(
|
||||
const HexMap* map,
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
const bool includeBravingWater,
|
||||
const int braveWaterActionPointCost) -> std::shared_ptr<ActionPointDistances> {
|
||||
// Create full cache key for thread-local lookup
|
||||
FullCacheKey fullKey{
|
||||
.mapId = mapId,
|
||||
.battalionTypeId = battalionType->typeId,
|
||||
.includeBravingWater = includeBravingWater,
|
||||
.braveWaterCost = braveWaterActionPointCost};
|
||||
const int braveWaterActionPointCost) -> const ActionPointDistances* {
|
||||
// Create cache key first - check cache before expensive ice-clearing operation
|
||||
auto cacheKey =
|
||||
MakeCacheKey(mapId, battalionType, includeBravingWater, braveWaterActionPointCost);
|
||||
|
||||
// Check the persistent map first
|
||||
if (auto persistentIt = persistentCache.find(cacheKey); persistentIt != persistentCache.end()) {
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.persistentHits++;
|
||||
MaybePrintCacheStats();
|
||||
#endif
|
||||
// Return directly from persistent cache without TLS insertion
|
||||
// This avoids the overhead of thread-local storage operations on hot path
|
||||
return persistentIt->second.rawPtr;
|
||||
}
|
||||
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.persistentMisses++;
|
||||
#endif
|
||||
|
||||
// Check thread-local cache first (no locks needed!)
|
||||
auto localIt = localCache.find(fullKey);
|
||||
if (localIt != localCache.end()) {
|
||||
if (auto localIt = tlsCache.find(cacheKey); localIt != tlsCache.end()) {
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.localHits++;
|
||||
// Print stats every 100 requests to monitor effectiveness
|
||||
if ((cacheStats.localHits + cacheStats.localMisses) % 100 == 0) {
|
||||
printf("Thread cache stats: %d local hits, %d misses, %d shared accesses, %d eviction "
|
||||
"events\n",
|
||||
cacheStats.localHits,
|
||||
cacheStats.localMisses,
|
||||
cacheStats.sharedAccesses,
|
||||
cacheStats.evictionEvents);
|
||||
}
|
||||
MaybePrintCacheStats();
|
||||
#endif
|
||||
return localIt->second; // Direct shared_ptr access - no atomic lock() needed!
|
||||
return localIt->second.rawPtr; // Raw pointer - zero overhead access!
|
||||
}
|
||||
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.localMisses++;
|
||||
#endif
|
||||
|
||||
// Thread-local cache miss - access shared cache
|
||||
auto result = GetFromSharedCache(
|
||||
map,
|
||||
mapId,
|
||||
// Check shared cache before expensive ice-clearing operation
|
||||
shared_ptr<ActionPointDistances> sharedResult;
|
||||
if (sharedDistances.if_contains(cacheKey, [&sharedResult](const auto& kv) {
|
||||
sharedResult = kv.second;
|
||||
})) {
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.sharedAccesses++;
|
||||
#endif
|
||||
// Cache hit in shared cache - store in thread-local cache and return
|
||||
tlsCache.emplace(cacheKey, CacheEntry(sharedResult));
|
||||
#if CACHE_STATS_LOGGING_
|
||||
MaybePrintCacheStats();
|
||||
#endif
|
||||
return sharedResult.get();
|
||||
}
|
||||
|
||||
// Cache miss in both caches - need to create ice-cleared map for pathfinding computation
|
||||
const bool hasIce = HasIceOnMap(map);
|
||||
|
||||
// Declaring here to keep the copied map in scope
|
||||
const HexMap* mapToUse = map;
|
||||
|
||||
// ReSharper disable once CppTooWideScope
|
||||
// ReSharper disable once CppJoinDeclarationAndAssignment
|
||||
fb::HexMapW iceClearedMap;
|
||||
if (hasIce) {
|
||||
// Create ice-cleared map for pathfinding
|
||||
// This prevents AI from considering ice as a valid path toward enemies
|
||||
iceClearedMap = CreateIceClearedMap(map);
|
||||
mapToUse = iceClearedMap.Get();
|
||||
}
|
||||
|
||||
// Create new pathfinding result using factory method
|
||||
auto creationResult = FixedActionPointDistances::Create(
|
||||
mapToUse,
|
||||
mapId.terrainTypesId,
|
||||
mapId.modifierId,
|
||||
battalionType,
|
||||
includeBravingWater,
|
||||
braveWaterActionPointCost);
|
||||
|
||||
#if CACHE_STATS_LOGGING_
|
||||
// Track whether this was loaded from file or generated fresh
|
||||
if (creationResult.loadedFromFile) {
|
||||
cacheStats.apdLoadedFromFile++;
|
||||
} else {
|
||||
cacheStats.apdGeneratedFresh++;
|
||||
}
|
||||
#endif
|
||||
|
||||
auto result = creationResult.apd;
|
||||
|
||||
// Store in shared cache
|
||||
sharedDistances.lazy_emplace_l(
|
||||
cacheKey,
|
||||
[](const auto& kv) { /* already checked above */ },
|
||||
[=](const auto& ctor) { ctor(cacheKey, result); });
|
||||
|
||||
// Cache result locally for future lookups by this thread
|
||||
localCache[fullKey] = result;
|
||||
// Store both shared_ptr and raw pointer for hybrid access
|
||||
tlsCache.emplace(cacheKey, CacheEntry(result));
|
||||
|
||||
// Prevent unbounded cache growth - limit to reasonable size
|
||||
if (localCache.size() > 100) {
|
||||
if (tlsCache.size() > 100) {
|
||||
// Simple eviction: clear half the cache when it gets too large
|
||||
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.evictionEvents++;
|
||||
#endif
|
||||
auto it = localCache.begin();
|
||||
std::advance(it, localCache.size() / 2);
|
||||
localCache.erase(localCache.begin(), it);
|
||||
auto it = tlsCache.begin();
|
||||
std::advance(it, tlsCache.size() / 2);
|
||||
tlsCache.erase(tlsCache.begin(), it);
|
||||
}
|
||||
|
||||
return result;
|
||||
return result.get();
|
||||
}
|
||||
|
||||
auto ActionPointDistancesCache::GetFromSharedCache(
|
||||
const HexMap* map,
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
const bool includeBravingWater,
|
||||
const int braveWaterActionPointCost) -> std::shared_ptr<ActionPointDistances> {
|
||||
#if CACHE_STATS_LOGGING_
|
||||
cacheStats.sharedAccesses++;
|
||||
#endif
|
||||
void ActionPointDistancesCache::ClearThreadLocalCache() { tlsCache.clear(); }
|
||||
|
||||
auto& vec = includeBravingWater ? bravingDistances : noBravingDistances;
|
||||
auto& distancesMap = vec[battalionType->typeId];
|
||||
|
||||
shared_ptr<ActionPointDistances> toReturn;
|
||||
|
||||
// Try shared read lock first (multiple threads can read simultaneously)
|
||||
if (distancesMap.if_contains(mapId, [&toReturn](const auto& kv) { toReturn = kv.second; })) {
|
||||
return toReturn;
|
||||
}
|
||||
|
||||
// Cache miss - need to create new entry with exclusive access
|
||||
distancesMap.lazy_emplace_l(
|
||||
mapId,
|
||||
[&toReturn](const auto& kv) { toReturn = kv.second; },
|
||||
[=, &toReturn](const auto& ctor) {
|
||||
auto newDistances = std::make_shared<FixedActionPointDistances>(
|
||||
map,
|
||||
mapId.terrainTypesId,
|
||||
mapId.modifierId,
|
||||
battalionType,
|
||||
includeBravingWater,
|
||||
braveWaterActionPointCost);
|
||||
ctor(mapId, newDistances);
|
||||
toReturn = newDistances;
|
||||
});
|
||||
|
||||
return toReturn;
|
||||
}
|
||||
size_t ActionPointDistancesCache::GetThreadLocalCacheSize() { return tlsCache.size(); }
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
+55
-27
@@ -20,21 +20,15 @@ namespace shardok {
|
||||
using std::shared_ptr;
|
||||
|
||||
struct MapId {
|
||||
int64_t terrainTypesId;
|
||||
int64_t modifierId;
|
||||
|
||||
friend size_t hash_value(const MapId& id) {
|
||||
return gtl::HashState::combine(0, id.terrainTypesId, id.modifierId);
|
||||
}
|
||||
uint64_t terrainTypesId;
|
||||
uint64_t modifierId;
|
||||
|
||||
auto operator==(const MapId& other) const -> bool {
|
||||
return terrainTypesId == other.terrainTypesId && modifierId == other.modifierId;
|
||||
}
|
||||
};
|
||||
|
||||
using APDKey = MapId;
|
||||
|
||||
// Extended key for thread-local cache that includes battalion type
|
||||
// Unified cache key for both thread-safe and thread-local caches
|
||||
struct FullCacheKey {
|
||||
MapId mapId;
|
||||
int battalionTypeId;
|
||||
@@ -51,47 +45,81 @@ struct FullCacheKey {
|
||||
// Hash function for FullCacheKey
|
||||
struct FullCacheKeyHash {
|
||||
size_t operator()(const FullCacheKey& key) const {
|
||||
return gtl::HashState::combine(
|
||||
hash_value(key.mapId),
|
||||
key.battalionTypeId,
|
||||
key.includeBravingWater,
|
||||
key.braveWaterCost);
|
||||
// Pack small fields into a single 64-bit value
|
||||
uint64_t packed = (static_cast<uint64_t>(key.battalionTypeId) << 32) |
|
||||
(static_cast<uint64_t>(key.braveWaterCost) << 1) |
|
||||
(key.includeBravingWater ? 1 : 0);
|
||||
|
||||
// Hash MapId fields directly instead of going through hash_value(MapId)
|
||||
return gtl::HashState::combine(0, key.mapId.terrainTypesId, key.mapId.modifierId, packed);
|
||||
}
|
||||
};
|
||||
|
||||
class ActionPointDistancesCache {
|
||||
private:
|
||||
struct CacheEntry {
|
||||
shared_ptr<ActionPointDistances> sharedPtr;
|
||||
const ActionPointDistances* rawPtr;
|
||||
|
||||
explicit CacheEntry(shared_ptr<ActionPointDistances> ptr)
|
||||
: sharedPtr(std::move(ptr)),
|
||||
rawPtr(sharedPtr.get()) {}
|
||||
};
|
||||
|
||||
// Tier 1: persistent map. This is NOT safe to write to while reads may be happening.
|
||||
using PersistentMap = gtl::flat_hash_map<FullCacheKey, CacheEntry, FullCacheKeyHash>;
|
||||
|
||||
PersistentMap persistentCache;
|
||||
|
||||
using APDMap = gtl::parallel_flat_hash_map<
|
||||
APDKey,
|
||||
FullCacheKey,
|
||||
shared_ptr<ActionPointDistances>,
|
||||
gtl::priv::hash_default_hash<APDKey>,
|
||||
gtl::priv::hash_default_eq<APDKey>,
|
||||
std::allocator<std::pair<const APDKey, shared_ptr<ActionPointDistances>>>,
|
||||
FullCacheKeyHash,
|
||||
std::equal_to<FullCacheKey>,
|
||||
std::allocator<std::pair<const FullCacheKey, shared_ptr<ActionPointDistances>>>,
|
||||
6,
|
||||
std::mutex>;
|
||||
|
||||
vector<APDMap> noBravingDistances;
|
||||
vector<APDMap> bravingDistances;
|
||||
APDMap sharedDistances;
|
||||
|
||||
// Private method for accessing shared cache with improved locking
|
||||
auto GetFromSharedCache(
|
||||
const HexMap* map,
|
||||
using TLSCache = gtl::flat_hash_map<FullCacheKey, CacheEntry, FullCacheKeyHash>;
|
||||
static thread_local TLSCache tlsCache;
|
||||
|
||||
// Epoch system removed - TLS cache uses size-based eviction instead
|
||||
|
||||
// Helper to build cache key
|
||||
static auto MakeCacheKey(
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost) -> shared_ptr<ActionPointDistances>;
|
||||
int braveWaterActionPointCost) -> FullCacheKey;
|
||||
|
||||
public:
|
||||
explicit ActionPointDistancesCache();
|
||||
explicit ActionPointDistancesCache() {
|
||||
// Pre-size persistent cache to reduce hash collisions
|
||||
// Estimate: ~12 entries from pre-fetching + ~50-100 entries during gameplay
|
||||
persistentCache.reserve(128);
|
||||
}
|
||||
|
||||
auto Get(
|
||||
// Returns raw pointer for zero overhead access
|
||||
// Lifetime guaranteed by shared cache ownership
|
||||
auto GetRaw(
|
||||
const HexMap* map,
|
||||
const MapId& mapId,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost = -1) -> shared_ptr<ActionPointDistances>;
|
||||
int braveWaterActionPointCost = -1) -> const ActionPointDistances*;
|
||||
|
||||
static auto GetMapId(const HexMap* map) -> MapId;
|
||||
|
||||
// Consolidate the thread-safe cache into the persistent cache and clear
|
||||
// the current thread's local cache. This is only safe if we know reads
|
||||
// are not happening from other threads.
|
||||
void ConsolidateThreadLocalCache_Racy();
|
||||
|
||||
// Cache management methods
|
||||
static void ClearThreadLocalCache();
|
||||
static size_t GetThreadLocalCacheSize();
|
||||
};
|
||||
|
||||
using APDCache = shared_ptr<ActionPointDistancesCache>;
|
||||
|
||||
+26
-10
@@ -26,14 +26,24 @@ void FixedActionPointDistances::SetCacheDirectory(const string& newDir) {
|
||||
|
||||
static thread_local byte_vector _scratch;
|
||||
|
||||
FixedActionPointDistances::FixedActionPointDistances(
|
||||
FixedActionPointDistances::FixedActionPointDistances(const HexMap* map, int columnCount)
|
||||
: ActionPointDistances(columnCount) {}
|
||||
|
||||
auto FixedActionPointDistances::Create(
|
||||
const HexMap* map,
|
||||
int64_t terrainTypesHash,
|
||||
int64_t modifierHash,
|
||||
const BattalionTypeSPtr& battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost)
|
||||
: ActionPointDistances(map->column_count()) {
|
||||
int braveWaterActionPointCost) -> CreationResult {
|
||||
// Create the object using private constructor
|
||||
auto apd = std::shared_ptr<FixedActionPointDistances>(
|
||||
new FixedActionPointDistances(map, map->column_count()));
|
||||
|
||||
CreationResult result;
|
||||
result.apd = apd;
|
||||
result.loadedFromFile = false;
|
||||
|
||||
string path = "";
|
||||
|
||||
if (!cacheDirectory.empty()) {
|
||||
@@ -55,22 +65,26 @@ FixedActionPointDistances::FixedActionPointDistances(
|
||||
const int indexCount = map->row_count() * map->column_count();
|
||||
|
||||
if (!path.empty() && FilesystemUtils::FileExistsAtPath(path)) {
|
||||
distances.resize(indexCount);
|
||||
apd->distances.resize(indexCount);
|
||||
// load from file
|
||||
const auto& bytes = _scratch.ReplaceWithPath(path);
|
||||
const auto* ptr = reinterpret_cast<const DIST_T*>(bytes.data());
|
||||
|
||||
for (int fromIndex = 0; fromIndex < indexCount; fromIndex++) {
|
||||
distances[fromIndex].insert(distances[fromIndex].end(), &(ptr[0]), &(ptr[indexCount]));
|
||||
apd->distances[fromIndex].insert(
|
||||
apd->distances[fromIndex].end(),
|
||||
&(ptr[0]),
|
||||
&(ptr[indexCount]));
|
||||
ptr += indexCount;
|
||||
}
|
||||
result.loadedFromFile = true;
|
||||
} else {
|
||||
_scratch.reserve(indexCount * indexCount * sizeof(DIST_T));
|
||||
|
||||
vector<std::future<vector<vector<DIST_T>>>> futures(indexCount);
|
||||
|
||||
auto braveWaterPossibleCoords =
|
||||
includeBravingWater ? BraveWaterPossibleCoords(map) : nullptr;
|
||||
includeBravingWater ? apd->BraveWaterPossibleCoords(map) : nullptr;
|
||||
|
||||
int chunkSize = (indexCount + ASYNC_COUNT - 1) / ASYNC_COUNT;
|
||||
// Break into chunks for async
|
||||
@@ -83,7 +97,7 @@ FixedActionPointDistances::FixedActionPointDistances(
|
||||
for (int i = 0; i < chunkSize; i++) {
|
||||
const auto fromIndex = chunkStartIndex + i;
|
||||
if (fromIndex >= indexCount) { continue; }
|
||||
chunkVec.push_back(GenerateDistances(
|
||||
chunkVec.push_back(ActionPointDistances::GenerateDistances(
|
||||
fromIndex,
|
||||
map,
|
||||
includeBravingWater,
|
||||
@@ -95,18 +109,20 @@ FixedActionPointDistances::FixedActionPointDistances(
|
||||
});
|
||||
}
|
||||
|
||||
distances.reserve(indexCount);
|
||||
apd->distances.reserve(indexCount);
|
||||
_scratch.clear();
|
||||
_scratch.reserve(indexCount * indexCount * sizeof(DIST_T));
|
||||
|
||||
for (int chunkIdx = 0; chunkIdx < ASYNC_COUNT; chunkIdx++) {
|
||||
auto resultsVec = futures[chunkIdx].get();
|
||||
distances.insert(distances.end(), resultsVec.begin(), resultsVec.end());
|
||||
apd->distances.insert(apd->distances.end(), resultsVec.begin(), resultsVec.end());
|
||||
for (const auto& r : resultsVec) { _scratch.append(r); }
|
||||
}
|
||||
|
||||
if (!path.empty()) { FilesystemUtils::AtomicallySaveToPath(path, _scratch); }
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
} // namespace shardok
|
||||
} // namespace shardok
|
||||
|
||||
+16
-4
@@ -17,31 +17,43 @@ using std::vector;
|
||||
using BattalionTypeSPtr = std::shared_ptr<const BattalionType>;
|
||||
|
||||
class FixedActionPointDistances final : public ActionPointDistances {
|
||||
public:
|
||||
struct CreationResult {
|
||||
std::shared_ptr<FixedActionPointDistances> apd;
|
||||
bool loadedFromFile;
|
||||
};
|
||||
|
||||
private:
|
||||
vector<vector<DIST_T>> distances;
|
||||
|
||||
inline static string cacheDirectory = "";
|
||||
|
||||
// Private constructor - use Create factory method instead
|
||||
explicit FixedActionPointDistances(const HexMap *map, int columnCount);
|
||||
|
||||
public:
|
||||
static void SetCacheDirectory(const string &newDir);
|
||||
|
||||
explicit FixedActionPointDistances(
|
||||
// Factory method to create FixedActionPointDistances with metadata
|
||||
static auto Create(
|
||||
const HexMap *map,
|
||||
int64_t terrainTypesHash,
|
||||
int64_t modifierHash,
|
||||
const BattalionTypeSPtr &battalionType,
|
||||
bool includeBravingWater,
|
||||
int braveWaterActionPointCost = -1);
|
||||
int braveWaterActionPointCost = -1) -> CreationResult;
|
||||
|
||||
~FixedActionPointDistances() override = default;
|
||||
|
||||
auto Distance(const int fromIndex, const int toIndex) -> DIST_T override {
|
||||
[[nodiscard]] auto Distance(const int fromIndex, const int toIndex) const -> DIST_T override {
|
||||
return distances[fromIndex][toIndex];
|
||||
}
|
||||
|
||||
auto Distance(const Coords &from, const Coords &to) -> DIST_T override {
|
||||
[[nodiscard]] auto Distance(const Coords &from, const Coords &to) const -> DIST_T override {
|
||||
return Distance(ToIndex(from), ToIndex(to));
|
||||
}
|
||||
|
||||
friend struct CreationResult;
|
||||
};
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
+54
-14
@@ -153,28 +153,60 @@ auto ApplyResults(
|
||||
|
||||
void MutatingAddUnits(GameStateW &mutatingState, const ActionResultProto &result) {
|
||||
UnitId maxChangedUnitId = 0;
|
||||
bool needsVectorExpansion = false;
|
||||
bool needsReservedSlotConversion = false;
|
||||
|
||||
// First pass: check what kind of modifications we need
|
||||
for (const auto &unitBytes : result.changed_units_fb()) {
|
||||
const auto *unit = (Unit *)unitBytes.data();
|
||||
maxChangedUnitId = std::max(maxChangedUnitId, unit->unit_id());
|
||||
|
||||
if (unit->unit_id() >= mutatingState->units()->size()) {
|
||||
// Unit ID beyond vector size - must expand
|
||||
needsVectorExpansion = true;
|
||||
break; // No point checking further
|
||||
} else if (
|
||||
mutatingState->units()->Get(unit->unit_id())->status() ==
|
||||
net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT) {
|
||||
// Unit wants to use a reserved slot
|
||||
needsReservedSlotConversion = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (maxChangedUnitId < mutatingState->units()->size()) {
|
||||
// Early return if no modifications needed
|
||||
if (!needsVectorExpansion && !needsReservedSlotConversion) { return; }
|
||||
|
||||
// If we need to expand the vector, go straight to slow path
|
||||
if (needsVectorExpansion) {
|
||||
int unitsNeeded = 1 + maxChangedUnitId - mutatingState->units()->size();
|
||||
mutatingState = CopyWithExtraUnits(mutatingState, unitsNeeded);
|
||||
return;
|
||||
} else {
|
||||
mutatingState = CopyWithExtraUnits(
|
||||
mutatingState,
|
||||
1 + maxChangedUnitId - mutatingState->units()->size());
|
||||
}
|
||||
|
||||
// Otherwise, we just need to convert reserved slots (fast path)
|
||||
if (needsReservedSlotConversion) {
|
||||
// Convert reserved slots to real units in place
|
||||
// We only need to process the units that are being changed
|
||||
for (const auto &unitBytes : result.changed_units_fb()) {
|
||||
const auto *unit = (Unit *)unitBytes.data();
|
||||
auto *mutableUnit = mutatingState->mutable_units()->GetMutableObject(unit->unit_id());
|
||||
if (mutableUnit->status() ==
|
||||
net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT) {
|
||||
// Convert this reserved slot to a real unit
|
||||
mutableUnit->mutate_status(
|
||||
net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT);
|
||||
// The calling code will set the specific values it needs
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
auto ApplyResult(
|
||||
const GameStateW &startingState,
|
||||
GameStateW startingState,
|
||||
const ActionResultProto &result,
|
||||
const SettingsGetter &settings) -> GameStateW {
|
||||
auto endGS = startingState;
|
||||
MutatingApplyResult(endGS, result, settings);
|
||||
|
||||
return endGS;
|
||||
MutatingApplyResult(startingState, result, settings);
|
||||
return startingState;
|
||||
}
|
||||
|
||||
void MutatingApplyResult(
|
||||
@@ -306,10 +338,18 @@ void MutatingApplyResult(
|
||||
settings);
|
||||
}
|
||||
|
||||
fb::ApplyUnit(
|
||||
mutatingGameState->units()->GetMutableObject(changedUnit->unit_id()),
|
||||
changedUnit,
|
||||
status);
|
||||
// Capture old position before applying changes
|
||||
auto *mutableUnit = mutatingGameState->units()->GetMutableObject(changedUnit->unit_id());
|
||||
const auto oldLocation = mutableUnit->location();
|
||||
|
||||
fb::ApplyUnit(mutableUnit, changedUnit, status);
|
||||
|
||||
// Update occupied tiles bitfield if position changed
|
||||
const auto &newLocation = changedUnit->location();
|
||||
if (oldLocation.row() != newLocation.row() ||
|
||||
oldLocation.column() != newLocation.column()) {
|
||||
mutatingGameState.UpdateOccupiedTile(oldLocation, newLocation);
|
||||
}
|
||||
|
||||
if (battalionSizeBefore != battalionSizeAfter) {
|
||||
if (changedUnit->battalion().type() ==
|
||||
|
||||
+2
-4
@@ -11,13 +11,11 @@
|
||||
|
||||
#include <flatbuffers/flatbuffers.h>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/protobuf/net/eagle0/shardok/storage/action_result.pb.h"
|
||||
|
||||
namespace shardok {
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using ActionResultProto = net::eagle0::shardok::storage::ActionResult;
|
||||
|
||||
// flatbuffers
|
||||
@@ -26,7 +24,7 @@ void MutatingApplyResult(
|
||||
const ActionResultProto& actionResult,
|
||||
const SettingsGetter& settings);
|
||||
auto ApplyResult(
|
||||
const GameStateW& startingState,
|
||||
GameStateW startingState,
|
||||
const ActionResultProto& actionResult,
|
||||
const SettingsGetter& settings) -> GameStateW;
|
||||
auto ApplyResults(
|
||||
|
||||
@@ -12,11 +12,10 @@ cc_library(
|
||||
deps = [
|
||||
":game_state_copier",
|
||||
":unit_helpers",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/map:hex_map_hasher",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/unit",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/util:hex_map_utils",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/protobuf/net/eagle0/shardok/storage:action_result_cc_proto",
|
||||
],
|
||||
)
|
||||
@@ -27,8 +26,7 @@ cc_library(
|
||||
hdrs = ["GameStateCopier.hpp"],
|
||||
copts = COPTS,
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/shardok/library/fb_helpers:flatbuffer_wrapper",
|
||||
"//src/main/flatbuffer/net/eagle0/shardok/storage:game_state_cc_fbs",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:game_state_w",
|
||||
],
|
||||
)
|
||||
|
||||
|
||||
@@ -4,6 +4,8 @@
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_result_applier/GameStateCopier.hpp"
|
||||
|
||||
#include <cstring>
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using Unit = net::eagle0::shardok::storage::fb::Unit;
|
||||
@@ -14,12 +16,57 @@ auto CopyWithExtraUnits(const GameStateW& original, int additionalCount) -> Game
|
||||
net::eagle0::shardok::storage::fb::GameStateT endGST;
|
||||
startGS->UnPackTo(&endGST);
|
||||
|
||||
for (int i = 0; i < additionalCount; i++) {
|
||||
// Add the requested units plus some extra slack for future use
|
||||
int extraSlack = std::max(5, additionalCount * 2);
|
||||
for (int i = 0; i < additionalCount + extraSlack; i++) {
|
||||
Unit unit;
|
||||
unit.mutate_unit_id(endGST.units.size());
|
||||
unit.mutate_unit_id(static_cast<int16_t>(endGST.units.size()));
|
||||
if (i < additionalCount) {
|
||||
unit.mutate_status(net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT);
|
||||
} else {
|
||||
unit.mutate_status(net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT);
|
||||
// Set safe defaults for reserved slots
|
||||
unit.mutate_player_id(-1);
|
||||
unit.mutate_eagle_player_id(-1);
|
||||
unit.mutable_location().mutate_row(-1);
|
||||
unit.mutable_location().mutate_column(-1);
|
||||
}
|
||||
endGST.units.push_back(unit);
|
||||
}
|
||||
|
||||
// Copy occupied tiles bitfield from original GameState (much faster than O(n) rebuild)
|
||||
if (startGS->occupied_tiles() && startGS->hex_map()) {
|
||||
const size_t originalBitfieldSize = startGS->occupied_tiles()->size();
|
||||
endGST.occupied_tiles.resize(originalBitfieldSize);
|
||||
|
||||
// Fast O(bitfield_bytes) copy instead of O(units) rebuild
|
||||
std::memcpy(
|
||||
endGST.occupied_tiles.data(),
|
||||
startGS->occupied_tiles()->data(),
|
||||
originalBitfieldSize);
|
||||
} else if (endGST.hex_map) {
|
||||
// Fallback: create new bitfield only if original doesn't have one
|
||||
const int16_t rowCount = endGST.hex_map->row_count;
|
||||
const int16_t columnCount = endGST.hex_map->column_count;
|
||||
const size_t mapSize = rowCount * columnCount;
|
||||
const size_t bitfieldSize = (mapSize + 7) / 8; // Ceiling division
|
||||
endGST.occupied_tiles.resize(bitfieldSize, 0); // Initialize all bits to 0 (empty)
|
||||
|
||||
// Populate bitfield based on unit positions (O(n) fallback)
|
||||
for (const auto& unit : endGST.units) {
|
||||
if (unit.status() == net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT) {
|
||||
const auto& location = unit.location();
|
||||
if (location.row() >= 0 && location.row() < rowCount && location.column() >= 0 &&
|
||||
location.column() < columnCount) {
|
||||
const size_t tileIndex = location.row() * columnCount + location.column();
|
||||
const size_t byteIndex = tileIndex / 8;
|
||||
const size_t bitOffset = tileIndex % 8;
|
||||
endGST.occupied_tiles[byteIndex] |= (1 << bitOffset); // Set the bit
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
flatbuffers::FlatBufferBuilder newFbb;
|
||||
newFbb.ForceDefaults(true);
|
||||
newFbb.Finish(net::eagle0::shardok::storage::fb::GameState::Pack(newFbb, &endGST));
|
||||
|
||||
@@ -5,13 +5,10 @@
|
||||
#ifndef EAGLE0_GAMESTATECOPIER_HPP
|
||||
#define EAGLE0_GAMESTATECOPIER_HPP
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
auto CopyWithExtraUnits(const GameStateW& original, int additionalCount) -> GameStateW;
|
||||
|
||||
} // namespace shardok
|
||||
|
||||
@@ -11,7 +11,7 @@
|
||||
namespace shardok {
|
||||
auto DefensiveAmbushAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
const auto results = CombatUtils::InternalPerformMelee(
|
||||
ActionCost(ActionCost::standard, 0),
|
||||
currentState->units()->Get(ambusherId),
|
||||
|
||||
@@ -17,8 +17,10 @@ private:
|
||||
const SettingsGetter settings;
|
||||
|
||||
protected:
|
||||
auto InternalExecute(const GameStateW& currentState, std::shared_ptr<RandomGenerator> generator)
|
||||
const -> vector<ActionResult> override;
|
||||
auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
public:
|
||||
DefensiveAmbushAction(
|
||||
|
||||
@@ -15,7 +15,7 @@ using net::eagle0::shardok::common::GameStatus;
|
||||
|
||||
auto EndPlayerSetupCommand::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResultProto> {
|
||||
auto startingGameState = gameState;
|
||||
|
||||
ActionResultProto endResult{};
|
||||
|
||||
@@ -8,15 +8,12 @@
|
||||
#include <optional>
|
||||
#include <utility>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokCommand.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class EndPlayerSetupCommand : public ShardokCommand {
|
||||
private:
|
||||
const PlayerId nextPid;
|
||||
@@ -26,7 +23,8 @@ private:
|
||||
protected:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
public:
|
||||
explicit EndPlayerSetupCommand(
|
||||
|
||||
@@ -101,7 +101,7 @@ FallIntoWaterAction::FallIntoWaterAction(
|
||||
|
||||
auto FallIntoWaterAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results{};
|
||||
|
||||
auto fallerTerrain =
|
||||
@@ -150,8 +150,7 @@ auto FallIntoWaterAction::InternalExecute(
|
||||
Terrain bestTerrain{};
|
||||
|
||||
for (const auto &adjWithTerrain : adjacentCoordsAndTerrain) {
|
||||
const auto *possibleOccupant =
|
||||
Occupant(currentState->units(), adjWithTerrain.adjacentCoords);
|
||||
const auto *possibleOccupant = currentState.GetOccupant(adjWithTerrain.adjacentCoords);
|
||||
if (possibleOccupant && (possibleOccupant->player_id() == fallerAfter.player_id() ||
|
||||
!possibleOccupant->hidden())) {
|
||||
continue;
|
||||
@@ -172,7 +171,7 @@ auto FallIntoWaterAction::InternalExecute(
|
||||
}
|
||||
}
|
||||
|
||||
if (found && !Occupant(currentState->units(), bestCoords)) {
|
||||
if (found && !currentState.GetOccupant(bestCoords)) {
|
||||
PercentileRollOdds odds = EscapeChance(
|
||||
baseEscapeOdds,
|
||||
bestTerrain,
|
||||
|
||||
@@ -40,7 +40,8 @@ private:
|
||||
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const UnitId fallerId;
|
||||
const SettingsGetter settings;
|
||||
|
||||
@@ -24,7 +24,7 @@ FireOutAction::FireOutAction(
|
||||
|
||||
auto FireOutAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
const auto fireOutRoll = generator->Percentile();
|
||||
|
||||
ActionResult resultProto;
|
||||
|
||||
@@ -17,8 +17,10 @@ namespace shardok {
|
||||
|
||||
class FireOutAction : public ShardokAction {
|
||||
private:
|
||||
auto InternalExecute(const GameStateW& currentState, std::shared_ptr<RandomGenerator> generator)
|
||||
const -> vector<ActionResult> override;
|
||||
auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const Coords coords;
|
||||
const net::eagle0::shardok::storage::fb::TileModifier existingModifier;
|
||||
|
||||
@@ -24,7 +24,7 @@ FireSpreadAction::FireSpreadAction(
|
||||
|
||||
auto FireSpreadAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
const auto fireSpreadRoll = generator->Percentile();
|
||||
|
||||
if (PercentileRollSucceeds(fireSpreadOdds, fireSpreadRoll)) {
|
||||
|
||||
@@ -17,8 +17,10 @@ namespace shardok {
|
||||
|
||||
class FireSpreadAction : public ShardokAction {
|
||||
private:
|
||||
auto InternalExecute(const GameStateW& currentState, std::shared_ptr<RandomGenerator> generator)
|
||||
const -> vector<ActionResult> override;
|
||||
auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const Coords coords;
|
||||
const net::eagle0::shardok::storage::fb::TileModifier existingModifier;
|
||||
|
||||
@@ -41,7 +41,7 @@ auto effectiveIce(const TerrainProto& terr) -> double {
|
||||
|
||||
auto IceAdjustmentAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results{};
|
||||
|
||||
TerrainProto newTerrain{};
|
||||
|
||||
@@ -19,7 +19,8 @@ class IceAdjustmentAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const Coords coords;
|
||||
const Terrain terrain;
|
||||
|
||||
@@ -33,6 +33,7 @@ auto IsResolved(const net::eagle0::shardok::storage::fb::UnitStatus status) -> b
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_NORMAL_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVE_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_NEVER_ENTERED_UNIT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_RESERVED_SLOT:
|
||||
case net::eagle0::shardok::storage::fb::UnitStatus_UNKNOWN_UNIT: return false;
|
||||
}
|
||||
|
||||
@@ -43,7 +44,8 @@ class MeteorUnitDamageAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> override;
|
||||
const std::shared_ptr<RandomGenerator> &generator) const
|
||||
-> vector<ActionResultProto> override;
|
||||
|
||||
const SettingsGetter settings;
|
||||
const double attackerIntelligence;
|
||||
@@ -70,7 +72,7 @@ public:
|
||||
|
||||
auto MeteorUnitDamageAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResultProto> {
|
||||
CombatDamage attackerDamage =
|
||||
CombatDamage::Builder()
|
||||
.SetFire(attackerIntelligence * baseDamage * damageMultiplier)
|
||||
@@ -97,8 +99,10 @@ auto MeteorUnitDamageAction::InternalExecute(
|
||||
|
||||
class MeteorTileDamageAction : public ShardokAction {
|
||||
private:
|
||||
auto InternalExecute(const GameStateW ¤tState, std::shared_ptr<RandomGenerator> generator)
|
||||
const -> vector<ActionResultProto> override;
|
||||
auto InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
const std::shared_ptr<RandomGenerator> &generator) const
|
||||
-> vector<ActionResultProto> override;
|
||||
|
||||
const Terrain *terrain;
|
||||
const Coords coords;
|
||||
@@ -128,7 +132,7 @@ public:
|
||||
|
||||
auto MeteorTileDamageAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResultProto> {
|
||||
auto tm = fb::ToTileModifierProto(terrain->modifier());
|
||||
|
||||
MutatingAdjustBridgeIntegrity(&tm, integrityAdjustment);
|
||||
@@ -151,7 +155,7 @@ auto MeteorTileDamageAction::InternalExecute(
|
||||
|
||||
auto MeteorCastAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResultProto> {
|
||||
vector<ActionResultProto> allResults{};
|
||||
auto runningGameState = startingGameState;
|
||||
for (const UnitId &actorId : actorIds) {
|
||||
@@ -167,7 +171,7 @@ auto MeteorCastAction::PerformOneActorCast(
|
||||
vector<ActionResultProto> &results,
|
||||
const Unit *actorBefore,
|
||||
GameStateW &runningGameState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> GameStateW {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> GameStateW {
|
||||
const double actorIntelligence = actorBefore->attached_hero().wisdom();
|
||||
|
||||
ActionResultProto mainResult{};
|
||||
@@ -179,7 +183,7 @@ auto MeteorCastAction::PerformOneActorCast(
|
||||
results.push_back(mainResult);
|
||||
|
||||
const Coords target = actorBefore->attached_hero().profession_info().cast_target();
|
||||
const Unit *possibleOccupant = Occupant(runningGameState->units(), target);
|
||||
const Unit *possibleOccupant = runningGameState.GetOccupant(target);
|
||||
const Terrain *targetTerrain = GetTerrain(startingGameState->hex_map(), target);
|
||||
if (possibleOccupant) {
|
||||
// Direct damage action
|
||||
@@ -244,7 +248,7 @@ auto MeteorCastAction::PerformOneActorCast(
|
||||
for (const Coords &splashCoords : adjacentCoords) {
|
||||
const auto &splashTerrain = GetTerrain(runningGameState->hex_map(), splashCoords);
|
||||
|
||||
const Unit *splashOccupant = Occupant(runningGameState->units(), splashCoords);
|
||||
const Unit *splashOccupant = runningGameState.GetOccupant(splashCoords);
|
||||
if (splashOccupant) {
|
||||
MeteorUnitDamageAction splashUnitDamageAction(
|
||||
settings,
|
||||
@@ -297,7 +301,7 @@ auto MeteorCastAction::PerformOneActorCast(
|
||||
|
||||
// Check for fallen heroes
|
||||
for (const Coords &coords : destroyedBridgeOrIceTiles) {
|
||||
const auto *maybeOccupant = Occupant(runningGameState->units(), coords);
|
||||
const auto *maybeOccupant = runningGameState.GetOccupant(coords);
|
||||
if (maybeOccupant) {
|
||||
const BattalionTypeSPtr &battalionType =
|
||||
settings.GetBattalionType(maybeOccupant->battalion().type());
|
||||
|
||||
@@ -12,15 +12,12 @@
|
||||
#include <utility>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokAction.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using HexMap = net::eagle0::shardok::storage::fb::HexMap;
|
||||
using Unit = net::eagle0::shardok::storage::fb::Unit;
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class MeteorCastAction : public ShardokAction {
|
||||
private:
|
||||
@@ -29,11 +26,12 @@ private:
|
||||
vector<ActionResult>& results,
|
||||
const Unit* actorBefore,
|
||||
GameStateW& runningGameState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> GameStateW;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> GameStateW;
|
||||
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const vector<UnitId> actorIds;
|
||||
const GameStateW startingGameState;
|
||||
|
||||
@@ -135,7 +135,7 @@ auto NewWeather(
|
||||
|
||||
auto NewRoundAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResultProto> {
|
||||
vector<ActionResultProto> results{};
|
||||
|
||||
GameStateW runningGameState = startingGameState;
|
||||
|
||||
@@ -11,25 +11,24 @@
|
||||
|
||||
#include <utility>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokAction.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_factories/FireOutActionFactory.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_factories/FireSpreadActionFactory.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_factories/IceAndSnowAdjustmentActionFactory.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/action_factories/UndeadChangeActionFactory.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/game_state.hpp"
|
||||
#include "src/main/flatbuffer/net/eagle0/shardok/storage/hex_map.hpp"
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
using HexMap = net::eagle0::shardok::storage::fb::HexMap;
|
||||
|
||||
class NewRoundAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const GameStateW startingGameState;
|
||||
const SettingsGetter settings;
|
||||
|
||||
@@ -22,7 +22,7 @@ auto ChooseUndeadCommand(
|
||||
|
||||
auto PerformUndeadCommandsAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResultProto> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResultProto> {
|
||||
GameStateW runningGameState = startingGameState;
|
||||
vector<ActionResultProto> allResults{};
|
||||
|
||||
|
||||
@@ -13,13 +13,12 @@
|
||||
|
||||
namespace shardok {
|
||||
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class PerformUndeadCommandsAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const GameStateW& startingGameState;
|
||||
const SettingsGetter settings;
|
||||
|
||||
@@ -14,7 +14,7 @@ using net::eagle0::shardok::common::GameStatus;
|
||||
|
||||
[[nodiscard]] auto PlaceHiddenUnitCommand::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
auto actorAfter = *currentState->units()->Get(actorId);
|
||||
actorAfter.mutable_location() = target;
|
||||
actorAfter.mutate_hidden(true);
|
||||
|
||||
@@ -20,7 +20,8 @@ class PlaceHiddenUnitCommand : public ShardokCommand {
|
||||
protected:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const UnitId actorId;
|
||||
const Coords target;
|
||||
|
||||
@@ -13,7 +13,7 @@ using net::eagle0::shardok::common::GameStatus;
|
||||
|
||||
auto PlaceUnitCommand::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
auto actorAfter = *actor;
|
||||
actorAfter.mutable_location() = target;
|
||||
|
||||
|
||||
@@ -19,7 +19,8 @@ class PlaceUnitCommand : public ShardokCommand {
|
||||
protected:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const Unit* actor;
|
||||
const Coords target;
|
||||
|
||||
@@ -79,7 +79,7 @@ auto effectiveSnow(const TerrainProto& terr) -> double {
|
||||
|
||||
auto SnowAdjustmentAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results{};
|
||||
|
||||
TerrainProto newTerrain{};
|
||||
|
||||
@@ -19,7 +19,8 @@ class SnowAdjustmentAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const Coords coords;
|
||||
const Terrain terrain;
|
||||
|
||||
@@ -18,7 +18,7 @@ static auto RequiredDailyFood(const Unit& unit, const SettingsGetter& settingsGe
|
||||
|
||||
auto StartPlayerTurnAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
ActionResult result{};
|
||||
result.set_type(net::eagle0::shardok::common::ActionType::PLAYER_TURN_START);
|
||||
result.mutable_next_player()->set_value(newFactionId);
|
||||
|
||||
@@ -7,19 +7,18 @@
|
||||
|
||||
#include <utility>
|
||||
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/GameStateW.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/ShardokAction.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/fb_helpers/FlatbufferWrapper.hpp"
|
||||
#include "src/main/cpp/net/eagle0/shardok/library/settings/GameSettings.hpp"
|
||||
#include "src/main/flatbuffer//net/eagle0/shardok/storage/game_state.hpp"
|
||||
|
||||
namespace shardok {
|
||||
using GameStateW = Wrapper<net::eagle0::shardok::storage::fb::GameState>;
|
||||
|
||||
class StartPlayerTurnAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const GameStateW startingState;
|
||||
const PlayerId newFactionId;
|
||||
|
||||
@@ -12,7 +12,7 @@ namespace shardok {
|
||||
|
||||
auto UndeadChangeAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
if (undeadUnitIds.empty()) return {};
|
||||
|
||||
const int maxGrowthPer = (int)(reinforceRate * bodyCount / (double)undeadUnitIds.size());
|
||||
|
||||
@@ -20,7 +20,8 @@ using net::eagle0::shardok::common::Weather;
|
||||
class UndeadChangeAction : public ShardokAction {
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const vector<UnitId> undeadUnitIds;
|
||||
const int bodyCount;
|
||||
|
||||
@@ -10,7 +10,7 @@ namespace shardok {
|
||||
|
||||
auto UndeadFrozenAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
if (occupant->battalion().type() != net::eagle0::shardok::storage::fb::BattalionTypeId_UNDEAD)
|
||||
return {};
|
||||
|
||||
|
||||
@@ -18,7 +18,8 @@ class UndeadFrozenAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
// FIXME: this is OK for now since it's only called from the Freeze factory, but it really
|
||||
// shouldn't be holding onto the pointer like this
|
||||
|
||||
@@ -80,7 +80,7 @@ void UpdateGameStatusAction::ResolveHiddenLosers(ActionResult& actionResult) con
|
||||
|
||||
auto UpdateGameStatusAction::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
vector<ActionResult> results{};
|
||||
|
||||
// If the game has already ended, just return that state
|
||||
@@ -229,7 +229,7 @@ auto UpdateGameStatusAction::InternalExecute(
|
||||
// Check for attacker occupying castles & towns
|
||||
bool foundUncontrolledCriticalTile = false;
|
||||
for (const auto& criticalTile : criticalTileLocations) {
|
||||
const auto* possibleOccupant = Occupant(gameState->units(), criticalTile);
|
||||
const auto* possibleOccupant = currentState.GetOccupant(criticalTile);
|
||||
|
||||
if (!possibleOccupant) {
|
||||
foundUncontrolledCriticalTile = true;
|
||||
|
||||
@@ -20,7 +20,8 @@ class UpdateGameStatusAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const GameState* gameState;
|
||||
const CoordsSet criticalTileLocations;
|
||||
|
||||
@@ -12,7 +12,7 @@ namespace shardok {
|
||||
|
||||
auto UpdateOpponentKnowledgeAction::InternalExecute(
|
||||
const GameStateW ¤tState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator> &generator) const -> vector<ActionResult> {
|
||||
ActionResult result{};
|
||||
result.set_type(net::eagle0::shardok::common::ActionType::KNOWLEDGE_UPDATED);
|
||||
|
||||
@@ -39,7 +39,7 @@ auto UpdateOpponentKnowledgeAction::InternalExecute(
|
||||
|
||||
for (const Coords &adjCoords :
|
||||
HexMapUtils::GetAdjacentCoords(currentState->hex_map(), unit->location())) {
|
||||
const auto &occupantOptional = Occupant(currentState->units(), adjCoords);
|
||||
const auto &occupantOptional = currentState.GetOccupant(adjCoords);
|
||||
if (occupantOptional && occupantOptional->player_id() != unitPid) {
|
||||
MutatingBumpOpponentKnowledge(
|
||||
&unitAfter,
|
||||
|
||||
@@ -17,7 +17,8 @@ class UpdateOpponentKnowledgeAction : public ShardokAction {
|
||||
private:
|
||||
[[nodiscard]] auto InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> override;
|
||||
const std::shared_ptr<RandomGenerator>& generator) const
|
||||
-> vector<ActionResult> override;
|
||||
|
||||
const SettingsGetter settingsGetter;
|
||||
|
||||
|
||||
@@ -31,7 +31,7 @@ ArcheryCommand::ArcheryCommand(
|
||||
|
||||
auto ArcheryCommand::InternalExecuteWithRoll(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator,
|
||||
const std::shared_ptr<RandomGenerator>& generator,
|
||||
const std::optional<int32_t> roll) const -> vector<ActionResult> {
|
||||
const auto ambushRoll = generator->Percentile();
|
||||
const auto attackerRoll = roll.value_or(generator->OpenEndedPercentile());
|
||||
|
||||
@@ -24,7 +24,7 @@ private:
|
||||
protected:
|
||||
[[nodiscard]] auto InternalExecuteWithRoll(
|
||||
const GameStateW& currentState,
|
||||
std::shared_ptr<RandomGenerator> generator,
|
||||
const std::shared_ptr<RandomGenerator>& generator,
|
||||
std::optional<int32_t> roll) const -> vector<ActionResult> override;
|
||||
|
||||
const SettingsGetter settings;
|
||||
|
||||
@@ -425,6 +425,7 @@ cc_library(
|
||||
deps = [
|
||||
"//src/main/cpp/net/eagle0/shardok/library:battalion_type",
|
||||
"//src/main/cpp/net/eagle0/shardok/library:shardok_command",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/action_result_applier",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/actions:defensive_ambush_action",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/settings:game_settings",
|
||||
"//src/main/cpp/net/eagle0/shardok/library/unit",
|
||||
|
||||
@@ -16,7 +16,7 @@
|
||||
namespace shardok {
|
||||
auto BecomeOutlawCommand::InternalExecute(
|
||||
const GameStateW& currentState,
|
||||
const std::shared_ptr<RandomGenerator> generator) const -> vector<ActionResult> {
|
||||
const std::shared_ptr<RandomGenerator>& generator) const -> vector<ActionResult> {
|
||||
const auto roll = generator->Percentile();
|
||||
return ExecuteWithRoll(currentState, roll);
|
||||
}
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user