Compare commits

...
Author SHA1 Message Date
adminandClaude daee53bad6 Update complexity analysis for OrganizeTroopsCommand
After attempting migration, discovered OrganizeTroopsCommand is High
complexity, not Medium, because:
- BattalionNameGenerator still uses protobuf BattalionTypeId
- Would require cascading migrations of utility classes
- Mixed type system creates complex dependency issues

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-31 22:43:07 -07:00
+3 -3
View File
@@ -189,7 +189,7 @@ These commands have protobuf dependencies in their BUILD.bazel files:
| DiplomacyCommand.scala | `diplomacy_command` | `diplomacy_option`, `diplomacy_offer`, `available_command` | High - Complex diplomacy |
| FreeForAllDecisionCommand.scala | `free_for_all_decision_command` | `available_command`, `selected_command`, `action_result` | Medium - API layer |
| MarchCommand.scala | `march_command` | `available_command`, `battalion`, `game_state`, `tribute_amount` | High - Complex state |
| OrganizeTroopsCommand.scala | `organize_troops_command` | `action_result`, `battalion` | Medium - Military logic |
| OrganizeTroopsCommand.scala | `organize_troops_command` | `action_result`, `battalion`, `battalion_type` | **High - Requires BattalionNameGenerator migration** |
| ReconCommand.scala | `recon_command` | `available_command`, `selected_command`, `game_state` | Medium - API + state |
| ResolveAllianceOfferCommand.scala | `resolve_alliance_offer_command` | `diplomacy_offer`, `available_command`, `action_result` | High - Diplomacy |
| ResolveBreakAllianceCommand.scala | `resolve_break_alliance_command` | `diplomacy_offer`, `available_command`, `action_result` | High - Diplomacy |
@@ -208,11 +208,11 @@ These commands have protobuf dependencies in their BUILD.bazel files:
**Low Complexity (0 commands)**: Single protobuf dependency
- ~~All low complexity commands have been migrated~~
**Medium Complexity (5 commands)**: API layer or simple state dependencies
**Medium Complexity (4 commands)**: API layer or simple state dependencies
- Commands needing `available_command`/`selected_command` models
- Commands with `action_result` or simple `game_state` usage
**High Complexity (10 commands)**: Complex state or diplomacy
**High Complexity (11 commands)**: Complex state, diplomacy, or cascading dependencies
- All diplomacy resolution commands (6) - need complete diplomacy model migration
- Commands with complex `game_state` dependencies (4)