Use preincrement in test loops

src/test/cpp/net/eagle0/shardok/library/GtestExtensions.hpp

@@ -67,7 +67,7 @@ void EXPECT_CONTAINS(const VecT& vec, const T& obj) {
 
 template<class VecT, class F>
 auto CHECK_NOCONTAINS_WHERE(const VecT& vec, F where) -> bool {
-    for (size_t i = 0; i < vec.size(); i++) {
+    for (size_t i = 0; i < vec.size(); ++i) {
         if (where(vec[i])) {
             std::cout << "Found at index " << i << '\n';
             return false;

src/test/cpp/net/eagle0/shardok/library/PercentileRollDifficulty_test.cpp

@@ -18,7 +18,7 @@ TEST(PercentileRollOddsTests, singleStat_returnsExpected) {
     const std::vector<double> expectedBonuses =
             {-25.0, -12.8, -3.125, -0.2, 0.0, 0.2, 3.125, 12.8, 25.0, 28.1216};
 
-    for (size_t i = 0; i < stats.size(); i++) {
+    for (size_t i = 0; i < stats.size(); ++i) {
         EXPECT_DOUBLE_EQ(expectedBonuses[i], BonusFromStat(stats[i]));
     }
 }

src/test/cpp/net/eagle0/shardok/library/commands/MoveCommand_test.cpp

@@ -88,7 +88,7 @@ class MoveCommandTest : public ::testing::Test {
                 net::eagle0::shardok::storage::fb::BattalionTypeId_UNDEAD);
         undeadUnit.mutable_battalion().mutate_size(500);
         undeadUnit.mutable_location() = startLocation;
-        for (uint32_t i = 0; i < undeadUnit.opponent_knowledge()->size(); i++) {
+        for (uint32_t i = 0; i < undeadUnit.opponent_knowledge()->size(); ++i) {
             undeadUnit.mutable_opponent_knowledge()->Mutate(i, 0);
         }
         undeadUnit.mutate_remaining_action_points(12);
@@ -210,7 +210,7 @@ TEST_F(MoveCommandTest, Execute_movesActor) {
                                  zocCoords)
                                  .Execute(gameState, randomGenerator);
 
-    for (size_t i = 0; i < interimTargets.size(); i++) {
+    for (size_t i = 0; i < interimTargets.size(); ++i) {
         EXPECT_EQ(interimTargets[i], ChangedUnit(results[i], 0)->location());
     }
 }