some script cleanup (#976)

* some script cleanup

* also move the install script


Former-commit-id: cbbc6ed9675a44b607d2f9d0f32948424db3a949

Jenkinsfile

@@ -70,7 +70,7 @@ pipeline {
         stage ('build unity plugins') {
             when { expression { params.include_unity } }
             steps {
-                sh './ci/install_grpc_unity3d_plugins.sh'
+                sh './scripts/install_grpc_unity3d_plugins.sh'
             }
         }
         stage ('build') {

scripts/install_grpc_unity3d_plugins.sh

@@ -1,9 +1,15 @@
 #!/bin/bash
 
-set -e
-set -x
+set -euxo pipefail
 
-bazel --output_base=${BAZEL_OUTPUT_BASE} build \
+BAZEL="bazel --output_base=${BAZEL_OUTPUT_BASE}"
+
+if [ -z $BAZEL_OUTPUT_BASE ]; then
+  echo "no output base set, defaulting to off"
+  BAZEL="bazel"
+fi
+
+$BAZEL build \
   @grpc_unity3d//:grpc_unity3d_plugin_tar
 
 # Exclude the meta files because we want the ones in the project

scripts/install_grpc_unity_dlls.sh

@@ -18,7 +18,7 @@ $BAZEL build  --spawn_strategy=local \
   src/main/protobuf/net/eagle0/common:shardok_internal_interface.dll
 
 mkdir -p src/main/csharp/net/eagle0/clients/unity/eagle0/Assets/Plugins/Eagle0Protos/
-rm src/main/csharp/net/eagle0/clients/unity/eagle0/Assets/Plugins/Eagle0Protos/*.dll
+rm -rf src/main/csharp/net/eagle0/clients/unity/eagle0/Assets/Plugins/Eagle0Protos/*.dll
 
 cp -f bazel-bin/src/main/protobuf/net/eagle0/eagle/api/eagle_protos.dll src/main/csharp/net/eagle0/clients/unity/eagle0/Assets/Plugins/Eagle0Protos/
 cp -f bazel-bin/src/main/protobuf/net/eagle0/shardok/api/shardok_protos.dll src/main/csharp/net/eagle0/clients/unity/eagle0/Assets/Plugins/Eagle0Protos/