use newer bash (#977)

* use env bash instead of /bin/bash

* check for variable existence


Former-commit-id: 25a00ebffec9ba8c820be29c9adfd0a4c0f9cb29

ci/bazel_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 set -x

ci/build_eagle_installer_win.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 /bin/mkdir -p win_output
 /usr/bin/dotnet publish src/main/csharp/net/eagle0/clients/win/installer/EagleInstaller.sln -o win_output

ci/build_servers.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 set -x

ci/build_unity_clients.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euxo pipefail
 

ci/deploy_servers.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

ci/push_assets.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 SSH_KEY_FILE=$1
 SSH_USER_NAME=$2

ci/push_linux_exe.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 /bin/echo "Zipping"
 /bin/tar --use-compress-program="/usr/bin/pigz" -cf ./eagle0linux/eagle0_linux.tar.gz ./eagle0linux/eagle0

ci/push_mac_exe.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 /bin/echo "Zipping"
 /bin/tar --use-compress-program="/usr/bin/pigz" -cf ./eagle0mac/eagle0_mac.tar.gz ./eagle0mac/eagle0.app

ci/push_notarized_mac_exe.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euxo pipefail
 

ci/push_win_exe.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

scripts/add_setting.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 KEY=$1
 VALUE=$2

scripts/codesign.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 /usr/bin/security/security unlock-keychain development.keychain
 /usr/bin/codesign/codesign --deep --force --verify --verbose --timestamp --options runtime --sign "Apple Development: Daniel Crosby (AJ28LCLQQ8)" $1

scripts/dlSettings.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 curl -L "https://docs.google.com/spreadsheets/d/1pv-WMXReccddPwev_YG9IXEGznuGHrYjNNEZ0Rb-ZhM/export?gid=0&format=tsv" > src/main/resources/net/eagle0/shardok/settings.tsv
 curl -L "https://docs.google.com/spreadsheets/d/1p6I5nUMcoAPHIcqikVgbBCFVnqN9dpOEVClbS_wOI7M/export?gid=0&format=tsv" > src/main/resources/net/eagle0/eagle/settings.tsv

scripts/downloadTsvs.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 curl -L "https://docs.google.com/spreadsheets/d/1DHEsiv4cY4gE6AX3sVH82K__mpBD1aznIYCQwQxA_F0/export?gid=0&format=tsv" > src/main/resources/net/eagle0/names.tsv
 curl -L "https://docs.google.com/spreadsheets/d/1NhvG73HKyVE36yGpkV2oJiSIXoNqQOYTr5ArLnucYL0/export?gid=0&format=tsv" > src/main/resources/net/eagle0/shardok/battalionTypes.tsv

scripts/format-csharp.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 dotnet-format ./src/main/csharp/net/eagle0/clients/unity/eagle0/eagle0.sln --exclude Assets/Plugins/SimpleFileBrowser Assets/Modern\ UI\ Pack Assets/Terrain\ Hexes Assets/Plugins/AsyncAwaitUtil Assets/GUI\ Pro\ Kit\ Fantasy\ RPG
 dotnet-format ./src/main/csharp/net/eagle0/clients/unity/eagle0/Assembly-CSharp.sln --exclude Assets/Plugins/SimpleFileBrowser Assets/Modern\ UI\ Pack Assets/Terrain\ Hexes Assets/Plugins/AsyncAwaitUtil Assets/GUI\ Pro\ Kit\ Fantasy\ RPG

scripts/install_grpc_unity3d_plugins.sh

@@ -1,10 +1,10 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
-set -euxo pipefail
+set -exo pipefail
 
+if [[ -n "$BAZEL_OUTPUT_BASE" ]]; then
   BAZEL="bazel --output_base=${BAZEL_OUTPUT_BASE}"
-
-if [ -z $BAZEL_OUTPUT_BASE ]; then
+else
   echo "no output base set, defaulting to off"
   BAZEL="bazel"
 fi

scripts/install_grpc_unity_dlls.sh

@@ -1,11 +1,10 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
-set -e
-set -x
+set -exo pipefail
 
+if [[ -n "$BAZEL_OUTPUT_BASE" ]]; then
   BAZEL="bazel --output_base=${BAZEL_OUTPUT_BASE}"
-
-if [ -z $BAZEL_OUTPUT_BASE ]; then
+else
   echo "no output base set, defaulting to off"
   BAZEL="bazel"
 fi

scripts/update_dependencies.sh

@@ -1,4 +1,5 @@
-#!/bin/bash
+#!/usr/bin/env bash
+
 echo -ne "\033[0;32m"
 echo 'Updating bazel dependencies. This will take about five minutes.'
 echo -ne "\033[0m"