Fail incomplete LLM streams

2026-07-28 21:55:42 +00:00 · 2026-06-29 10:38:26 -07:00
parent 913d0d5e4b
commit e8e59565ac
1 changed files with 13 additions and 3 deletions
@@ -603,9 +603,19 @@ class LlmResolver(updateReceiver: LlmUpdateQueuingProxy, isGameValid: GameId =>
                      )
                      .transform {
                        case Success(result)                                     =>
+                          if streamCompleted.get() then {
                            logProviderFutureFinished("succeeded")
                            recordProviderSuccess(providerName)
                            Success(result)
+                          } else {
+                            logProviderFutureFinished("succeeded-without-completed-callback")
+                            Failure(
+                              new EagleInternalException(
+                                s"Provider $providerName future succeeded before completed stream callback for " +
+                                  s"${LlmResolver.diagnosticSummary(llmRequest)}"
+                              )
+                            )
+                          }
                        case Failure(e: ExternalTextGenerationError.ServerError) =>
                          logProviderFutureFinished(s"failed(${e.getClass.getSimpleName})")
                          recordProviderFailure(providerName)